[Gnash-commit] gnash ChangeLog libgeometry/Range2d.h testsuite...

2006-12-03 Thread Sandro Santilli
CVSROOT:/sources/gnash Module name:gnash Changes by: Sandro Santilli 06/12/03 21:43:11 Modified files: . : ChangeLog libgeometry: Range2d.h testsuite/libgeometry: Range2dTest.cpp Log message: * testsuite/libgeometry/Ran

Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h backen...

2006-12-03 Thread Sandro Santilli
Udo, may I ask you to fix/comment all those things yourself ? I'm still tweaking the Range2d class, in particular the 'limits hit detection' code for growBy and shrinkBy, which seems broken (I'd like the doxgen comment to be stable, and fix the impelmentation) --strk; On Sun, Dec 03, 2006 at 03:2

Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h server...

2006-12-03 Thread Sandro Santilli
On Sun, Dec 03, 2006 at 03:27:36PM +0100, Udo Giacomozzi wrote: > Hello Sandro, > > Friday, December 1, 2006, 4:52:17 PM, you wrote: > SS> + /// TODO: Take a Range2d rather then a gnash::rect ? > SS> + /// Would T==int be good ? TWIPS as integer types ? > > It would be enough but as far a

Re[2]: [Gnash-commit] gnash ChangeLog backend/render_handler.h backen...

2006-12-03 Thread Udo Giacomozzi
Hello Udo, Sunday, December 3, 2006, 3:21:55 PM, you wrote: UG> The comment means that top+height is *not* max_y but it's (max_y+1). UG> Just avoiding an addition... Sorry, I meant subtraction: const unsigned int max_y = top+height-1; would be a real "max_y". Udo _

Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h server...

2006-12-03 Thread Udo Giacomozzi
Hello Sandro, Friday, December 1, 2006, 4:52:17 PM, you wrote: SS> + /// TODO: Take a Range2d rather then a gnash::rect ? SS> + /// Would T==int be good ? TWIPS as integer types ? It would be enough but as far as I remember we discussed that it's probably better to use floats to avoid lot

Re: [Gnash-commit] gnash ChangeLog gui/fb.cpp gui/gtk.cpp

2006-12-03 Thread Udo Giacomozzi
Hello Sandro, Saturday, December 2, 2006, 10:28:06 PM, you wrote: SS> * gui/fb.cpp, gui/gtk.cpp: don't render anything SS> if _drawbounds.isNull() - we should make sure SS> that _drawbounds is expanded to cover 'newly' exposed SS>

Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h backen...

2006-12-03 Thread Udo Giacomozzi
Hello Sandro, Saturday, December 2, 2006, 10:03:50 PM, you wrote: SS> - void clear(unsigned int left, unsigned int top, unsigned int width, SS> -unsigned int height) { SS> + void clear(geometry::Range2d region) Uhm. clear() is something like an extension to AGG because it does not provide