Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-12 Thread Chris Shoemaker
On Mon, Dec 11, 2006 at 11:01:55PM -0500, Derek Atkins wrote: I'll just point out a couple of things: 1) This patch doesn't actually change any data formats, because there's no data in those fields. So without additional changes (which I agree should not get backported), there's no

Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-12 Thread Christian Stimming
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Atkins schrieb: 1) This patch doesn't actually change any data formats, because there's no data in those fields. So without additional changes (which I agree should not get backported), there's no chance of a data format change. Does

Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-12 Thread Derek Atkins
Quoting Christian Stimming [EMAIL PROTECTED]: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Atkins schrieb: 1) This patch doesn't actually change any data formats, because there's no data in those fields. So without additional changes (which I agree should not get backported),

Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-12 Thread Derek Atkins
Quoting Chris Shoemaker [EMAIL PROTECTED]: On Tue, Dec 12, 2006 at 10:36:42AM -0500, Derek Atkins wrote: snip 2.0.[0123] will read a data file with this new object and just ignore it (and drop it on the floor) without erroring out. If that's true, then I withdraw my objection. Just to

Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-11 Thread Chris Shoemaker
On Mon, Dec 11, 2006 at 09:51:37PM -0500, Derek Atkins wrote: Author: warlord Date: 2006-12-11 21:51:37 -0500 (Mon, 11 Dec 2006) New Revision: 15205 Trac: http://svn.gnucash.org/trac/changeset/15205 Modified: gnucash/trunk/ gnucash/trunk/src/backend/file/gnc-commodity-xml-v2.c Log:

Re: AUDIT: r15205 - gnucash/trunk - Load and store a commodity's KVP-frame (IFF it's non-empty).

2006-12-11 Thread Derek Atkins
I'll just point out a couple of things: 1) This patch doesn't actually change any data formats, because there's no data in those fields. So without additional changes (which I agree should not get backported), there's no chance of a data format change. 2) Your proposed change makes it