Re: Review Request and Questions

2019-05-21 Thread Brian (bex) Exelbierd
On Tue, May 21, 2019 at 5:40 PM Neal Gompa wrote: > > On Tue, May 21, 2019 at 11:32 AM Brian (bex) Exelbierd > wrote: > > > > On Tue, May 21, 2019 at 4:53 PM Nicolas Mailhot > > wrote: > > > > > > Le mardi 21 mai 2019 à 10:43 +0200, Brian (bex) Exelbierd a écrit : > > > > BUILDDATE=$(date

Re: Review Request and Questions

2019-05-21 Thread Nicolas Mailhot
Le mardi 21 mai 2019 à 17:31 +0200, Brian (bex) Exelbierd a écrit : > > > > BUILDDATE=$(date +%Y-%m-%d) > > > > Please don't do that, that breaks build reproducibility. > > My understanding is that reproducible build systems typically provide > a build date value. A reproducible build means

Re: Review Request and Questions

2019-05-21 Thread Brian (bex) Exelbierd
On Tue, May 21, 2019 at 4:53 PM Nicolas Mailhot wrote: > > Le mardi 21 mai 2019 à 10:43 +0200, Brian (bex) Exelbierd a écrit : > > Hi, > > > > I have submitted the first of my dependency review requests here: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1712280 > > > > Feedback is greatly

Re: Review Request and Questions

2019-05-21 Thread Nicolas Mailhot
Le mardi 21 mai 2019 à 10:43 +0200, Brian (bex) Exelbierd a écrit : > Hi, > > I have submitted the first of my dependency review requests here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1712280 > > Feedback is greatly appreciated so I can clean anything up on the > next > set of

Re: Review Request and Questions

2019-05-21 Thread Brian (bex) Exelbierd
Thank you for the reply - I'll work on that. regards, bex On Tue, May 21, 2019 at 3:25 PM Robert-André Mauchin wrote: > > On Tuesday, 21 May 2019 10:43:04 CEST Brian (bex) Exelbierd wrote: > > Hi, > > > > I have submitted the first of my dependency review requests here: > > > >

Re: Review Request and Questions

2019-05-21 Thread Robert-André Mauchin
On Tuesday, 21 May 2019 10:43:04 CEST Brian (bex) Exelbierd wrote: > Hi, > > I have submitted the first of my dependency review requests here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1712280 > > Feedback is greatly appreciated so I can clean anything up on the next > set of

Review Request and Questions

2019-05-21 Thread Brian (bex) Exelbierd
Hi, I have submitted the first of my dependency review requests here: https://bugzilla.redhat.com/show_bug.cgi?id=1712280 Feedback is greatly appreciated so I can clean anything up on the next set of dependencies. I am working on the main application packaging for gocryptfs