Re: [go-nuts] Re: New site go.dev is awful

2021-11-24 Thread 'Axel Wagner' via golang-nuts
https://github.com/golang/go/issues/49765 https://go-review.googlesource.com/c/website/+/366976/ On Thu, Nov 25, 2021 at 8:50 AM 'Carla Pfaff' via golang-nuts < golang-nuts@googlegroups.com> wrote: > On Wednesday, 24 November 2021 at 22:53:33 UTC+1 ben...@gmail.com wrote: > >> 2) The download

[go-nuts] Re: New site go.dev is awful

2021-11-24 Thread 'Carla Pfaff' via golang-nuts
On Wednesday, 24 November 2021 at 22:53:33 UTC+1 ben...@gmail.com wrote: > 2) The download link is for the Windows binary, and I'm running Linux. > Would be nice if it could try to auto-detect based on my User-Agent, which > includes the words "X11", "Ubuntu", and "Linux". > The website

Re: [go-nuts] some incorrect code in blog.

2021-11-24 Thread David Karr
On Wed, Nov 24, 2021 at 6:14 PM Fannie Zhang wrote: > Hi all, > > There is some incorrect code in > https://go.dev/blog/defer-panic-and-recover blog. > > The original code is > *func CopyFile() {* > * ...* > * if err != nil {* > * return* > * }* > * defer src.Close()* > * ...* >

Re: [go-nuts] some incorrect code in blog.

2021-11-24 Thread Ian Lance Taylor
On Wed, Nov 24, 2021 at 6:14 PM Fannie Zhang wrote: > > There is some incorrect code in https://go.dev/blog/defer-panic-and-recover > blog. > > The original code is > func CopyFile() { >... >if err != nil { > return >} >defer src.Close() >... > } > > I think the correct

Re: [go-nuts] some incorrect code in blog.

2021-11-24 Thread Leam Hall
On 11/24/21 20:26, Kurtis Rader wrote: Notice the date of that blog article: 2010-08-04. It's more than eleven years old. Blog articles are not updated as the language changes. It might be good to resolve that. If the authoritative info source for the language makes a habit of keeping old

Re: [go-nuts] some incorrect code in blog.

2021-11-24 Thread Kurtis Rader
Notice the date of that blog article: 2010-08-04. It's more than eleven years old. Blog articles are not updated as the language changes. However, in this case the example in that article is correct. If `os.Open()` returns an error then the `src` return value is invalid. On Wed, Nov 24, 2021 at

[go-nuts] some incorrect code in blog.

2021-11-24 Thread Fannie Zhang
Hi all, There is some incorrect code in https://go.dev/blog/defer-panic-and-recover blog. The original code is *func CopyFile() {* * ...* * if err != nil {* * return* * }* * defer src.Close()* * ...* *}* I think the correct code should be *func CopyFile() {* * ...* * defer

Re: [go-nuts] Re: New site go.dev is awful

2021-11-24 Thread Jan Mercl
On Wed, Nov 24, 2021 at 10:53 PM ben...@gmail.com wrote: > 2) The download link is for the Windows binary, and I'm running Linux. [image: image.png] -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop

[go-nuts] Re: New site go.dev is awful

2021-11-24 Thread ben...@gmail.com
I don't think it's awful, and Carla's right, there's always going to be debate about these changes and a settling period. However, I do think the criticism of it being too corporate-looking now is valid. Two pieces of concrete feedback (in case the maintainers are listening), one on how to

[go-nuts] Re: New site go.dev is awful

2021-11-24 Thread Hein Meling
I also don’t like it very much… it is just too noisy. But I haven’t spent enough time with it to really make a note of concrete issues. :) Hein On Tuesday, November 23, 2021 at 7:46:19 PM UTC+1 poe...@gmail.com wrote: > Am I the only one who thinks this? The old site golang.org had a simple >