[go-nuts] Re: Go += Package Versioning

2018-02-24 Thread Spencer Nelson
I'd like to better understand how multiple-module repositories work if tagged commits are used for minor and patch versioning. My understanding is that major version increments are controlled with import paths, while minor and patch version increments are controlled with commit tags. Is it

Re: [go-nuts] Why does vet's 'rangeloop' check only check the last statement of a loop?

2017-08-14 Thread 'Spencer Nelson' via golang-nuts
Yes, very tricky stuff. I've replied on the issue - it seems best to keep discussion in one place. Thank you very much for opening the issue! On Mon, Aug 14, 2017 at 2:35 PM, Ian Lance Taylor wrote: > On Fri, Aug 11, 2017 at 4:38 PM, Ian Lance Taylor wrote: >

Re: [go-nuts] Why does vet's 'rangeloop' check only check the last statement of a loop?

2017-08-10 Thread spencer
Yes, it makes sense that it would be impossible to really check at that level. What surprised me was that this does not trigger vet: for i := range slice { go f(i) _ = 1 } Yet this does trigger vet: for i := range slice { _ = 1 go f(i) } Is there something special about the

[go-nuts] Why does vet's 'rangeloop' check only check the last statement of a loop?

2017-08-10 Thread spencer
I've noticed that cmd/vet's rangeloop check, which warns you about binding to range loop variables in function literals which are launched with 'go' or 'defer', is more limited than I thought: