Re: Issue 806 in google-guice: ContinuingHttpServletRequest: Make cookies immutable

2014-05-20 Thread Dhanji R. Prasanna
Great, thanks! On Tue, May 20, 2014 at 10:05 AM, google-gu...@googlecode.com wrote: Comment #5 on issue 806 by sa...@google.com: ContinuingHttpServletRequest: Make cookies immutable http://code.google.com/p/google-guice/issues/detail?id=806 Sure -- it'd be great to have you actively

Proposal: requireBinding error message

2010-09-12 Thread Dhanji R. Prasanna
Right now we can require bindings but that just spits out a missing binding error. I think it would be cool to allow users to specify a why it's required. requireBinding(UnitOfWork.class, Persistence provider must bind an implementation for the unit of work to be managed. This is likely not a

Re: Guice 3.0 Status

2010-07-30 Thread Dhanji R. Prasanna
2010/7/30 Endre Stølsvik stols...@gmail.com On Wed, Jul 28, 2010 at 11:48, Stuart McCulloch mccu...@gmail.com wrote: 2010/7/28 Endre Stølsvik stols...@gmail.com So the don't proxy method is basically worthless, then? well the method does exactly what it says it will do - proxies won't be

Re: Guice 3.0 Status

2010-07-27 Thread Dhanji R. Prasanna
, Dhanji R. Prasanna dha...@gmail.comwrote: (I mean, you can't really inject until a dep is injected first anyway, so this ordering is natural). I agree that this order is natural - but that is where I have understood that Guice didn't bother: It just injected down the road, supplying proxies

Re: Guice 3.0 Status

2010-07-17 Thread Dhanji R. Prasanna
Hey thanks for this list... Persist extension is wanting, It'll be another week at least before I can give it the right attention. For servlet, we need to build some kind of introspection API that's similar to injector's, but that can wait I suppose. If we can turn injector builder's options

Re: Should guice-persist require guice-servlet?

2010-07-07 Thread Dhanji R. Prasanna
How strange! =) On Wed, Jul 7, 2010 at 11:31 AM, Max Bowsher m...@f2s.com wrote: On 07/07/10 01:29, Dhanji R. Prasanna wrote: Does it? It only installs PersistenceFilter if you specify unit of work as request. So in a non-servlet app it will never load that class. We might do as you

Re: Status of guice lifecycle

2010-07-07 Thread Dhanji R. Prasanna
It was just an experiment--it's going to be removed entirely. We need to rethink it from the ground up. On Wed, Jul 7, 2010 at 10:13 AM, Max Bowsher m...@f2s.com wrote: The code in the lifecycle directory of the source looks rather interesting. On the other hand, there has been mention of

Re: Should guice-persist require guice-servlet?

2010-07-06 Thread Dhanji R. Prasanna
Does it? It only installs PersistenceFilter if you specify unit of work as request. So in a non-servlet app it will never load that class. We might do as you suggest anyway though--haven't quite finalized the design of how PersistFilter should work.. Dhanji. On Wed, Jul 7, 2010 at 9:37 AM, Max

Re: Guice 3.0 Release?

2010-07-02 Thread Dhanji R. Prasanna
I didn't say anything about changing the build system to maven, just make them proper build poms. Our ant build scripts are in need of some attention themselves. Dhanji. On Fri, Jul 2, 2010 at 4:40 PM, Max Bowsher m...@f2s.com wrote: On 02/07/10 06:23, Dhanji R. Prasanna wrote: That pom

Re: Guice 3.0 Release?

2010-07-01 Thread Dhanji R. Prasanna
That pom is only a distribution pom. I think if we change it we should make it a proper build pom. Greg Kick is the right person to talk to because he handles our (Google's) official maven repo. Dhanji. On Fri, Jul 2, 2010 at 1:43 PM, Sam Berlin sber...@gmail.com wrote: I believe there is a

Re: Guice 3.0 Release?

2010-06-28 Thread Dhanji R. Prasanna
Sam, Sounds awesome! I would love to also include the cleaned up guice-persist extension as well as the fixes to Servlet module to properly support multiple servlet pipelines in one app (potentially useful for app containers like Tomcat). Dhanji. PS: we should also think about getting a blog

Re: Ping? Could a Guice maintainer comment? (Re: Move internal utility code to separate package?)

2010-06-10 Thread Dhanji R. Prasanna
We should just obfuscate Immutable* so it doesn't bother IDE importers. Wonder if Jarjar can do that. Dhanji. On Thu, Jun 10, 2010 at 11:37 AM, Johannes Schneider maili...@cedarsoft.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/10/2010 08:20 PM, Eric Burke wrote: -1 to

Re: ConstructorInjectorStore.cache not working

2010-04-25 Thread Dhanji R. Prasanna
Also feels like our startup time on GAE is slow. I'm not sure that's related to this but it's also something we should keep an eye on. Dhanji. On Monday, April 26, 2010, Sam Berlin sber...@gmail.com wrote: Were you able to dig into what's going on at all?  I'm scanning through some old issues

Re: How eager is eager?

2009-06-04 Thread Dhanji R. Prasanna
1 On Thu, Jun 4, 2009 at 12:31 PM, je...@swank.ca limpbiz...@gmail.comwrote: What should the following program print? @Singleton class B { static int instanceCount = 0; int instanceId = instanceCount++; public static void main(String[] args) { Injector injector =

Re: [google-guice] limpbizkit commented on branch /branches/1.0-maven.

2009-02-18 Thread Dhanji R. Prasanna
On Thu, Feb 19, 2009 at 10:01 AM, codesite-nore...@google.com wrote: Line 5: parent --- Aaah. . . . I'm learning Maven a bit here. The parent is another target that . .. owns this? Oh no! you are learning

Re: Issue 239 in google-guice: Integrate Warp-Servlet as com.google.inject.servlet

2008-12-15 Thread Dhanji R. Prasanna
On Tue, Dec 16, 2008 at 10:17 AM, codesite-nore...@google.com wrote: Comment #6 on issue 239 by dhanji: Integrate Warp-Servlet as com.google.inject.servlet http://code.google.com/p/google-guice/issues/detail?id=239 and elsewhere serve(/xx).with(..) er, this should be

asEagerSingleton()

2008-12-01 Thread Dhanji R. Prasanna
I am seeing loads of abuses of eager singleton as a startup lifecycle hook. I wonder if it would be worth us deprecating it or making it show a warning of some sort. Since this doesn't really mean anything in PROD mode, perhaps it should be an annotation instead? bind()

Re: asEagerSingleton()

2008-12-01 Thread Dhanji R. Prasanna
, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: On Dec 1, 9:44 pm, Dhanji R. Prasanna [EMAIL PROTECTED] wrote: I am seeing loads of abuses of eager singleton as a startup lifecycle hook. I wonder if it would be worth us deprecating it or making it show a warning of some sort. Since this doesn't