LGTM
http://gwt-code-reviews.appspot.com/8803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: rjrjr,
Description:
We deprecate ListBox's setMultipleSelect.
Please review this at http://gwt-code-reviews.appspot.com/7801
Affected files:
user/src/com/google/gwt/user/client/ui/ListBox.java
Index: user/src/com/google/gwt/user/client/ui/ListBox.java
Reviewers: rjrjr,
Description:
Adding protected getHandlerCount() to widget plus a basic widget
unittest to test the implementation..
Please review this at http://gwt-code-reviews.appspot.com/7802
Affected files:
user/src/com/google/gwt/user/client/ui/Widget.java
Reviewers: jlabanca,
Description:
Adds some more visual tests and some helper methods to create more
visual visual tests still. We love to test don't we :-).
Please review this at http://gwt-code-reviews.appspot.com/2807
Affected files:
http://gwt-code-reviews.appspot.com/2807/diff/1/3
File
reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java
(right):
http://gwt-code-reviews.appspot.com/2807/diff/1/3#newcode78
Line 78: HandlerRegistration r;
On 2009/02/12 20:17:30, jlabanca wrote:
can you use a
Reviewers: itruett,
Description:
This patch upgraded the gwt-incubator build.demos task in the following
way:
* upgrades target to use new Compiler class, with war rather then out
argument
* upgrades the index.html to allow each demo to be easily seen in a
stand alone frame as well as
style names that were set/added; the only style names that are
preserved
@@ -225,18 +223,21 @@
private static class UnclippedState extends State {
UnclippedState(Element element) {
- // Todo(ecc) This is wrong, we should not be sinking these here on
such a
- // common
http://gwt-code-reviews.appspot.com/2801/diff/1/7
File src/com/google/gwt/gen2/widgetbase/public/FastTree.css (right):
http://gwt-code-reviews.appspot.com/2801/diff/1/7#newcode66
Line 66: background: #e3e8f3 url('%selectionBar%') repeat-x;
The problem is that this css file needs to work for
Reviewers: nwolf,
Description:
This patch fixes the dependencies for FastTree, removes dependencies on
deprecated gwt 1.6 classes, and adds the css using the interim structure
we've fallen back on until the next time.
Please review this at http://gwt-code-reviews.appspot.com/2801
Affected
This is such awesome new functionality, thanks Joel!
There are a couple of things I didn't understand, listed below, please
ping me if any of the comments don't make sense! I think we also need
an Image test, as it looks like the current image test never actually
checks if the load handler is
want to add a note in
the NativeEvent javadoc directing folks to Document as well though.
On 2009/01/27 22:37:33, rjrjr wrote:
On 2009/01/27 20:27:05, ecc wrote:
Now that we have a NativeEvent class, should we move these methods
there? As
that would seem more natural to me.
I think
Reviewers: jlabanca,
Description:
This is about the third or forth time we've run into a bug fixed in
FastTree but not in Tree or visa-versa, it might be time in GWT 2.0 to
break our current tree implementation and replace it rather then trying
to support two almost-identical widgets.
Please
Reviewers: jlabanca,
Description:
This patch makes listener wrapper public. It also switching the default
conversion of TextBox.addChangeListener from a custom addDomHandler
solution to TextBox.addValueChangeHandler
Please review this at http://gwt-code-reviews.appspot.com/2207
Affected files:
Reviewers: fabbott,
Description:
Right now about one in a hundred builds or so api checker will break,
this patch creates a convenient target to programmers making changes to
user can run the tests, api checker, and the checkstyle checks as one
command.
It also fixed our checkstyle config by
http://gwt-code-reviews.appspot.com/2205/diff/1/6
File user/src/com/google/gwt/event/Event.gwt.xml (right):
http://gwt-code-reviews.appspot.com/2205/diff/1/6#newcode2
Line 2: source path=shared/
Totally agreed about the overall goal. I was suggesting a slight naming
change:
gwt.foo.Foo -- in
LGTM
http://gwt-code-reviews.appspot.com/2201
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jlabanca,
Description:
This set of changes pulls in work done in gwt-incubator on the now
defunct SuggestBoxOverride, it addresses issues 2598, 2739,2888. Also
has the following features:
Adds ability to create default list of suggestions.
Opens the MultiWordSuggestOracle up
Reviewers: jlabanca,
Description:
For SuggestBox and DropDownListBox, porting the RollDown animation class
from incubator. Testing in the suggest box visual test.
Please review this at http://gwt-code-reviews.appspot.com/2004
Affected files:
We need to add the doc to the old methods on what people should do
instead, assuming that is done, LGTM.
http://gwt-code-reviews.appspot.com/1804/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabPanel.java (left):
http://gwt-code-reviews.appspot.com/1804/diff/1/2#oldcode363
Line 363:
Looks good overall, only quibble is it would be nice to use array list
rather then hash set to store the auto hide partners.
http://gwt-code-reviews.appspot.com/2001/diff/1/4
File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right):
Reviewers: jlabanca,
Description:
Fixes issue 3181
(http://code.google.com/p/google-web-toolkit/issues/detail?id=3181q=owner:ecc%20DatePicker)
by making the show range event fire at the correct time.
Please review this at http://gwt-code-reviews.appspot.com/610
Affected files:
http://gwt-code-reviews.appspot.com/606/diff/1/7
File user/src/com/google/gwt/event/logical/shared/HasNativeEvent.java
(right):
http://gwt-code-reviews.appspot.com/606/diff/1/7#newcode32
Line 32: }
Should this interface be in gwt.event.dom.client instead?
Reviewers: jlabanca,
Description:
Issue details
at:http://code.google.com/p/google-web-toolkit/issues/detail?id=3194q=owner:eccsort=priority
Please review this at http://gwt-code-reviews.appspot.com/607
Affected files:
user/src/com/google/gwt/user/client/ui/FiresDisclosureEvents.java
Reviewers: jlabanca,
Description:
Adding Happy event to javadoc in order to be able to refer to it in the
events wiki design doc.
Please review this at http://gwt-code-reviews.appspot.com/813
Affected files:
user/javadoc/com/google/gwt/examples/events/HappyEvent.java
Reviewers: jlabanca,
Description:
Code review request for gwt issue (3189)
Fixes the default Widget code to not trigger mouse enter/leave events
when the user did not actually leave or enter the widget.
http://code.google.com/p/google-web-toolkit/issues/detail?id=3189
Please review this at
On 2008/12/09 18:01:50, jlabanca wrote:
LGTM
Committed at 4298.
http://gwt-code-reviews.appspot.com/603
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jlabanca,
Description:
John,
Could you review this fix for the assertion error that happens in
some circumstances when you remove Window listeners? Also included are
two new test cases to ensure we don't have a regression on this issue.
As a side note, I think this situation is
Reviewers: jlabanca,
Description:
Allows collapsible panel to have it state controlled via code.
Please review this at http://gwt-code-reviews.appspot.com/809
Affected files:
src-demo/com/google/gwt/widgetideas/demo/collapsiblepanel/client/CollapsiblePanelDemo.java
The expansion of the tab interface looks great. Don't quite understand
the change to the default word wrapping...
http://gwt-code-reviews.appspot.com/604/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):
http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488
Line
LGTM
http://codereview.appspot.com/9656
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
30 matches
Mail list logo
