[gwt-contrib] CSS Media types are comma separated. (issue1861804)

Reviewers: mdempsky, Description: CSS Media types are comma separated. Please review this at http://gwt-code-reviews.appspot.com/1861804/ Affected files: M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java M user/test/com/google/gwt/resources/css/CssNodeClonerTest.java M

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

http://gwt-code-reviews.appspot.com/1861804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java (right):

[gwt-contrib] Re: Thanks minichate! (issue1863803)

http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Thanks minichate! (issue1863803)

http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Thanks minichate! (issue1863803)

Reviewers: skybrian, Description: Thanks minichate! GWT CSS parser was dropping media types. Fixes issue: 4911 Please review this at http://gwt-code-reviews.appspot.com/1863803/ Affected files: M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java M

[gwt-contrib] Re: Bugfix @media queries in CssResource (issue1862803)

LGTM. Resubmitting internally at http://gwt-code-reviews.appspot.com/1863803 On 2012/10/26 04:44:12, Andrew Bachmann wrote: Thanks for the patch. Nice find. http://gwt-code-reviews.appspot.com/1862803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Thanks minichate! (issue1863803)

This is partially from a patch contributed by an external developer. See http://gwt-code-reviews.appspot.com/1862803/ http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update validator version to Final rather than GA (issue1847805)

LGTM http://gwt-code-reviews.appspot.com/1847805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

http://gwt-code-reviews.appspot.com/1794803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

Submitted as r11231. http://gwt-code-reviews.appspot.com/1794803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

Ping http://gwt-code-reviews.appspot.com/1794803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

Ping. On 2012/08/10 15:33:27, rchandia wrote: Ready for a second round. On 2012/08/08 14:10:11, rchandia wrote: http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

Ready for a second round. On 2012/08/08 14:10:11, rchandia wrote: http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java (right): http://gwt-code-reviews.appspot.com

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)

http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml#newcode183 samples/mobilewebapp/pom.xml:183: target1.6/target Change tabs to spaces

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

http://gwt-code-reviews.appspot.com/1794803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allows UiRenderer styles before the first call to render() (issue1794803)

http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java (right):

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)

http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml File samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml (right):

[gwt-contrib] Allows UiRenderer styles before the first call to render() (issue1794803)

Reviewers: rdayal, Description: Allows UiRenderer styles before the first call to render() Fields are initialized both upon construction and on a call to render() Also ensured that ui:with fields never get optimized as final. Please review this at http://gwt-code-reviews.appspot.com/1794803/

[gwt-contrib] Re: Include sources in gwt-codeserver.jar (issue1768804)

Submitted as r11159. On 2012/07/01 04:22:08, skybrian wrote: LGTM http://gwt-code-reviews.appspot.com/1768804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Include sources in gwt-codeserver.jar (issue1769803)

Submitted as r11159. http://gwt-code-reviews.appspot.com/1769803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Include sources in gwt-codeserver.jar (issue1768804)

Reviewers: skybrian, Description: Include sources in gwt-codeserver.jar Repost of issue 1769803. Thanks Thomas! This should fix the Maven deployment to Central, which requires sources (at least now there's a gwt-codeserver-${gwt.version}-sources.jar artifact generated and deployed). Fixes

[gwt-contrib] Re: Include sources in gwt-codeserver.jar (issue1769803)

LGTM. Reposting at http://gwt-code-reviews.appspot.com/1768804 http://gwt-code-reviews.appspot.com/1769803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)

http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)

http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)

http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)

Submitted as r11136 http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix a type. (issue1742803)

LGTM http://gwt-code-reviews.appspot.com/1742803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update POM versions to 2.5.0-rc1 (issue1734804)

Submitted as r11057 http://gwt-code-reviews.appspot.com/1734804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Prevent compilation failures due to type inferencing bugs (bug 6302954 at bugs.sun.com) in older... (issue1736805)

LGTM http://gwt-code-reviews.appspot.com/1736805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] MeniItem should use ScheduledCommand instead of Command (issue1726805)

Reviewers: rdayal, Description: MeniItem should use ScheduledCommand instead of Command Repost of 1698803 Thanks Patrick! Patch by: tucker...@gmail.com Please review this at http://gwt-code-reviews.appspot.com/1726805/ Affected files: M tools/api-checker/config/gwt24_25userApi.conf M

[gwt-contrib] Re: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

Great change, but UiRenderer is not a part of GWT 2.4.0 release while project's pom file depend on it. Any comments? That'd be a bug. I guess it should be 2.5.0, but that version has not been released yet. What is the Maven way to do this? http://gwt-code-reviews.appspot.com/1733805/ --

[gwt-contrib] Re: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

On 2012/06/13 16:23:11, kromanovs wrote: Well, you can add dependency to 2.5.0-SNAPSHOT if it's available in the maven central repo. If it's not - then I think it's not yet a time to push this change out. GWT 2.5 is in the process of being released. I rather think it is time to update the

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1726805)

Submitted as r11052 http://gwt-code-reviews.appspot.com/1726805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update POM versions to 2.5.0-rc1 (issue1734804)

Reviewers: rdayal, tbroyer, Description: Update POM versions to 2.5.0-rc1 Please review this at http://gwt-code-reviews.appspot.com/1734804/ Affected files: M samples/dynatablerf/pom.xml M samples/expenses/pom.xml M samples/mobilewebapp/pom.xml M samples/validation/pom.xml Index:

[gwt-contrib] Adds a comment requesting an method type parameter to be kept, (issue1730805)

Reviewers: rdayal, Description: Adds a comment requesting an method type parameter to be kept, even though it looks redundant, to satisfy OpenJDK. Please review this at http://gwt-code-reviews.appspot.com/1730805/ Affected files: M user/test/com/google/gwt/editor/client/DirtyEditorTest.java

[gwt-contrib] Re: Adds a comment requesting an method type parameter to be kept, (issue1730805)

http://gwt-code-reviews.appspot.com/1730805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a comment requesting an method type parameter to be kept, (issue1730805)

http://gwt-code-reviews.appspot.com/1730805/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right):

[gwt-contrib] Complete text-* support for Style (issue1737804)

Reviewers: rdayal, Description: Complete text-* support for Style Reposting of 1736803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1737804/ Affected files: M user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java M

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

LGTM. With a Nit. http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right):

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

LGTM On 2012/06/08 18:27:29, stephenh wrote: I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Huh, I thought I had Eclipse configured to show checkstyle errors like that--but I don't see it. I see other errors like methods not

[gwt-contrib] Re: Complete text-* support for Style (issue1737804)

Submitted as r11033 http://gwt-code-reviews.appspot.com/1737804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Checkstyle fixes (issue1725807)

Reviewers: rdayal, Description: Checkstyle fixes Repost of 1565806 Thanks Stephen! Patch by: stephen.haber...@gmail.com Please review this at http://gwt-code-reviews.appspot.com/1725807/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java M

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

Submitted as r11034 http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkstyle fixes (issue1725807)

Submitted as r11034 http://gwt-code-reviews.appspot.com/1725807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

Submitted as r11035 http://gwt-code-reviews.appspot.com/1733805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right):

[gwt-contrib] Add javadocs for ExternalTextResource.getText (issue1733804)

Reviewers: rdayal, Description: Add javadocs for ExternalTextResource.getText Repost of 1605803. Thanks Stephen! Fixes issue: 7035 Please review this at http://gwt-code-reviews.appspot.com/1733804/ Affected files: M user/src/com/google/gwt/resources/client/ExternalTextResource.java

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

LGTM. Reposted at http://gwt-code-reviews.appspot.com/1733804/ http://gwt-code-reviews.appspot.com/1605803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

Submitted as r11027 http://gwt-code-reviews.appspot.com/1605803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText (issue1733804)

Submitted as r11027 http://gwt-code-reviews.appspot.com/1733804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

Submitted as r11028 http://gwt-code-reviews.appspot.com/1700803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

Reviewers: rdayal, Description: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. Please review this at http://gwt-code-reviews.appspot.com/1733805/ Affected files: D samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskEditView.css M

[gwt-contrib] Add HasEnabled to FileUpload. (issue1727805)

Reviewers: rdayal, Description: Add HasEnabled to FileUpload. Repost of 1614808. Thanks Stephen! Fixes issues: 5677 Please review this at http://gwt-code-reviews.appspot.com/1727805/ Affected files: M user/src/com/google/gwt/user/client/ui/FileUpload.java Index:

[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1614808)

LGTM2! Reposting at http://gwt-code-reviews.appspot.com/1727805 http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] MenuItem should use ScheduledCommand instead of Command (issue1732803)

Reviewers: rdayal, Description: MenuItem should use ScheduledCommand instead of Command Repost of 1698803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1732803/ Affected files: M tools/api-checker/config/gwt24_25userApi.conf M

[gwt-contrib] Rolling back, breaks other projects. (issue1733803)

Reviewers: rdayal, Description: Rolling back, breaks other projects. *** Original change description *** MenuItem should use ScheduledCommand instead of Command Repost of 1698803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1733803/ Affected files: M

[gwt-contrib] Re: Rolling back, breaks other projects. (issue1733803)

Submitting TBR http://gwt-code-reviews.appspot.com/1733803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1614808)

Submitted as r11023 http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1727805)

Submitted as r11023 http://gwt-code-reviews.appspot.com/1727805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix !important css typo (issue1725806)

Reviewers: rdayal, Description: Fix !important css typo Repost of 1585805. Thanks Stephen! Please review this at http://gwt-code-reviews.appspot.com/1725806/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js Index:

[gwt-contrib] Re: Fix !important css typo (issue1585805)

LGTM. Reposting at http://gwt-code-reviews.appspot.com/1725806 http://gwt-code-reviews.appspot.com/1585805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix !important css typo (issue1585805)

Submitted as r11025 http://gwt-code-reviews.appspot.com/1585805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix !important css typo (issue1725806)

Submitted as r11025 http://gwt-code-reviews.appspot.com/1725806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix showcase lastNameColumn/ageColumn typo (issue1728804)

Reviewers: rdayal, Description: Fix showcase lastNameColumn/ageColumn typo Repost of 1602803. Thanks Stephen! Please review this at http://gwt-code-reviews.appspot.com/1728804/ Affected files: M samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java

[gwt-contrib] Fix showcase lastNameColumn/ageColumn typo (issue1602803)

LGTM. Reposting at http://gwt-code-reviews.appspot.com/1728804 http://gwt-code-reviews.appspot.com/1602803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix showcase lastNameColumn/ageColumn typo (issue1602803)

Submitted as r11026 http://gwt-code-reviews.appspot.com/1602803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix showcase lastNameColumn/ageColumn typo (issue1728804)

Submitted as r11026 http://gwt-code-reviews.appspot.com/1728804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

On 2012/06/05 01:09:12, Patrick Tucker wrote: Is this acceptable, or should I modify the patch? I think the change in this patch is good. What is needed is for this patch to also modify tools/api-checker/config/gwt24_25userApi.conf to allow the API change.

[gwt-contrib] VerticalSplitPanel should not use DeferredCommand (issue1730803)

Reviewers: rdayal, Description: VerticalSplitPanel should not use DeferredCommand Repost of issue 1725803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1730803/ Affected files: M user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java Index:

[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1725803)

LGTM. Reposting at http://gwt-code-reviews.appspot.com/1730803 http://gwt-code-reviews.appspot.com/1725803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1730803)

Submitted as r11013 http://gwt-code-reviews.appspot.com/1730803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: VerticalSplitPanel should not use DeferredCommand (issue1725803)

Submitted as r11013 http://gwt-code-reviews.appspot.com/1725803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] WindowImplIE should use ScheduledCommand instead of Command (issue1725805)

Reviewers: rdayal, Description: WindowImplIE should use ScheduledCommand instead of Command Repost of 1697803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1725805/ Affected files: M user/src/com/google/gwt/user/client/impl/WindowImplIE.java Index:

[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1697803)

LGTM Repost at http://gwt-code-reviews.appspot.com/1725805 http://gwt-code-reviews.appspot.com/1697803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1697803)

Submitted as r11014 http://gwt-code-reviews.appspot.com/1697803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WindowImplIE should use ScheduledCommand instead of Command (issue1725805)

Submitted as r11014 http://gwt-code-reviews.appspot.com/1725805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add clear support to Style (issue1731803)

Reviewers: rdayal, Description: Add clear support to Style Repost of 1720803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1731803/ Affected files: M user/src/com/google/gwt/dom/client/Style.java M user/src/com/google/gwt/safecss/shared/SafeStylesBuilder.java

[gwt-contrib] Re: Add clear support to Style (issue1720803)

Submitted as r11015 http://gwt-code-reviews.appspot.com/1720803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add clear support to Style (issue1731803)

Submitted as r11015 http://gwt-code-reviews.appspot.com/1731803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Checkstyle fixes (issue1565806)

http://gwt-code-reviews.appspot.com/1565806/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right):

[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)

http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java File user/src/com/google/gwt/resources/client/ExternalTextResource.java (right):

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

com.google.gwt.core.client.Scheduler.ScheduledCommand [java] API compatibility check FAILED BUILD FAILED /usr/local/google/users/rchandia/src/gwt-trunk_Piper/google3/third_party/java_src/gwt/svn/trunk/build.xml:189: Java returned: 1 http://gwt-code-reviews.appspot.com/1698803/ -- http://groups.google.com

[gwt-contrib] RenderablePanel should use ScheduledCommand instead of Command (issue1728803)

Reviewers: rdayal, Description: RenderablePanel should use ScheduledCommand instead of Command Resubmission of issue 1693804 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1728803/ Affected files: M user/src/com/google/gwt/user/client/ui/RenderablePanel.java

[gwt-contrib] Re: RenderablePanel should use ScheduledCommand instead of Command (issue1693804)

LGTM Reposting as http://gwt-code-reviews.appspot.com/1728803 http://gwt-code-reviews.appspot.com/1693804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RenderablePanel should use ScheduledCommand instead of Command (issue1693804)

Submitted as r11010. http://gwt-code-reviews.appspot.com/1693804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] PopupImplMozilla should not use DeferredCommand (issue1729803)

Reviewers: rdayal, Description: PopupImplMozilla should not use DeferredCommand Repost of issue 1696803. Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1729803/ Affected files: M user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java Index:

[gwt-contrib] Re: PopupImplMozilla should not use DeferredCommand (issue1696803)

LGTM Reposting at http://gwt-code-reviews.appspot.com/1729803 http://gwt-code-reviews.appspot.com/1696803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: PopupImplMozilla should not use DeferredCommand (issue1696803)

Submitted as r11011 http://gwt-code-reviews.appspot.com/1696803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: PopupImplMozilla should not use DeferredCommand (issue1729803)

Submitted as r11011 http://gwt-code-reviews.appspot.com/1729803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] JsonpRequest should not use DeferredCommand (issue1725804)

Reviewers: rdayal, Description: JsonpRequest should not use DeferredCommand Repost of 1694804 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1725804/ Affected files: M user/src/com/google/gwt/jsonp/client/JsonpRequest.java Index:

[gwt-contrib] Re: JsonpRequest should not use DeferredCommand (issue1694804)

LGTM Reposting at http://gwt-code-reviews.appspot.com/1725804 http://gwt-code-reviews.appspot.com/1694804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: JsonpRequest should not use DeferredCommand (issue1694804)

Submitted as r11012 http://gwt-code-reviews.appspot.com/1694804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: JsonpRequest should not use DeferredCommand (issue1725804)

Submitted as r11012 http://gwt-code-reviews.appspot.com/1725804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] DEFAULT_FAST_FORWARD_ROWS should be final (issue1724803)

Reviewers: rdayal, Description: DEFAULT_FAST_FORWARD_ROWS should be final Add constructor SimplePager(TextLocation, boolean, boolean) Resubmitting issue 1692803 Thanks Patrick! Please review this at http://gwt-code-reviews.appspot.com/1724803/ Affected files: M

[gwt-contrib] Re: DEFAULT_FAST_FORWARD_ROWS should be final (issue1724803)

Submitted as r11007 http://gwt-code-reviews.appspot.com/1724803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

http://gwt-code-reviews.appspot.com/1700803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added style getters to UiRenderers (issue1700803)

http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):

[gwt-contrib] Re: DateBox should use ScheduledCommand instead of Command (issue1719803)

Submitted as r11005 http://gwt-code-reviews.appspot.com/1719803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

  1   2   3   4   5   6   >