[gwt-contrib] Enhancing GWT's CheckBox and RadioButton with bidi support. (issue1352809)

Reviewers: jlabanca, Description: Enhancing GWT's CheckBox and RadioButton with bidi support. Please review this at http://gwt-code-reviews.appspot.com/1352809/show Affected files: M user/src/com/google/gwt/user/client/ui/CheckBox.java M

[gwt-contrib] Make ListBox's bidi support more robust, allowing subclasses to create option elements without g... (issue1357806)

Reviewers: jlabanca, Description: Make ListBox's bidi support more robust, allowing subclasses to create option elements without going through ListBox. Such subclasses are currently broken by ListBox bidi support's use of an array, itemTexts, that is assumed to be synchronized with the select's

[gwt-contrib] A new wrapper to BidiFormatter whose methods return SafeHtml instead of String (issue1234801)

Reviewers: jlabanca, Description: A new wrapper to BidiFormatter whose methods return SafeHtml instead of String Please review this at http://gwt-code-reviews.appspot.com/1234801/show Affected files: M user/src/com/google/gwt/i18n/shared/BidiFormatter.java A

[gwt-contrib] Bidi support for ListBox (issue1137801)

Reviewers: jat, jlabanca, Description: Bidi support for ListBox Review by: aha...@google.com Please review this at http://gwt-code-reviews.appspot.com/1137801/show Affected files: M user/src/com/google/gwt/user/client/ui/ListBox.java M

[gwt-contrib] Introducing DirectionalTextHelper, a new helper class for text and direction manipulations in wi... (issue901801)

Reviewers: jat, jlabanca, Description: Introducing DirectionalTextHelper, a new helper class for text and direction manipulations in widgets, and using it to enhance Anchor and Hyperlink with bidi support. Please review this at http://gwt-code-reviews.appspot.com/901801/show Affected files:

[gwt-contrib] Setting ValueBox to be LTR by default, and disabling direction estimation for it. Adding some do... (issue811801)

Reviewers: jat, jlabanca, Description: Setting ValueBox to be LTR by default, and disabling direction estimation for it. Adding some documentation in TextArea and TextBox. Please review this at http://gwt-code-reviews.appspot.com/811801/show Affected files: M

[gwt-contrib] Adds integral BiDi support to Label.java and its descendants. Introduces a new interface, HasAut... (issue642803)

Reviewers: jat, jlabanca, Description: Adds integral BiDi support to Label.java and its descendants. Introduces a new interface, HasAutoHorizontalAlignment. Please review this at http://gwt-code-reviews.appspot.com/642803/show Affected files: M

[gwt-contrib] Re: Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

Done, thanks for the review. http://gwt-code-reviews.appspot.com/338801/diff/23001/24002 File user/src/com/google/gwt/i18n/shared/DirectionEstimator.java (right): http://gwt-code-reviews.appspot.com/338801/diff/23001/24002#newcode28

[gwt-contrib] Intruducing AutoDirHandler, a handler for automatically adjusting the direction of an object (ty... (issue386803)

Reviewers: jat, Description: Intruducing AutoDirHandler, a handler for automatically adjusting the direction of an object (typically a TextBox variant) while text is being entered. This handler is then used to add BiDi support to TextBox and TextArea. Please review this at

[gwt-contrib] Re: Intruducing AutoDirHandler, a handler for automatically adjusting the direction of an object (ty... (issue386803)

BidiPolicy was designed according to the standard deferred-binding design (see Debug.gwt.xml, DebugInfo.java). However, it was suggested to have a BidiPolicy.Algorithm interface such that both BidiPolicyImpl and BidiPolicyImplOn will implement BidiPolicy.Algorithm. Then we will have: private

[gwt-contrib] Re: Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

smoke test passes, and yes, I''m also running Checkstyle. http://gwt-code-reviews.appspot.com/338801/diff/1/9 File user/test/com/google/gwt/i18n/shared/AnyRtlDirectionEstimatorTest.java (right): http://gwt-code-reviews.appspot.com/338801/diff/1/9#newcode25

[gwt-contrib] Re: Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

http://gwt-code-reviews.appspot.com/338801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

Reviewers: jat, Description: Direction estimators are simple classes which estimate a string's direction using various heuristics. This is useful for automatically setting the direction of an element that contains text. Please review this at http://gwt-code-reviews.appspot.com/338801/show

[gwt-contrib] Re: Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

http://gwt-code-reviews.appspot.com/338801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Direction estimators are simple classes which estimate a string's direction using various heuris... (issue338801)

Different estimation heuristics may be needed for different use cases. For example, for a short input box where the direction behavior should be clear, the first-strong heuristic is generally preferable (it is used, for example, in Google.co.il). For long paragraphs the word-count is better since

[gwt-contrib] Two BiDi support classes

Reviewers: , Description: BidiUtils - utility functions for performing common BiDi tests on strings, such as direction estimation. BidiFormatter - utility class for formatting text for display in a potentially opposite-direction context without garbling. Please review this at

[gwt-contrib] Re: TextBoxBase to implement HasDirection instead of its children

I want TextBoxBase to implement HasDirection, which means moving the implementation of setDirection and getDirection from TextBox / TextArea to TextBoxBase. On 2 פברואר, 23:00, Ray Ryan rj...@google.com wrote: Extending TextBoxBase sounds perfectly reasonable, but what exactly are you proposing