Hey Rajeev,
Would you review this patch for PopupPanel? It's a cleaned up version
of what we did yesterday. This fixes the odd behavior we noticed where
Popup Panels could not be placed near the right edge of the screen on
IE, and normalizes popups in RTL and LTR modes, so they can't be
dragged
[fix bad GWTC address]
Please review the attached patch for trunk, which fixes a hosted mode crash
with a large set of serializable types.
On Linux hosted mode, a very large list of serializable types can cause a
crash inside Mozilla. This appears to be related to the size of the JSNI
function
Mostly LGTM. The only (marginally) substantive complaint is that it may
make sense to rework the property parsing around lines 285-293 so that it's
done once, statically, rather than re-parsing the String-int conversion for
every TypeSerializer we create, especially if (as I suggest as a nit) you
On Tue, Sep 30, 2008 at 4:27 PM, John Tamplin [EMAIL PROTECTED] wrote:
On Tue, Sep 30, 2008 at 3:49 PM, Freeland Abbott
[EMAIL PROTECTED] wrote:
Mostly LGTM. The only (marginally) substantive complaint is that it may
make sense to rework the property parsing around lines 285-293 so that
On Tue, Sep 30, 2008 at 4:51 PM, Freeland Abbott [EMAIL PROTECTED]
wrote:
But, again, it's a nit: my way saves at most ~10b of code size and could
gain or lose a few miliseconds in execution time depending on whether branch
prediction in the JVM is so far below bytecode interpretation that
Thanks Scott - I'm glad you were following the thread!
On Sat, Sep 27, 2008 at 2:20 AM, Scott Blum [EMAIL PROTECTED] wrote:
On Fri, Sep 26, 2008 at 11:37 AM, Eric Ayers [EMAIL PROTECTED] wrote:
(arg2 == null ? false : arg2)
Use the !! coerce-to-boolean idiom instead.
--
Eric Z.
Something like this?
protected void refreshAll() {
getDatePicker().refresh();
}
Yep, and baring unexpected events, all the changes should be committed into
incubator trunk tomorrow. Thanks for your help in pounding on it!
On Mon, Sep 29, 2008 at 5:18 PM, Isaac Truett [EMAIL
LGTM
On Tue, Sep 30, 2008 at 5:26 PM, John Tamplin [EMAIL PROTECTED] wrote:
On Tue, Sep 30, 2008 at 4:51 PM, Freeland Abbott
[EMAIL PROTECTED] wrote:
But, again, it's a nit: my way saves at most ~10b of code size and could
gain or lose a few miliseconds in execution time depending on
