[gwt-contrib] Re: RR: SOYC Correlation work

2008-10-03 Thread BobV
On Thu, Oct 2, 2008 at 4:56 PM, Lex Spoon [EMAIL PROTECTED] wrote: 1. Is there any reason to store all correlates as strings? The I agree that the final API provided by the Correlation type should be more structured than just a String, but I don't think that it should hang on to the AST

[gwt-contrib] RR: making extracting and setting widget data easier

2008-10-03 Thread Arthur Kalmenson
Hello every, Just a little backgrounder for this RR. For some time now, a coworker and I have been working on and off on a library/framework to simplify creation of GWT applications, specifically those that cover most of our use cases. For the most part, the applications we build involve filling

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Isaac Truett
Why wrappers? Why not have the widgets simply implement a HasData interface? public interface HasDataT { public T getData(); public void setData(T data); } Maybe I'm just not seeing your use case. On Fri, Oct 3, 2008 at 10:55 AM, Arthur Kalmenson [EMAIL PROTECTED] wrote:

[gwt-contrib] [google-web-toolkit commit] r3705 - changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl

2008-10-03 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 3 08:31:38 2008 New Revision: 3705 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java Log: Renames

[gwt-contrib] [google-web-toolkit commit] r3706 - changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl

2008-10-03 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 3 08:32:40 2008 New Revision: 3706 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java Log: Sort and

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Ian Petersen
On Fri, Oct 3, 2008 at 12:07 PM, Ray Ryan [EMAIL PROTECTED] wrote: I'm with Isaac. I think the case for teaching our Widgets to implement HasDataT is really clear cut (especially if they also accept DataChange listeners). The DataManager is a bit harder to justify, and anyway trivial for

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Ray Ryan
I think you're reading too much into the word data. All I'm after is a uniform way to find out what value a widget is showing, without my controller having to know specifically what widget it is. I think that can be done in a minimalist, low level way that doesn't conflict with various data

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Emily Crutcher
I was thinking of a slightly more complex use case where you might have full model objects. public class ListBoxModel implements HasValueListItem{ ... } public class ListBoxDataManager implements DataManagerListBox, ListBoxModel{ ... } public class MyListBox extends Composite implements

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Isaac Truett
I agree with Ian about the benefits of having data binding libraries independent of the GWT widget library. I'm not trying to push my own data binding scheme. My proposal of a HasData interface was to address this point from Arthur's original post: Right now, extracting data from widgets is

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Ian Petersen
Isaac has also replied while I'm writing this. I now see that Isaac's and Ray's suggestions are not as all-encompassing as I originally interpreted them. I'm just stepping out for lunch now, though, so I don't really have time to think about this properly or reply with the thoughtfulness that's

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Isaac Truett
Perhaps. What would ListBox implement? HasDataString or HasDataListString (ie. do we assume single-select or multi-select)? /** * Gets the currently-selected item. If multiple items are selected, this * method will return the first selected item ([EMAIL PROTECTED]

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Emily Crutcher
I think this basic idea makes sense, though I might argue that we might want to create a DropDownListBox and a MultiSelectListBox and deprecate list box, as the API for ListBox is hard to normalize this way. However, at the same time, a more complex data binding API seems like it could be very

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Arthur Kalmenson
If you buy my argument that HasDataT needs to imply SourcesDataChangeEventsT, then I think it follows that Label should not implement HasDataT. Something like HasReadOnlyDataT (like Emily suggested) would be necessary to bridge the gap between editors and viewers. I agree 100%, the hasText

[gwt-contrib] Re: RR: making extracting and setting widget data easier

2008-10-03 Thread Ian Petersen
On Fri, Oct 3, 2008 at 1:09 PM, Isaac Truett [EMAIL PROTECTED] wrote: Would Label implement HasDataString? Yes. HasDataString would essentially replace HasText, wouldn't it? (As an aside, if HasDataString replaces HasText, perhaps HasText should be redefined to extend HasDataString.) Ray

[gwt-contrib] [google-web-toolkit commit] r3704 - trunk/user/src/com/google/gwt/dom/client

2008-10-03 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 3 06:51:42 2008 New Revision: 3704 Modified: trunk/user/src/com/google/gwt/dom/client/DOMImplMozillaOld.java Log: Using fall back text content for old Mozilla. Desk check by jgw. Modified:

[gwt-contrib] Re: data binding framework for GWT

2008-10-03 Thread Ian Petersen
On Fri, Oct 3, 2008 at 5:12 PM, Ian Petersen [EMAIL PROTECTED] wrote: I just realized I should work up an example project that uses the library. I'll get to that and post it shortly. I've started a pretty thorough example, but the office is closing and I don't have a key so I have leave now.

[gwt-contrib] [google-web-toolkit commit] r3708 - trunk/dev/core/src/com/google/gwt/dev/jdt

2008-10-03 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 3 17:26:30 2008 New Revision: 3708 Modified: trunk/dev/core/src/com/google/gwt/dev/jdt/WebModeCompilerFrontEnd.java Log: This is a better way to find the appropriate no arg constructor; in some circumstances the original code would erroneously

[gwt-contrib] Re: Patch: Build File Fix

2008-10-03 Thread Freeland Abbott
The format for gwt.svnrev is [EMAIL PROTECTED], and if a real answer can't be determined it's set to [EMAIL PROTECTED], so I'd rather keep that pattern consistent instead of the 0 here. As a bigger change, though, I'd actually suggest pushing the test for .svn into SvnInfo.java; that already