[gwt-contrib] Re: Code Review: visualization Adds launch scripts to the HelloVisualization demo

2008-10-21 Thread Uwe Maurer
Hi Eric, thanks for adding the launch scripts! LGTM Uwe On Mon, Oct 20, 2008 at 8:23 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Uwe, Attached is a patch that adds launch scripts to the HelloVisualization sample. You have to build the project with 'ant', then the launch scripts get

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-21 Thread Cameron Braid
Are there any design docs for runAsync ? Cheers Cameron On Sat, Oct 18, 2008 at 2:24 AM, Lex Spoon [EMAIL PROTECTED] wrote: Hi, Bob, Can you be the main reviewer for the merge of the runAsync branch to the trunk? The attached patch is the outstanding difference between trunk and branch,

[gwt-contrib] [google-web-toolkit commit] r3789 - branches/1_6_events/samples/hello/src/com/google/gwt/sample/hello/client

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 07:20:02 2008 New Revision: 3789 Modified: branches/1_6_events/samples/hello/src/com/google/gwt/sample/hello/client/Hello.java Log: Fixing bad variable name. Modified:

[gwt-contrib] [google-web-toolkit commit] r3792 - branches/1_6_events/user/src/com/google/gwt/user/client/ui

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 07:28:09 2008 New Revision: 3792 Modified: branches/1_6_events/user/src/com/google/gwt/user/client/ui/Composite.java branches/1_6_events/user/src/com/google/gwt/user/client/ui/Widget.java Log: Added delayed sinking of dom events to widgets.

[gwt-contrib] [google-web-toolkit commit] r3790 - in branches/1_6_events/user/src/com/google/gwt/event: dom/client shared

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 07:22:38 2008 New Revision: 3790 Removed: branches/1_6_events/user/src/com/google/gwt/event/shared/HandlerAdaptor.java Modified: branches/1_6_events/user/src/com/google/gwt/event/dom/client/HasAllFocusHandlers.java

[gwt-contrib] [google-web-toolkit commit] r3796 - branches/1_6_events/user/src/com/google/gwt/user/client/ui

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 07:42:53 2008 New Revision: 3796 Modified: branches/1_6_events/user/src/com/google/gwt/user/client/ui/Composite.java Log: Fixing checkstyle error on composite. Modified: branches/1_6_events/user/src/com/google/gwt/user/client/ui/Composite.java

[gwt-contrib] Re: data binding framework for GWT

2008-10-21 Thread Ian Petersen
On Tue, Oct 21, 2008 at 9:07 AM, Arthur Kalmenson [EMAIL PROTECTED] wrote: I think requiring the HasData interface isn't a bad thing, but this might frustrate developers in the short term as standard GWT widgets don't implement the HasData interface. I don't expect to require HasData, I just

[gwt-contrib] Re: GWT branches\oophm fails with IndexOutOfBoundsException when reloading application

2008-10-21 Thread John Tamplin
On Tue, Oct 21, 2008 at 7:36 AM, gslender [EMAIL PROTECTED] wrote: john - should I raise an issue in the gwt code project? Sure. I will take a look at it later today. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~

[gwt-contrib] [google-web-toolkit commit] r3798 - branches/1_6_events/user/src/com/google/gwt/user/client/ui

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 08:55:02 2008 New Revision: 3798 Modified: branches/1_6_events/user/src/com/google/gwt/user/client/ui/Anchor.java Log: Adding overrides to anchor to avoid bogus warnings. Modified:

[gwt-contrib] [google-web-toolkit commit] r3800 - branches/1_6_events/samples/dynatable/src/com/google/gwt/sample/dynat able/client

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 09:09:19 2008 New Revision: 3800 Modified: branches/1_6_events/samples/dynatable/src/com/google/gwt/sample/dynatable/client/DayFilterWidget.java

[gwt-contrib] [google-web-toolkit commit] r3801 - changes/bobv/soyc-reports-r3772

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 09:55:02 2008 New Revision: 3801 Added: changes/bobv/soyc-reports-r3772/ - copied from r3772, /trunk/ Log: Create a change branch to checkpoint SOYC report API and XML format. --~--~-~--~~~---~--~~

[gwt-contrib] [google-web-toolkit commit] r3803 - in branches/1_6_events/user/javadoc/com: example/foo/client google/gwt/examples google/gw...

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 10:34:15 2008 New Revision: 3803 Modified: branches/1_6_events/user/javadoc/com/example/foo/client/FooTest.java branches/1_6_events/user/javadoc/com/google/gwt/examples/AsyncJUnitExample.java

[gwt-contrib] [google-web-toolkit commit] r3804 - branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/c lient/defaultmuseum

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 10:53:48 2008 New Revision: 3804 Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue1897.java

[gwt-contrib] [google-web-toolkit commit] r3805 - branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/c lient/viewer

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 10:56:41 2008 New Revision: 3805 Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/viewer/Museum.java Log: Replaced listeners with handlers in the Museum in code-museum. Patch by: jlabanca Modified:

[gwt-contrib] [google-web-toolkit commit] r3806 - branches/1_6_events/user/src/com/google/gwt/user/client/ui

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 11:27:07 2008 New Revision: 3806 Modified: branches/1_6_events/user/src/com/google/gwt/user/client/ui/ListBox.java branches/1_6_events/user/src/com/google/gwt/user/client/ui/PopupPanel.java Log: Replaced JavaDoc references to listeners with

[gwt-contrib] Re: Code Review: gwt-google-apis Maps issue 156 - exception when closing infowindow - take 2

2008-10-21 Thread Joel Webber
LGTM. Minor nit: InfoWindow.attachContentWidgets() takes a source argument that appears to be debugging leftovers. Just wanted to make sure you intended to leave this in. On Mon, Oct 13, 2008 at 11:12 AM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Joel, I would like for you to review the

[gwt-contrib] code review requested, TypeSerializerCreator bug introduced in cleaning up sharding changes

2008-10-21 Thread John Tamplin
Please review the following patch, relative to trunk r3728, which fixes a bug that slipped through when I cleaned up the methodMap sharding in TypeSerializerCreator to commit to trunk. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~

[gwt-contrib] Re: code review requested, TypeSerializerCreator bug introduced in cleaning up sharding changes

2008-10-21 Thread Freeland Abbott
LGTM. On Tue, Oct 21, 2008 at 4:31 PM, John Tamplin [EMAIL PROTECTED] wrote: Please review the following patch, relative to trunk r3728, which fixes a bug that slipped through when I cleaned up the methodMap sharding in TypeSerializerCreator to commit to trunk. -- John A. Tamplin

[gwt-contrib] [google-web-toolkit commit] r3808 - trunk/user/src/com/google/gwt/user/rebind/rpc

2008-10-21 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Oct 21 14:17:41 2008 New Revision: 3808 Modified: trunk/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java Log: Fix incorrect variable introduced in cleaning up sharding of methodMap creation in TypeSerialization. Patch by: jat Review

[gwt-contrib] code review requested, i18n lookup for nested classes

2008-10-21 Thread John Tamplin
Please review this patch, relative to trunk at r3808. Consider the following: public interface A extends Messages { public interface B extends Messages { @DefaultMessage(foo) String foo(); } } Currently, the translations for the foo method are looked up in files named

[gwt-contrib] Re: code review requested, i18n lookup for nested classes

2008-10-21 Thread Ian Petersen
On Tue, Oct 21, 2008 at 6:21 PM, John Tamplin [EMAIL PROTECTED] wrote: Currently, the translations for the foo method are looked up in files named A$B_locale.properties. The problem is that some build tools don't like filenames with $ in them, and while you might be able to work around it

[gwt-contrib] Re: Very Strange Compiler Bug: Works in JDK1.5, fails in 1.6

2008-10-21 Thread Scott Blum
Ray, any chance you're running out of memory? For reasons that aren't entirely clear to me, if you try to load a class but haven't got the memory to do so, you'll get a NoClassDefFound instead of OOM. I think this is fixed in 1.6 by always allowing OOMs to propagate instead of trying to wrap