[google-web-toolkit] EmilyCrutcher commented on revision r3979.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=3979
General Comment:
This has been true for statics in the past. However, it may/may not apply
to instance variables.
Respond to these comments at
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 07:02:34 2008
New Revision: 3995
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
Log:
Adding onBeforeFire event to handler manager and making the fire event
final.
Modified:
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 08:22:50 2008
New Revision: 3997
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
Log:
Fixing -port auto for JettyLauncher.
Found by: rdayal
Modified:
On Nov 10, 3:36 pm, [EMAIL PROTECTED] wrote:
I added some code to have a callback from GWT to javascript, to make
sure the GWT visualization is loaded before using it.
I am wondering what is the preferred way to make sure a GWT
application is loaded before some other javascript (non GWT) in
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 11:44:43 2008
New Revision: 4001
Removed:
branches/1_6_clean_events/user/test/com/google/gwt/user/client/ui/DomEventBenchmark.java
branches/1_6_clean_events/user/test/com/google/gwt/user/client/ui/DomHandlerBenchmark.java
Log:
Removed
Deleted the two dom handler benchmarks causing 1.5 javac errors. Added
separate tracker item to figure out why. In the meantime, deleting them so
we can continue to compile using ant 1.5.
--
There are only 10 types of people in the world: Those who understand
binary, and those who don't
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 12:42:53 2008
New Revision: 4002
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/logical/shared/HasHandlers.java
Log:
Fix HasHandlers#getHandler javadoc--may return null
Modified:
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 12:57:12 2008
New Revision: 4003
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
Log:
Removing onBeforeFire, adding comments, and converting enqueueRemove to
private.
Modified:
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:23:10 2008
New Revision: 4004
Added:
releases/1.6/user/src/com/google/gwt/user/tools/RpcAsyncClientTemplate.javasrc
releases/1.6/user/src/com/google/gwt/user/tools/RpcClientTemplate.javasrc
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:31:09 2008
New Revision: 4005
Modified:
releases/1.6/eclipse/samples/DynaTable2/build.xml
Log:
Updates DynaTable2 build file as per the recent updates to support a WAR
structure.
Patch by: amitmanjhi
Review by: scottb
Modified:
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 14:47:35 2008
New Revision: 4006
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JsHandlerRegistry.java
Log:
Docs explaining
On Sat, Nov 8, 2008 at 10:41 AM, Toby Reyelts [EMAIL PROTECTED] wrote:
Are there not larger issues here that need to also be resolved? For
example, don't generators need to be able to generate server code? I'm also
confused as to what really separates generators and linkers in terms of
being
I have a linker for my Syndroid prototype which generates complete
Android applications. It does this by generating bootstrap code to
load up a WebKit container on Android, and load the GWT app into it.
This is one example where the linker generates executable code,
however it does preserve
On Mon, Nov 10, 2008 at 2:33 PM, Kelly Norton [EMAIL PROTECTED] wrote:
For iframe loading, Cameron's change is correct. We should be loading
code into the document corresponding to our code context and not the
host page context.
Can I consider that an LGTM?
However, I am wondering how this
Hi Scott,
Please review the attached change.
Regards,
Amit
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: user/src/com/google/gwt/user/tools/AppHtml.htmlsrc
On Mon, Nov 10, 2008 at 6:02 PM, Lex Spoon [EMAIL PROTECTED] wrote:
I think of generators as making content, and linkers as deciding where
that content should be located. Typically you can take the same
program and swap in different linkers if you like. The same is not
true of generators.
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 15:58:45 2008
New Revision: 4008
Modified:
releases/1.6/user/src/com/google/gwt/user/tools/AppHtml.htmlsrc
releases/1.6/user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc
Log:
Moves the CSS reference from the module file to the html file.
Yeah, I tested the patch. Commited as r4008. Thanks!
On Mon, Nov 10, 2008 at 6:47 PM, Scott Blum [EMAIL PROTECTED] wrote:
I'm assuming you did this correctly. :) Just commit it since we discussed
the semantics of the change.
2008/11/10 Amit Manjhi [EMAIL PROTECTED]
Hi Scott,
Please
I'm assuming you did this correctly. :) Just commit it since we discussed
the semantics of the change.
2008/11/10 Amit Manjhi [EMAIL PROTECTED]
Hi Scott,
Please review the attached change.
Regards,
Amit
--~--~-~--~~~---~--~~
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:02:39 2008
New Revision: 4009
Modified:
branches/1_6_clean_events/user/src/com/google/gwt/event/shared/JsHandlerRegistry.java
branches/1_6_clean_events/user/test/com/google/gwt/event/EventSuite.java
Log:
dead method snipped, whitespace
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:34:10 2008
New Revision: 4010
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/GWTHosted.java
releases/1.6/dev/core/src/com/google/gwt/dev/shell/ServletContainerLauncher.java
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:52:26 2008
New Revision: 4012
Added:
releases/1.6/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDir.java
(contents, props changed)
releases/1.6/dev/core/src/com/google/gwt/dev/util/arg/OptionWorkDir.java
(contents, props
Author: [EMAIL PROTECTED]
Date: Mon Nov 10 16:50:32 2008
New Revision: 4011
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/CompileArgProcessor.java
releases/1.6/dev/core/src/com/google/gwt/dev/CompileTaskOptions.java
(Reviving the old Response Requested meaning of RR--there is no patch here,
but rather a design question.)
Take a look at the new TabWrapper getTabWrapper(int index) method on TabBar
in the 1_6_clean_events branch:
John,
I wanted to run this one-liner by you before committing. I'm seeing
the JSE below in hosted mode when the body of my PagingScrollTable is
empty and has 0 height. The headerHeight is positive and (totalHeight
- headerHeight - footerHeight) comes out to a negative number. The
patch following
Heads up guys,
I just profiled my app trying to squeeze every last drop of
performance out for speedups on the iPhone which has slow Javascript,
and I noticed that the canCastUnsafe/dynamicCast functions are
collectively eating up 8.5% of the total runtime. It seems that the
sole purpose of
26 matches
Mail list logo
