[gwt-contrib] Re: getAbsoluteLeft/Top() returns incorrect value in IE when zoomed in

2008-12-09 Thread t . broyer
How about using the screen.deviceXDPI and related properties? See: - http://msdn.microsoft.com/en-us/library/cc849094(VS.85).aspx#DetectViaJava - http://msdn.microsoft.com/en-us/library/ms537625(VS.85).aspx - http://msdn.microsoft.com/en-us/library/ms533721(VS.85).aspx Something like

[gwt-contrib] Re: Why is Timer#schedule(0) bad?

2008-12-09 Thread Thomas Broyer
On 9 déc, 07:16, Kelly Norton [EMAIL PROTECTED] wrote: Chrome: 4ms (fairly recent change) Safari (mac): 10ms Safari (win): 15ms Firefox: 15ms (or 10ms if flash is running) IE: 15ms Opera: I have no clue. So, that's just a really long way of saying that there is no danger in allowing 0

[gwt-contrib] Re: getAbsoluteLeft/Top() returns incorrect value in IE when zoomed in

2008-12-09 Thread Thomas Broyer
On 8 déc, 21:58, [EMAIL PROTECTED] wrote: The DOCTYPE actually makes a difference.  The following DOCTYPE (default in AppHtml.htmlsrc) works fine: !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN However, adding the loose.dtd makes body.parentElement return the same size as

[gwt-contrib] Re: getAbsoluteLeft/Top() returns incorrect value in IE when zoomed in

2008-12-09 Thread Emily Crutcher
On Tue, Dec 9, 2008 at 12:42 AM, John LaBanca [EMAIL PROTECTED] wrote: Internet Explorer now works the same as Firefox. That is, with real zoom, absolute positions do not change even though the widget appears further from the left or top. I was going to put that info in the review request,

[gwt-contrib] Re: Tweaks to API checker

2008-12-09 Thread Emily Crutcher
Committed as 4274. On Mon, Dec 8, 2008 at 8:25 PM, Amit Manjhi [EMAIL PROTECTED] wrote: LGTM On Mon, Dec 8, 2008 at 6:40 PM, [EMAIL PROTECTED] wrote: Reviewers: amitmanjhi, Description: Amit, This patch changes the gwt build.xml file to use value rather then location when defining

[gwt-contrib] [google-web-toolkit commit] r4275 - in releases/1.6/user: src/com/google/gwt/user/client/ui test/com/google/gwt/user/client/ui

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 06:31:36 2008 New Revision: 4275 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/Tree.java releases/1.6/user/test/com/google/gwt/user/client/ui/TreeTest.java Log: Removing deprecated setImageBase method from tree. Modified:

[gwt-contrib] Re: getAbsoluteLeft/Top() returns incorrect value in IE when zoomed in

2008-12-09 Thread jlabanca
committed as r4276 $wnd.screen.deviceXDPI / $wnd.screen.logicalXDPI didn't seem to work (they returned the same value even when zoomed in). Reading through the MSDN docs, it looks deviceXDPI changes when you change your screen resolution, not when you zoom in.

[gwt-contrib] review: build.xml fix on my r4271

2008-12-09 Thread Freeland Abbott
Another patch-review for you, sorry: I'm actually a bit surprised that the prior built, which it did, but I just got a local build error complaining about tarfileset occurring inside a zip for the windows build... dangers of too much cut-n-paste. Patch in-line, as it's so short: Index:

[gwt-contrib] Fix for listenerwrapper, remove listener

2008-12-09 Thread ecc
Reviewers: jlabanca, Description: John, Could you review this fix for the assertion error that happens in some circumstances when you remove Window listeners? Also included are two new test cases to ensure we don't have a regression on this issue. As a side note, I think this situation is

[gwt-contrib] [google-web-toolkit commit] r4274 - in releases/1.6: . tools/api-checker/config

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 06:27:26 2008 New Revision: 4274 Modified: releases/1.6/build.xml releases/1.6/tools/api-checker/config/gwt15_16userApi.conf Log: Updating api-checker config. Modified: releases/1.6/build.xml

[gwt-contrib] [google-web-toolkit commit] r4278 - releases/1.6/eclipse

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 07:43:57 2008 New Revision: 4278 Modified: releases/1.6/eclipse/README.txt Log: Forgot to commit the updated eclipse/README.txt when I was removing references to projectCreator. Modified: releases/1.6/eclipse/README.txt

[gwt-contrib] [google-web-toolkit commit] r4279 - releases/1.6/user/test/com/google/gwt/user/client/ui

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 08:28:08 2008 New Revision: 4279 Modified: releases/1.6/user/test/com/google/gwt/user/client/ui/TreeTest.java Log: Removing test that should have been removed with last commit. TBA:jlabanca Modified:

[gwt-contrib] [google-web-toolkit commit] r4277 - releases/1.6/reference/code-museum/src/com/google/gwt/museum/public

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 07:24:19 2008 New Revision: 4277 Modified: releases/1.6/reference/code-museum/src/com/google/gwt/museum/public/SingleIssue.html Log: I accidentally changed the doc type of SingleIssue.html before submitting r4276. The doctype should have been

[gwt-contrib] [google-web-toolkit commit] r4276 - in releases/1.6: reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum ref...

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 07:17:36 2008 New Revision: 4276 Added: releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue3172.java Modified:

[gwt-contrib] Re: Fix for listenerwrapper, remove listener

2008-12-09 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/603 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r4280 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 10:14:21 2008 New Revision: 4280 Modified: wiki/WAR_Design_1_6.wiki Log: Removed the whole module-session idea due to it creating too many issues. Modified: wiki/WAR_Design_1_6.wiki

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-09 Thread Lex Spoon
On Fri, Dec 5, 2008 at 12:28 PM, BobV [EMAIL PROTECTED] wrote: - Several classes in user/test/.../server/rpc do not compile against Jetty given the difference in the servlet API in Jetty versus Tomcat. This is problematic when using an Eclipse project structure that isn't hamstrung by linked

[gwt-contrib] Comment on WAR_Design_1_6 in google-web-toolkit

2008-12-09 Thread codesite-noreply
Comment by danigb: great!! i really like this! For more information: http://code.google.com/p/google-web-toolkit/wiki/WAR_Design_1_6 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Comment on DesignOOPHM in google-web-toolkit

2008-12-09 Thread codesite-noreply
Comment by danigb: this looks amazing! go ahead! For more information: http://code.google.com/p/google-web-toolkit/wiki/DesignOOPHM --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Warning message in IE6 when using NamedFrame on SSL-secured web-site

2008-12-09 Thread jlabanca
Reviewers: ecc, Description: Description: The iframe created in a NamedFrame does not have a src, so it throws a mixed content warning in IE6 on an SSL-secured website. Fix: Setting the source to javascript:'' fixes the problem, and we've used the same trick on all other

[gwt-contrib] Re: Warning message in IE6 when using NamedFrame on SSL-secured web-site

2008-12-09 Thread jlabanca
The diff didn't go through for DefaultMuseum.java. Here is that part of the patch: Index: reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum.java === ---

[gwt-contrib] Re: Warning message in IE6 when using NamedFrame on SSL-secured web-site

2008-12-09 Thread John LaBanca
Frames are used to load external sites, so the src is likely an actual URL, whereas NamedFrames are used locally and in FormPanels. While NamedFrames can be used for external sites and vice versa, that isn't the default use case. Also, people can change the URL of a NamedFrame via setUrl(), and

[gwt-contrib] Re: Warning message in IE6 when using NamedFrame on SSL-secured web-site

2008-12-09 Thread Emily Crutcher
Why is this a problem for NamedFrames but not Frames? Other then that, LGTM. On Tue, Dec 9, 2008 at 3:10 PM, [EMAIL PROTECTED] wrote: Reviewers: ecc, Description: Description: The iframe created in a NamedFrame does not have a src, so it throws a mixed content warning in IE6

[gwt-contrib] [google-web-toolkit commit] r4284 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 12:58:53 2008 New Revision: 4284 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] [google-web-toolkit commit] r4286 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 13:04:40 2008 New Revision: 4286 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] RR: Adding api-checker to selected packages in gwt-incubator

2008-12-09 Thread Emily Crutcher
In gwt-incubator, we want to be able to tag widgets/libaries alpha/beta/releaseCandidate. However, this implies an extra level of support for releaseCandidate libraries/widgets. Specifically, between each incubator drop, if we had to break the API, which we will occasionally need to do, we want

[gwt-contrib] [google-web-toolkit commit] r4282 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 12:49:24 2008 New Revision: 4282 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] [google-web-toolkit commit] r4285 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 13:02:03 2008 New Revision: 4285 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] [google-web-toolkit commit] r4283 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 12:52:36 2008 New Revision: 4283 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] [google-web-toolkit commit] r4289 - wiki

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 13:13:01 2008 New Revision: 4289 Modified: wiki/GwtJavaApiCompatibilityChecker.wiki Log: Edited wiki page through web user interface. Modified: wiki/GwtJavaApiCompatibilityChecker.wiki

[gwt-contrib] Re: review: build.xml fix on my r4271

2008-12-09 Thread Amit Manjhi
LGTM. I had to make this change myself. (Apparently, this does not happen with ant 1.7+) On Tue, Dec 9, 2008 at 11:55 AM, Freeland Abbott [EMAIL PROTECTED] wrote: Another patch-review for you, sorry: I'm actually a bit surprised that the prior built, which it did, but I just got a local

[gwt-contrib] TabBar setTabText doesn't set word wrap false

2008-12-09 Thread jlabanca
Reviewers: ecc, Description: Description: TabBar.insertTab(text) adds a Label with wordWrap set to false. TabBar.setTabText(text) adds a Label without setting wordWrap (defaults to true). Also, there is no way to change wordWrap programatically on a tab. Fix:

[gwt-contrib] Allowing collapsible panel to have collapsed state programically controled

2008-12-09 Thread ecc
Reviewers: jlabanca, Description: Allows collapsible panel to have it state controlled via code. Please review this at http://gwt-code-reviews.appspot.com/809 Affected files: src-demo/com/google/gwt/widgetideas/demo/collapsiblepanel/client/CollapsiblePanelDemo.java

[gwt-contrib] Re: TabBar setTabText doesn't set word wrap false

2008-12-09 Thread ecc
The expansion of the tab interface looks great. Don't quite understand the change to the default word wrapping... http://gwt-code-reviews.appspot.com/604/diff/1/2 File user/src/com/google/gwt/user/client/ui/TabBar.java (right): http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488 Line

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-09 Thread Scott Blum
Yes, we need to implement this method in our implementations, but then not actually call the method anywhere ourselves. On Tue, Dec 9, 2008 at 1:33 PM, Lex Spoon [EMAIL PROTECTED] wrote: On Fri, Dec 5, 2008 at 12:28 PM, BobV [EMAIL PROTECTED] wrote: - Several classes in

[gwt-contrib] Re: TabBar setTabText doesn't set word wrap false

2008-12-09 Thread Emily Crutcher
Ah, I see, the normal add(String) already sets word-wrap to false. In that case LGTM. On Tue, Dec 9, 2008 at 6:05 PM, [EMAIL PROTECTED] wrote: insertTab(String text, boolean asHTML, int beforeIndex) already disabled wordWrap, and we want insertTab() and setTabText() to be consistent.

[gwt-contrib] Re: review: build.xml fix on my r4271

2008-12-09 Thread Freeland Abbott
Submitted; the ant dependency would explain why the builds succeeded On Tue, Dec 9, 2008 at 4:27 PM, Amit Manjhi [EMAIL PROTECTED] wrote: LGTM. I had to make this change myself. (Apparently, this does not happen with ant 1.7+) On Tue, Dec 9, 2008 at 11:55 AM, Freeland Abbott [EMAIL

[gwt-contrib] [google-web-toolkit commit] r4290 - releases/1.6/user/src/com/google/gwt/core/public

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 18:09:48 2008 New Revision: 4290 Removed: releases/1.6/user/src/com/google/gwt/core/public/ Log: Deleting history.html. Review by: jgw --~--~-~--~~~---~--~~

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-09 Thread John Tamplin
On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum [EMAIL PROTECTED] wrote: We deal with this problem now by asserting that hosted mode will generally not overwrite web mode artifacts unless they are newer. For the specific case of the selection script, we give the hosted mode generated selection

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-09 Thread Scott Blum
On Tue, Dec 9, 2008 at 9:48 PM, John Tamplin [EMAIL PROTECTED] wrote: On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum [EMAIL PROTECTED] wrote: We deal with this problem now by asserting that hosted mode will generally not overwrite web mode artifacts unless they are newer. For the specific case

[gwt-contrib] [google-web-toolkit commit] r4291 - releases/1.6/dev/core/src/com/google/gwt/dev

2008-12-09 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 9 18:22:07 2008 New Revision: 4291 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java Log: Type fix. Modified: releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java