On Thu, Dec 18, 2008 at 3:33 PM, Katharina Probst kpro...@google.com wrote:
Hi Lex,
LGTM, with the caveat that you may want to add more tests in the
future (e.g., for load order dependencies).
Thank you! This is committed at revision 4358.
I agree about the more tests
-Lex
Author: sp...@google.com
Date: Fri Dec 19 06:05:04 2008
New Revision: 4358
Added:
trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncTest.java
(contents, props changed)
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
John, as I just got a vacation message from Ray, could you finish the review
of this patch? The only unreviewed part is adding the abandon method as per
Ray's request.
Thanks!
Emily
http://gwt-code-reviews.appspot.com/1201
On Fri, Dec 19, 2008 at 1:20 AM, Emily Crutcher
22 or so, as long as you can rely just on the compile task, it's actually
not a problem. However, to be safe, we need to call build first, as we use
the gwt-incubator jar now to generate the demos. Calling gwt-incubator build
then does take some time. In my measurements, not having to call build
On Thu, Dec 18, 2008 at 9:09 PM, John Tamplin j...@google.com wrote:
On Thu, Dec 18, 2008 at 7:50 PM, Scott Blum sco...@google.com wrote:
How about this instead? I think it makes sense to tie the reordering to
construction of the Precompilation, because that's when it actually matters.
And
On Fri, Dec 19, 2008 at 1:37 PM, Scott Blum sco...@google.com wrote:
Sounds good to me. Want me to respin it, or you?
I can do it.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
LGTM, though I think you mean to add I18n to the single issue module. Also,
did you check how the samples looked now that you removed the spacing?
Thanks,
Emily
On Fri, Dec 19, 2008 at 1:18 PM, John LaBanca jlaba...@google.com wrote:
ping
Please review this when you
I'll double check the samples and I'll remove I18N from the
SingleIssue.gwt.xml file. Showcase looked fine, but I'll make sure the
others look good too.
Thanks,
John LaBanca
jlaba...@google.com
On Fri, Dec 19, 2008 at 2:11 PM, Emily Crutcher e...@google.com wrote:
LGTM, though I think you
Mike, I took a look and I think it's a good first pass, definitely a good
start!
I would actually be excited about a tad bit of refactoring to allow the
tests to be more surgical. I think a little bit of work on JJSCompiler
could eliminate the need for a rebind oracle entirely, and I think we'd
Author: sp...@google.com
Date: Fri Dec 19 13:52:34 2008
New Revision: 4361
Added:
tools/lib/eclipse/jdt-3.4.2-src.zip (contents, props changed)
tools/lib/eclipse/jdt-3.4.2.jar (contents, props changed)
tools/lib/eclipse/update-jdt.py (contents, props changed)
Log:
Adds jars
Author: e...@google.com
Date: Fri Dec 19 14:01:24 2008
New Revision: 4363
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForDateBox.java
releases/1.6/user/src/com/google/gwt/user/datepicker/client/DateBox.java
Author: j...@google.com
Date: Fri Dec 19 13:40:27 2008
New Revision: 4360
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/Permutation.java
releases/1.6/dev/core/src/com/google/gwt/dev/Precompilation.java
releases/1.6/dev/core/src/com/google/gwt/dev/Precompile.java
Log:
Fixup
Author: jlaba...@google.com
Date: Fri Dec 19 13:28:12 2008
New Revision: 4359
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForTree.java
13 matches
Mail list logo
