I'd definitely like to see the paging ability as an extension (read
that as you will: interface implementation, derived class, plug-in
behavior, whatever) to the scrolling behavior. I don't really like how
the incubator has two totally separate, unrelated classes.
I wonder if some performance
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty performance)? My intuition tells me that the only way we
could use it would be through a callback, because there's nothing like .NET
FWIW:
http://code.google.com/p/google-web-toolkit/wiki/BooleanIfExpressionOptimization
http://code.google.com/p/google-web-toolkit/wiki/IfToTernaryExpressionOptimization
Thanks again for banging on these. I've been meaning to do it for ages...
On Wed, Jun 10, 2009 at 9:11 PM,
w00t indeed. This just saved me serious time this morning already.
On Wed, Jun 10, 2009 at 6:35 PM, Scott Blum sco...@google.com wrote:
w00t!!
On Wed, Jun 10, 2009 at 5:47 PM, Freeland Abbott fabb...@google.comwrote:
As of r5537, my no-change ant build takes 1:55 instead of 19:43, and
Author: j...@google.com
Date: Thu Jun 11 06:24:20 2009
New Revision: 5538
Modified:
trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Fixes typo that confused __MODULE_NAME__ with __MODULE_FUNC__, leading to
startup failures in pre-1.6-hosted-mode.
Review:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty performance)? My intuition tells me that the only way we
could
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another depends-on-your-hardware-but-I-saw-4min-saving (for
work-to-do rebuild of samples, so no gain if you use buildonly) out to scott
already, though it's small enough that anyone who wants to review at
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can take
advantage of Javascript's for (x in y) { ... } syntax (and should we,
given its spotty
On Thu, Jun 11, 2009 at 3:42 PM, Thomas Broyer t.bro...@gmail.com wrote:
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can
take
advantage of
Nice job Freeland! You're an ant-master!
On Thu, Jun 11, 2009 at 10:40 AM, Freeland Abbott fabb...@google.comwrote:
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another depends-on-your-hardware-but-I-saw-4min-saving (for
work-to-do rebuild of samples, so no gain if
On Thu, Jun 11, 2009 at 10:42 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 11 juin, 16:11, John Tamplin j...@google.com wrote:
On Thu, Jun 11, 2009 at 7:51 AM, Joel Webber j...@google.com wrote:
+1 Ray. Now here's the really tricky question. Is there any way we can
take
advantage of
No problem... I haven't handled the common super-expression case (if
(test) { return a; } else {return b; } - return test ? a : b), but
that one should be pretty easy to tackle for a limited set of common
super-expressions.
On 11-Jun-09, at 5:53 AM, Joel Webber wrote:
FWIW:
Thanks... I think.
On Thu, Jun 11, 2009 at 11:53 AM, Rajeev Dayal rda...@google.com wrote:
Nice job Freeland! You're an ant-master!
On Thu, Jun 11, 2009 at 10:40 AM, Freeland Abbott fabb...@google.comwrote:
Well, if I've saved serious time by 10:30am, I'm happy indeed.
I've got another
Reviewers: scottb,
Description:
Shaves 10min off a dist-one build vs dist (aka old build).
Please review this at http://gwt-code-reviews.appspot.com/37803
Affected files:
build.xml
--~--~-~--~~~---~--~~
Thanks, Bob! I have several things to change; my plans are in the
line-by-line comments.
http://gwt-code-reviews.appspot.com/33848/diff/1/4
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
http://gwt-code-reviews.appspot.com/33848/diff/1/4#newcode107
Line
LGTM, we've been needing this for a while. :)
http://gwt-code-reviews.appspot.com/36802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/37803/diff/1/2
File build.xml (right):
http://gwt-code-reviews.appspot.com/37803/diff/1/2#newcode21
Line 21: target name=dist-one depends=buildonly, tools, samples,
doc description=Make this platform's distributions
Now would be a good opportunity to add
http://gwt-code-reviews.appspot.com/37803/diff/1/2
File build.xml (right):
http://gwt-code-reviews.appspot.com/37803/diff/1/2#newcode21
Line 21: target name=dist-one depends=buildonly, tools, samples,
doc description=Make this platform's distributions
On 2009/06/11 17:41:56, zundel wrote:
Now
Author: j...@google.com
Date: Thu Jun 11 11:36:32 2009
New Revision: 5539
Modified:
branches/snapshot-2009.06.02-r5498/branch-info.txt
branches/snapshot-2009.06.02-r5498/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Merge trunk 5538 to the 6/2 snapshot branch.
How about now? In addition to the requested changes, I changed two
other things:
1. The SOYC timings use PerfLogger now, rather than inlined timing code
2. There is a check for the same split point being specified multiple
times in the initial sequence
Author: sco...@google.com
Date: Thu Jun 11 12:08:45 2009
New Revision: 5540
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
trunk/dev/core/test/com/google/gwt/dev/js/JsStaticEvalTest.java
Log:
JsStaticEval now optimizes certain if statements to conditional
Reviewers: scottb,
Description:
In trunk, -draftCompile does one full outer loop of the optimization
loop. This patch pares that one loop down much further.
A one-permutation draft compile of Showcase now takes about 25 seconds,
as compared to 27 seconds before. Additionally, the actual
LGTM. Committed at r5540 with minor tweaks.
http://gwt-code-reviews.appspot.com/36801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Matt,
Could you review these two follow-on patches? The second depends on the
first. This is mostly non-functional cleanup to make things a little
simpler to read. The only substantive change is this:
Presently, if we have a CanBooleanEval that fails to resolve, we do nothing
else. My second
LGTM.
By the way, instant hosted mode should reduce CompilationState.compile
drastically, so help is on the way!
http://gwt-code-reviews.appspot.com/38801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Both LGTM. Good catch, thanks. :)
On 11-Jun-09, at 1:15 PM, Scott Blum wrote:
Matt,
Could you review these two follow-on patches? The second depends on
the first. This is mostly non-functional cleanup to make things a
little simpler to read. The only substantive change is this:
Author: sco...@google.com
Date: Thu Jun 11 13:01:10 2009
New Revision: 5541
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
Log:
Simple refactoring of SourceInfo generation in JsStaticEval.
Review by: mmastrac
Modified:
Author: sco...@google.com
Date: Thu Jun 11 13:01:57 2009
New Revision: 5542
Modified:
trunk/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
Log:
Refactor JsStaticEval to allow additional simplification when static eval
of the condition fails.
Review by: mmastrac
Modified:
Author: sp...@google.com
Date: Thu Jun 11 13:10:53 2009
New Revision: 5543
Modified:
wiki/CodeSplitting.wiki
Log:
Updated the instructions for running SoycDashboard
Modified: wiki/CodeSplitting.wiki
==
---
Author: fabb...@google.com
Date: Thu Jun 11 13:18:35 2009
New Revision: 5544
Modified:
trunk/samples/common.ant.xml
Log:
Giving samples a -localWorkers flag. You can configure it for your
hardware by defining the property gwt.samples.localworkers in
ROOT/local.ant.properties.
Review
Author: sp...@google.com
Date: Thu Jun 11 14:00:30 2009
New Revision: 5545
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Log:
Reduces the amount of compilation done
when -draftCompile is specified.
Review by: scottb
Modified:
Is the DockLayoutPanel presented at Google IO already in svn? The one
that is being used by the wave client?
I've not been able to find it...
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No, it's not checked in yet, but I think Joel might started a branch to land
it before t long.
It isn't literally the same code as in Wave, but it's logically equivalent.
Joel can say a lot more about it than me.
On Thu, Jun 11, 2009 at 5:36 PM, dflorey daniel.flo...@gmail.com wrote:
Is
LGTM. Good idea.
http://gwt-code-reviews.appspot.com/38802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: sco...@google.com
Date: Thu Jun 11 15:21:46 2009
New Revision: 5546
Added:
trunk/dev/core/src/com/google/gwt/dev/util/arg/OptionOptimizePrecompile.java
(contents, props changed)
Modified:
trunk/dev/core/src/com/google/gwt/dev/Compiler.java
Author: kpro...@google.com
Date: Thu Jun 11 17:50:39 2009
New Revision: 5547
Modified:
branches/crawlability/user/src/com/google/gwt/user/client/History.java
branches/crawlability/user/src/com/google/gwt/user/client/impl/HistoryImpl.java
Author: kpro...@google.com
Date: Thu Jun 11 17:53:23 2009
New Revision: 5548
Modified:
branches/crawlability/samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java
Log:
Modified Showcase for crawlabiliy (Note: draft that goes with previous
revision. Subject to change.)
37 matches
Mail list logo
