On Saturday, August 07, 2010 22:22:19 codesite-nore...@google.com wrote:
Revision: 8503
Author: rj...@google.com
Date: Sat Aug 7 16:11:36 2010
Log: Fix datatype renderers to handle nulls properly for some primitive
types. We now expect renderers to produce for null, and parsers to
return
Works great with both boolean and enumerations now
On Aug 6, 6:05 pm, Ray Cromwell cromwell...@gmail.com wrote:
I'm going to change it to treat undefined as null. In theory, I could change
RecordJsoImpl to initialize all property fields to null or a default value,
according to JLS semantics,
Reviewers: Ray Ryan,
Description:
Deprecate the DeferredCommand API.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/718802/show
Affected files:
M user/src/com/google/gwt/user/client/Command.java
D
http://gwt-code-reviews.appspot.com/718802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I find it extremely surprising that I can't use GWT with Chrome on my
mac.
I'm flabbergasted
Does anyone know if the Google devs are planning on producing one?
- Brill Pappin
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Mon, Aug 9, 2010 at 10:44 AM, Brill br...@pappin.ca wrote:
I find it extremely surprising that I can't use GWT with Chrome on my
mac.
I'm flabbergasted
Does anyone know if the Google devs are planning on producing one?
Reviewers: Dan Rice,
Description:
Fixing the msg key in ContactInfoForm so that the two buttons use
different keys.
Please review this at http://gwt-code-reviews.appspot.com/746801/show
Affected files:
M
I already have that. Do you want it in the same patch?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/735802/diff/1/10
File
user/test/com/google/gwt/validation/client/ValidationClientGwtSuite.java
(right):
http://gwt-code-reviews.appspot.com/735802/diff/1/10#newcode23
user/test/com/google/gwt/validation/client/ValidationClientGwtSuite.java:23:
* All
Revision: 8504
Author: r...@google.com
Date: Mon Aug 9 07:41:33 2010
Log: Refactor SelectionModel.SelectionEvent into its own class with
associated Handler
Review at http://gwt-code-reviews.appspot.com/698804
http://code.google.com/p/google-web-toolkit/source/detail?r=8504
Added:
Added callsite updates to the patch.
http://gwt-code-reviews.appspot.com/718802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Mostly LGTM. This looks like a nice cleanup and should remove a lot of
potential for lock contention. I like that a lot of the code gets a lot
simpler too. SerializabilityUtil.java is some particularly embarrassing
code that I helped write. This patch should allow that code to be
refactored
Revision: 8505
Author: ncha...@google.com
Date: Mon Aug 9 08:36:41 2010
Log: Public: Simple implementation of ConstraintViolation,
ConstraintDescriptor, Path and Node.
Review at http://gwt-code-reviews.appspot.com/735802
Review by: rj...@google.com
Revision: 8506
Author: jlaba...@google.com
Date: Mon Aug 9 08:45:34 2010
Log: Fixing the msg key in ContactInfoForm so that the two buttons use
different keys.
Review at http://gwt-code-reviews.appspot.com/746801
Review by: r...@google.com
Revision: 8507
Author: r...@google.com
Date: Mon Aug 9 08:47:15 2010
Log: Showcase: fix checkstyle errors and suppress deprecation warnings
Review at http://gwt-code-reviews.appspot.com/747801
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8507
Should Pattern.java have gone under user/super somewhere? The gwt-user
eclipse project's checkstyle isn't happy about that file.
http://gwt-code-reviews.appspot.com/735801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/08/09 19:34:56, scottb wrote:
Should Pattern.java have gone under user/super somewhere? The
gwt-user eclipse
project's checkstyle isn't happy about that file.
Yeah that file is excluded from that ant checkstyle. Let me know where
would be good? The build / dir are still a bit of a
Comment by j...@google.com:
@bob.whiton: I'm assuming you mean something like this:
B.addFooHandler(A);
// drop reference to A
This is just normal Java memory management -- nothing magic. So if B is
still around (because it is, e.g., a widget still attached to the
document), then A will
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
comnmitted as r8506
http://gwt-code-reviews.appspot.com/746801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/718802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi,
After reloading my app's module ~20 times, DevMode bogs down and has
to be restarted. Watching it with a profiler, it seems the heap (500mb)
is getting full and GC starts spiking the CPU. Permgen is fine.
I took a heap snapshot with jmap, and in YourKit, it looks like the
AppClassLoader is
Reviewers: chenglee_google.com,
Description:
Better error message on garbage in text.
Review by: cheng...@google.com
Please review this at http://gwt-code-reviews.appspot.com/748801/show
Affected files:
M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
Index:
LRDGTM
http://gwt-code-reviews.appspot.com/745801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
This change makes it so that TypeOracle can only be modified through an
associated TypeOracleBuilder. This prevents Generators from changing
the TypeOracle data model.
Please review this at http://gwt-code-reviews.appspot.com/748802/show
Affected files:
M
Is the number of JRealClassType instances just going up and up each refresh?
Can you figure out who is holding references to them (referrants)?
On Mon, Aug 9, 2010 at 7:03 PM, Stephen Haberman
step...@exigencecorp.comwrote:
Hi,
After reloading my app's module ~20 times, DevMode bogs down and
Thanks, John.
A question for you: should I get rid of the EventBus interface and
instead just add addHandler() to HasHandlers? In theory it's a breaking
change, but in practice are there really any HasHandler implementations
other than our own?
http://gwt-code-reviews.appspot.com/748801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
If you don't use GIN (you know, that really should be GIn), the rest of this
note probably won't interest you.
Would something like the following improve life for GIN users enough to be
worth doing? Or is it just a hack?
public interface UiBinderWithFactoryU, O, F extends UiBinderU, O {
/**
http://gwt-code-reviews.appspot.com/748801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Is the number of JRealClassType instances just going up and up each refresh?
Yep. I didn't explicitly check until you asked, but comparing heap diffs
before/after multiple refreshes, each refresh was adding ~1800 new
JRealClassTypes that never went away.
Can you figure out who is holding
31 matches
Mail list logo
