[gwt-contrib] protected com.google.gwt.user.client.ui.Widget.addHandler(H, TypeH)

2010-11-09 Thread cokol
why is com.google.gwt.user.client.ui.Widget.addHandler(H, TypeH) protected? in case I want to fire a custom event on a widget so that the widget is not aware of custom event handler, it makes it difficult to manage. thanks -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Comment on Editors in google-web-toolkit

2010-11-09 Thread codesite-noreply
Comment by carasen12: ?xml version='1.0' encoding='utf-8'? response entry id14196913/id hashe3ccc434d9840ad19204bcdfc999/hash requestHashcarasen12/requestHash profileUrlhttp://gravatar.com/carasen12/profileUrl

[gwt-contrib] Re: UiBinder. Design time tweaks for @UiField(provided) and @UiFactory (issue1077802)

2010-11-09 Thread Konstantin . Scheglov
http://gwt-code-reviews.appspot.com/1077802/diff/1/3 File user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java (right): http://gwt-code-reviews.appspot.com/1077802/diff/1/3#newcode52 user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java:52: w.write( void handle(String

[gwt-contrib] UiBinder. Using negative values in LayoutPane layer.

2010-11-09 Thread Konstantin.Scheglov
One of the users of GWT Designer found that code like this causes rendering failure. g:layer left=-34px width=109px top=70px height=20px g:CheckBox text=New CheckBox/ /g:layer As you can see, left attribute contains negative value. In Java version such value

[gwt-contrib] Fixing MultiSelectionModelTest to ensure that we are checking that the correct value is not sele... (issue1091801)

2010-11-09 Thread jlabanca
Reviewers: rchandia, Description: Fixing MultiSelectionModelTest to ensure that we are checking that the correct value is not selected. Please review this at http://gwt-code-reviews.appspot.com/1091801/show Affected files: M user/test/com/google/gwt/view/client/MultiSelectionModelTest.java

[gwt-contrib] Re: Adding MultiSelectionModel#clear() to clear all selected values. This is slightly more complicat... (issue1089801)

2010-11-09 Thread jlabanca
Good catch. I created a patch to fix the test case. http://gwt-code-reviews.appspot.com/1091801 http://gwt-code-reviews.appspot.com/1089801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a protected method CellTable#doSelection() as a hook that allows users to customize how the ... (issue1088801)

2010-11-09 Thread jlabanca
committed as r9199 http://gwt-code-reviews.appspot.com/1088801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] UiBinder. Using negative values in LayoutPane layer.

2010-11-09 Thread Ray Ryan
We shouldn't get hung up on the fact that LengthAttributeParser is misnamed (ScalarAttributeParser?). Negative support sounds like the right thing to do. Element parsers that are concerned about negative values could do their own check for that, although it could be tricky to do correctly. Did

[gwt-contrib] Re: Fixing MultiSelectionModelTest to ensure that we are checking that the correct value is not sele... (issue1091801)

2010-11-09 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1091801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-11-09 Thread kjin
will create RFC in Wave soon. http://gwt-code-reviews.appspot.com/1043801/diff/1/4 File dev/core/src/com/google/gwt/dev/cfg/SyntheticModuleDef.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/1/4#newcode50 dev/core/src/com/google/gwt/dev/cfg/SyntheticModuleDef.java:50: public

[gwt-contrib] This patch makes three changes: (issue1093801)

2010-11-09 Thread amitmanjhi
Reviewers: jat, Description: This patch makes three changes: 1. Excludes the client-side validation from being analyzed by api checker. Will remove this unnecessary exclusion once http://code.google.com/p/google-web-toolkit/issues/detail?id=5566 is resolved. Currently, because of this bug there

[gwt-contrib] Re: This patch makes three changes: (issue1093801)

2010-11-09 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1093801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This patch makes three changes: (issue1093801)

2010-11-09 Thread jat
http://gwt-code-reviews.appspot.com/1093801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/1093801/diff/1/2#newcode99 tools/api-checker/config/gwt20_21userApi.conf:99: :com.google.gwt.core.client.impl\ This came up in a separate CL --

[gwt-contrib] Re: This patch makes three changes: (issue1093801)

2010-11-09 Thread Amit Manjhi
On Tue, Nov 9, 2010 at 12:32 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/1093801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/1093801/diff/1/2#newcode99 tools/api-checker/config/gwt20_21userApi.conf:99:

[gwt-contrib] [google-web-toolkit] r9202 committed - Cherry picking r9061, r9178, r9179, r9190 into release branch.

2010-11-09 Thread codesite-noreply
Revision: 9202 Author: jlaba...@google.com Date: Mon Nov 8 07:55:07 2010 Log: Cherry picking r9061, r9178, r9179, r9190 into release branch. http://code.google.com/p/google-web-toolkit/source/detail?r=9202 Modified:

[gwt-contrib] UiBinder. Using negative values in LayoutPanel. (issue1094801)

2010-11-09 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: http://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/9832f30485ce48e2 This patch contains: 1. tweak for LengthAttributeParser to support +/- before value; 2. check for negative width/height in LayoutPanelParser; 3. tests for negative

[gwt-contrib] [google-web-toolkit] r9204 committed - Public (konstantin.scheg...@gmail.com):...

2010-11-09 Thread codesite-noreply
Revision: 9204 Author: gwt.mirror...@gmail.com Date: Tue Nov 9 08:44:38 2010 Log: Public (konstantin.scheg...@gmail.com): We need to provide at least some support for @UiField(provided) and @UiFactory in GWT Designer. At design time we pass null as owner, so we need to use special design time

[gwt-contrib] Re: UiBinder. Using negative values in LayoutPane layer.

2010-11-09 Thread Konstantin.Scheglov
We shouldn't get hung up on the fact that LengthAttributeParser is misnamed (ScalarAttributeParser?). Negative support sounds like the right thing to do. Element parsers that are concerned about negative values could do their own check for that, although it could be tricky to do correctly.

[gwt-contrib] [google-web-toolkit] r9205 committed - Fixing MultiSelectionModelTest to ensure that we are checking that the...

2010-11-09 Thread codesite-noreply
Revision: 9205 Author: gwt.mirror...@gmail.com Date: Tue Nov 9 09:07:13 2010 Log: Fixing MultiSelectionModelTest to ensure that we are checking that the correct value is not selected. Review at http://gwt-code-reviews.appspot.com/1091801 Review by: rchan...@google.com

[gwt-contrib] [google-web-toolkit] r9206 committed - Modifies the GWT compiler sharded entry points to support an alternati...

2010-11-09 Thread codesite-noreply
Revision: 9206 Author: zun...@google.com Date: Tue Nov 9 09:34:36 2010 Log: Modifies the GWT compiler sharded entry points to support an alternative method of sharding where multiple instances of Precompile and CompilePerms are invoked. Review at http://gwt-code-reviews.appspot.com/1074801

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

2010-11-09 Thread rchandia
This probably needs a README file to help users run the tests. I was not able to generate a gwt-x.y.z.zip containing the validationtck sample is that intended? http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001 File samples/build.xml (right):

[gwt-contrib] Re: Fixing MultiSelectionModelTest to ensure that we are checking that the correct value is not sele... (issue1091801)

2010-11-09 Thread jlabanca
committed as r9205 http://gwt-code-reviews.appspot.com/1091801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UiBinder. Using negative values in LayoutPanel. (issue1094801)

2010-11-09 Thread rjrjr
LGTM Nice! Thanks. http://gwt-code-reviews.appspot.com/1094801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding MultiSelectionModel#clear() to clear all selected values. This is slightly more complicat... (issue1089801)

2010-11-09 Thread jlabanca
committed as r9201 http://gwt-code-reviews.appspot.com/1089801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactoring HasDataPresenter to save pending changes in a PendingState, pushing them to the view... (issue1078801)

2010-11-09 Thread jlabanca
committed as r9203 http://gwt-code-reviews.appspot.com/1078801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT 2.1 Support for MyEclipse for Spring

2010-11-09 Thread Ray Ryan
We're working on GWT 2.1.1 right now, largely to address a lot of RequestFactory shortcomings. I can't commit to a date other than a lot faster than usual. The specifics are being tracked here: http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1 On Tue, Nov 9, 2010 at 11:41

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

2010-11-09 Thread nchalko
On 2010/11/09 22:11:55, rchandia wrote: This probably needs a README file to help users run the tests. I am not sure where the right place to put all of this code is. This not really a sample but a HACK to run the Technology Compatibility Kit for JSR 303. See

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

2010-11-09 Thread nchalko
http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

2010-11-09 Thread nchalko
http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001#newcode46 samples/build.xml:46: gwt.ant dir=validation / On 2010/11/09 22:11:55, rchandia wrote: This should be gwt.ant dir=validationtck / if

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

2010-11-09 Thread nchalko
http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updates the reference api for Api Checker to 2.1. Fixes 2 small bugs in Api Checker. (issue1095801)

2010-11-09 Thread amitmanjhi
Reviewers: jat, Description: Updates the reference api for Api Checker to 2.1. Fixes 2 small bugs in Api Checker. Patch by: amitmanjhi Review by: jat Please review this at http://gwt-code-reviews.appspot.com/1095801/show Affected files: M build.xml A

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

2010-11-09 Thread conroy
http://gwt-code-reviews.appspot.com/1084801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)

2010-11-09 Thread conroy
patch updated with some mac build fixups and the public key is now embedded in the manifest so that packed/unpacked use the same well known URI for the background page. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29022 File plugins/npapi/manifest-template.json (right):