Reviewers: rjrjr,
Description:
For Java UI the GWT Designer support dropping TreeItem on Tree and other
TreeItem. We need same feature for UiBinder too. This patch adds parsers
for Tree and TreeItem which support this feature.
Please review this at
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
fix DateTest by moving FUTURE to 2030
Please review this at http://gwt-code-reviews.appspot.com/1248802/show
Affected files:
M user/test/com/google/gwt/emultest/java/util/DateTest.java
Index: user/test/com/google/gwt/emultest/java/util/DateTest.java
LGTM
The software engineer in me doesn't like this. It would be better to
use getYear() + 10. But, for now lets just push the date out even
further.
http://gwt-code-reviews.appspot.com/1248802/diff/1/2
File user/test/com/google/gwt/emultest/java/util/DateTest.java (right):
http://gwt-code-reviews.appspot.com/1248802/diff/1/2
File user/test/com/google/gwt/emultest/java/util/DateTest.java (right):
http://gwt-code-reviews.appspot.com/1248802/diff/1/2#newcode867
user/test/com/google/gwt/emultest/java/util/DateTest.java:867: return
new Date(12/30/2030 3:4:5 GMT);
On
Reviewers: rchandia,
Description:
Patch MethodBinding.collectMissingTypes for IOOBE
Please review this at http://gwt-code-reviews.appspot.com/1252801/show
Affected files:
A dev/core/src/org/eclipse/jdt/internal/compiler/lookup/MethodBinding.java
--
LGTM
On 2011/01/03 05:09:04, Nick Chalko wrote:
Take a look again when you are back from Vacation.
http://gwt-code-reviews.appspot.com/1245801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9488
Author: con...@google.com
Date: Tue Jan 4 06:17:59 2011
Log: fix DateTest by moving FUTURE to 2030
Review at http://gwt-code-reviews.appspot.com/1248802
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9488
Modified:
Hey, Jeff.
Happy New Year, and thanks for your patience. I'm looking at this now.
On Thu, Dec 9, 2010 at 7:23 AM, Jeff Larsen larse...@gmail.com wrote:
bump.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
Revision: 9489
Author: gwt.mirror...@gmail.com
Date: Tue Jan 4 09:54:42 2011
Log: Mark test as Failing or NotSupported
These are reflected in the tck report numbers.
Failing and NotSupported tests are not run by default.
This will allow me to move these test into the normal user/test dir
and
LGTM
On 2011/01/04 17:11:31, conroy wrote:
http://gwt-code-reviews.appspot.com/1252801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/04 17:11:31, conroy wrote:
For reference,
https://bugs.eclipse.org/bugs/show_bug.cgi?id=247666
a declaration like the following triggers this bug:
public class X {
U,V extends Runnable void foo(Zork z) {}
void bar() {
foo(null);
}
}
This has been fixed in a
cc'ing John L, who actually understands this code
http://gwt-code-reviews.appspot.com/1149803/diff/1/3
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode116
user/src/com/google/gwt/user/client/ui/DialogBox.java:116:
Revision: 9490
Author: gwt.mirror...@gmail.com
Date: Tue Jan 4 07:56:18 2011
Log: Patch MethodBinding.collectMissingTypes for IOOBE
Review at http://gwt-code-reviews.appspot.com/1252801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9490
Added:
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9491
Author: p...@google.com
Date: Tue Jan 4 12:47:44 2011
Log: Conditional Properties example was broken. This changes to /
for a single-line property.
http://code.google.com/p/google-web-toolkit/source/detail?r=9491
Modified:
/wiki/ConditionalProperties.wiki
Reviewers: jat,
Description:
Update checkstyle rules to allow for copyright years up to 2029
Please review this at http://gwt-code-reviews.appspot.com/1253801/show
Affected files:
M eclipse/settings/code-style/gwt-checkstyle-tests.xml
M eclipse/settings/code-style/gwt-checkstyle.xml
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30:
public
LGTM
http://gwt-code-reviews.appspot.com/1253801/diff/1/3
File eclipse/settings/code-style/gwt-checkstyle.xml (right):
http://gwt-code-reviews.appspot.com/1253801/diff/1/3#newcode85
eclipse/settings/code-style/gwt-checkstyle.xml:85: property
name=header value=/\*\n \* Copyright
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30:
public
Reviewers: tobyr, jbrosenberg, scottb,
Description:
Adds a unit test for the TypeOracleMediator that feeds byte code instead
of source.
Please review this at http://gwt-code-reviews.appspot.com/1254801/show
Affected files:
M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
A
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009
File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009#newcode574
dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:574: *
structure of a
As this is new API, there are no current users. The intention is to use
this API in a locale selector widget which will automatically configure
itself from the module settings, rather than requiring duplicated
configuration in the source code.
The default values are set in I18N.gwt.xml, and are
LGTM except for nits. However, I haven't thoroughly reviewed the tests
yet, so I want to look over them further to make sure everything is
covered that needs to be.
Also, we need to get everyone to agree about adding this new API before
this can be committed.
Are you sure you don't want to introduce the widget and the api at the
same time?
How are you avoiding duplication here? It's not like anything other than
this widget will read this config, right? It's more like you're moving
it around.
http://gwt-code-reviews.appspot.com/1250801/show
--
On 2011/01/05 00:01:40, jat wrote:
LGTM except for nits. However, I haven't thoroughly reviewed the
tests yet, so
I want to look over them further to make sure everything is covered
that needs
to be.
Sounds good.
Also, we need to get everyone to agree about adding this new API
before
http://gwt-code-reviews.appspot.com/1251801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1251801/diff/1/5
File
user/src/com/google/gwt/user/server/rpc/AbstractXsrfProtectedServiceServlet.java
(right):
http://gwt-code-reviews.appspot.com/1251801/diff/1/5#newcode2
user/src/com/google/gwt/user/server/rpc/AbstractXsrfProtectedServiceServlet.java:2:
*
On 2011/01/05 00:14:22, rjrjr wrote:
Are you sure you don't want to introduce the widget and the api at the
same
time?
If you like, I can do a simple version now (similar to the one in
showcase) and the more complicated one I had in mind later (which would
use a generator to build a menu
On Tue, Jan 4, 2011 at 5:37 PM, j...@google.com wrote:
On 2011/01/05 00:14:22, rjrjr wrote:
Are you sure you don't want to introduce the widget and the api at the
same
time?
If you like, I can do a simple version now (similar to the one in
showcase) and the more complicated one I had
http://gwt-code-reviews.appspot.com/1251801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009
File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009#newcode574
dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:574: *
structure of a
Reviewers: rchandia,
Description:
Move all tests to org/hibernate/jsr303/tck
[JSR 303 TCK Result] 54 of 258 (20.93%) Pass with 28 Failures and 13
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1255801/show
Affected files:
M samples/validationtck/build.xml
A
33 matches
Mail list logo
