[gwt-contrib] Issue 4916: optgroups in select elements cause issue in WebKit-based browsers (issue1313801)

2011-01-21 Thread t . broyer
Reviewers: cramsdale, jgw, Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=4916 Remove old workaround code from DOMImplSafari for something that's been fixed in Safari for a while makes it hard to work with optgroups in select elements. Assigning arbitrarily to Chris

[gwt-contrib] Re: Add support for mapping ConstraintViolation objects into SimpleBeanEditor. (issue1260801)

2011-01-21 Thread BobV
On Thu, Jan 20, 2011 at 10:00 PM, Ray Ryan rj...@google.com wrote: Bob, did this land? r9562 -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Only JClassTypes should have a super class. (issue1312801)

2011-01-21 Thread zundel
http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004 File dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java (right): http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004#newcode36 dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java:36: return null; I don't

[gwt-contrib] Issue 5879: Make UiBinder accept IsWidget subinterfaces properly

2011-01-21 Thread Luis Solano
Hello, I need a solution for this issue (http://code.google.com/p/google-web- toolkit/issues/detail?id=5879), and I would like to fix it by myself. I thought about two solutions and I wonder if somebody can point me the right way to get this done. Thank you! - Luis --

[gwt-contrib] Fixing a bug in ResizeLayoutPanel where moving the scroll bars triggers a scroll event on older ... (issue1314801)

2011-01-21 Thread jlabanca
Reviewers: pdr, Description: Fixing a bug in ResizeLayoutPanel where moving the scroll bars triggers a scroll event on older versions of Safari, which causes an infinite loop. Please review this at http://gwt-code-reviews.appspot.com/1314801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r9584 committed - Adding Jeff Larsen to CLA Signers file. CLA electronically signed on ...

2011-01-21 Thread codesite-noreply
Revision: 9584 Author: jlaba...@google.com Date: Fri Jan 21 07:40:06 2011 Log: Adding Jeff Larsen to CLA Signers file. CLA electronically signed on 1/18/2011. http://code.google.com/p/google-web-toolkit/source/detail?r=9584 Modified: /CLA-SIGNERS ===

[gwt-contrib] Re: Issue 5563: Make it easier to implement PlaceHistoryMapper directly (issue1293801)

2011-01-21 Thread t . broyer
http://gwt-code-reviews.appspot.com/1293801/diff/1/2 File user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/1293801/diff/1/2#newcode41 user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java:41: static

[gwt-contrib] [google-web-toolkit] r9585 committed - Optimize redundant 'switch' statements...

2011-01-21 Thread codesite-noreply
Revision: 9585 Author: r...@google.com Date: Fri Jan 21 04:40:04 2011 Log: Optimize redundant 'switch' statements Fix bug caused by using short idents when matching case bodies Review at http://gwt-code-reviews.appspot.com/1311801 Review by: sco...@google.com

[gwt-contrib] [google-web-toolkit] r9586 committed - Fixing a bug in ResizeLayoutPanel where moving the scroll bars trigger...

2011-01-21 Thread codesite-noreply
Revision: 9586 Author: jlaba...@google.com Date: Fri Jan 21 04:52:44 2011 Log: Fixing a bug in ResizeLayoutPanel where moving the scroll bars triggers a scroll event on older versions of Safari, which causes an infinite loop. http://gwt-code-reviews.appspot.com/1314801 Review by:

[gwt-contrib] Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jlabanca
Reviewers: jgw, Description: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated notation. Please review this at http://gwt-code-reviews.appspot.com/1315801/show Affected files: M user/src/com/google/gwt/dom/client/Style.java M

[gwt-contrib] Re: Only JClassTypes should have a super class. (issue1312801)

2011-01-21 Thread scottb
http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004 File dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java (right): http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004#newcode36 dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java:36: return null; Yes, but super

[gwt-contrib] Re: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jgw
On 2011/01/21 16:09:17, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/1315801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] AbstractPlaceHistoryMapper doesn't process tokens correctly wrt empty prefixes (issue1316801)

2011-01-21 Thread t . broyer
Reviewers: rjrjr, Description: in r8817, we landed a patch that allows @Prefix(), i.e. a non-prefixed PlaceTokenizer, and produces a separator-less history token as a result. The token parsing however wasn't updated, and such a token would always go the fallback route to the default place,

[gwt-contrib] Fixing a bug in ResizeLayoutPanel where moving the scroll bars triggers a scroll event on older ... (issue1314801)

2011-01-21 Thread jlabanca
Reviewers: pdr, Message: committed as r9586 Description: Fixing a bug in ResizeLayoutPanel where moving the scroll bars triggers a scroll event on older versions of Safari, which causes an infinite loop. Please review this at http://gwt-code-reviews.appspot.com/1314801/show Affected files:

[gwt-contrib] [google-web-toolkit] r9587 committed - Fixing the overflow-x and overflow-y properties in Style to use camelC...

2011-01-21 Thread codesite-noreply
Revision: 9587 Author: jlaba...@google.com Date: Fri Jan 21 05:38:10 2011 Log: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated notation. Review at http://gwt-code-reviews.appspot.com/1315801 Review by: j...@google.com

[gwt-contrib] Re: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jlabanca
committed as r9587 http://gwt-code-reviews.appspot.com/1315801/diff/1/3 File user/test/com/google/gwt/dom/client/StyleTest.java (right): http://gwt-code-reviews.appspot.com/1315801/diff/1/3#newcode214 user/test/com/google/gwt/dom/client/StyleTest.java:214: assertEquals(Overflow.AUTO,

[gwt-contrib] Re: Fixing the overflow-x and overflow-y properties in Style to use camelCase instead of hyphenated ... (issue1315801)

2011-01-21 Thread jlabanca
committed as r9587 http://gwt-code-reviews.appspot.com/1315801/diff/1/3 File user/test/com/google/gwt/dom/client/StyleTest.java (right): http://gwt-code-reviews.appspot.com/1315801/diff/1/3#newcode214 user/test/com/google/gwt/dom/client/StyleTest.java:214: assertEquals(Overflow.AUTO,

Re: [gwt-contrib] RFC: Fixed width column support in CellTable

2011-01-21 Thread vela . ignacio
Hi, I need to use this patch, but I'm really losed about how to download and use it. How must I install this patch in my enviroment? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Allow Editor framework to handle primitive types. (issue1312802)

2011-01-21 Thread bobv
Reviewers: rjrjr, Description: Allow Editor framework to handle primitive types. Issue 5864. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1312802/show Affected files: M user/src/com/google/gwt/editor/rebind/model/EditorModel.java M

Re: [gwt-contrib] RFC: Fixed width column support in CellTable

2011-01-21 Thread John LaBanca
The easiest way to get it is to wait for the GWT 2.2 milestone, which should be released soon. You can also build GWT from trunk by following the directions at the link below. You'll need a JDK, svn, and ant installed to build it.

Re: [gwt-contrib] RFC: Fixed width column support in CellTable

2011-01-21 Thread vela . ignacio
Thanks John, I will try to build from trunk but if I can't do it myself i will be waiting for the GWT 2.2 milestone to be released soon :) Regards. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimizations for server-side invocations of CustomFieldSerializers. (issue1273801)

2011-01-21 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1273801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Decentralize JNonNullType from JProgram. (issue1317801)

2011-01-21 Thread scottb
Reviewers: cromwellian, Please review this at http://gwt-code-reviews.appspot.com/1317801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/EnumNameObfuscator.java M dev/core/src/com/google/gwt/dev/jjs/ast/JNewArray.java M

[gwt-contrib] [google-web-toolkit] r9588 committed - Edited wiki page TroubleshootingOOPHM through web user interface.

2011-01-21 Thread codesite-noreply
Revision: 9588 Author: con...@google.com Date: Fri Jan 21 12:55:57 2011 Log: Edited wiki page TroubleshootingOOPHM through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9588 Modified: /wiki/TroubleshootingOOPHM.wiki === ---

[gwt-contrib] Re: Decentralize JNonNullType from JProgram. (issue1317801)

2011-01-21 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1317801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make sure redundant calls to an Activity's display setWidget are OK (issue999802)

2011-01-21 Thread rjrjr
r9583 On 2011/01/21 04:12:05, rjrjr wrote: lgtm, in it goes http://gwt-code-reviews.appspot.com/999802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9594 committed - Make maven_script.sh more flexible

2011-01-21 Thread codesite-noreply
Revision: 9594 Author: rj...@google.com Date: Fri Jan 21 13:52:51 2011 Log: Make maven_script.sh more flexible http://code.google.com/p/google-web-toolkit/source/detail?r=9594 Modified: /trunk/tools/scripts/maven_script.sh === ---

[gwt-contrib] [google-web-toolkit] r9595 committed - Fix inadvertent commenting of Showcase locales....

2011-01-21 Thread codesite-noreply
Revision: 9595 Author: j...@google.com Date: Fri Jan 21 14:07:46 2011 Log: Fix inadvertent commenting of Showcase locales. Patch by: jat Review by: jlabanca (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=9595 Modified:

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

2011-01-21 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Only JClassTypes should have a super class. (issue1312801)

2011-01-21 Thread cromwellian
LGTM tentatively (I don't think my comments on weird implicit object supertypes will actually have any real affect on GWT programs) http://gwt-code-reviews.appspot.com/1312801/diff/3001/4001 File dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java (left):