LGTM
On 2011/04/05 17:35:36, fredsa wrote:
http://gwt-code-reviews.appspot.com/1398802/diff/1/user/src/com/google/gwt/event/dom/client/DragExitEvent.java
File user/src/com/google/gwt/event/dom/client/DragExitEvent.java
(right):
Revision: 9953
Author: rj...@google.com
Date: Thu Apr 7 03:48:02 2011
Log: Cherry picking r9948 for UiBinder.useSafeHtmlTemplates
http://code.google.com/p/google-web-toolkit/source/detail?r=9953
Modified:
/releases/2.3/user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
http://gwt-code-reviews.appspot.com/1384801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9954
Author: jlaba...@google.com
Date: Thu Apr 7 05:39:53 2011
Log: Fixing a few Cell Widget bugs. I combined these bugs because they
are all quick fixes and fairly straightforward.
(Issue 5971) CompositeCell does not implement isEditing. I implemented
isEditing in
http://gwt-code-reviews.appspot.com/1384801/diff/8001/user/src/com/google/gwt/safecss/shared/SafeStyles.java
File user/src/com/google/gwt/safecss/shared/SafeStyles.java (right):
committed as r9954
http://gwt-code-reviews.appspot.com/1408801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
reify := make real
I found a couple of bugs running internal test suites that have been
fixed in the latest patch with a test added to the GWT code base.
http://gwt-code-reviews.appspot.com/1407802/diff/1/user/src/com/google/gwt/autobean/rebind/AutoBeanFactoryGenerator.java
File
Its starred in my inbox. I'll submit it today or tomorrow.
Thanks,
John LaBanca
jlaba...@google.com
On Thu, Apr 7, 2011 at 12:16 PM, Thomas Broyer t.bro...@gmail.com wrote:
Psst, you both LGTM'd my CL about CellWidget-s but didn't commit it.
Remember: I don't have commit rights ;-) (I just
Reviewers: pdr,
Description:
Updating Showcase to use LayoutPanels throughout the hierarchy, thus
implementing ProvidesResize down to the examples. This allows the
examples to look better, especially examples that implement
RequiresResize. Most of the example look the same, but TabLayoutPanel
Psst, you both LGTM'd my CL about CellWidget-s but didn't commit it.
Remember: I don't have commit rights ;-) (I just don't have access to your
internal perforce to begin with)
See: http://gwt-code-reviews.appspot.com/1400802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9956
Author: jlaba...@google.com
Date: Thu Apr 7 07:38:23 2011
Log: Cherry picking r9954 into releases/2.3 for issues 5971, 5993, and
6134.
http://code.google.com/p/google-web-toolkit/source/detail?r=9956
Added:
LGTM
I'll test this out and submit it.
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):
Revision: 9957
Author: rj...@google.com
Date: Thu Apr 7 08:40:59 2011
Log: Change the default of UiBinder.useSafeHtmlTemplates to false
for gwt 2.3
Review by: sbruba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9957
Modified:
I verified that the animations work on IE (timer version), Chrome 10
(verified the time fix is needed and works) and 11, Safari 5 (which
does not support animation frames and uses the timer version), firefox
3.6 (timer version) and firefox 4.0 (moz animation frame).
I'll submit this change soon.
http://gwt-code-reviews.appspot.com/1407802/diff/6001/user/src/com/google/gwt/autobean/client/impl/JsoSplittable.java
File user/src/com/google/gwt/autobean/client/impl/JsoSplittable.java
(right):
Reviewers: pdr,
Description:
New projects should always have a DTD specified in their template
.gwt.xml module file
Also, fix broken NoNag version check logic.
Please review this at http://gwt-code-reviews.appspot.com/1407803/
Affected files:
M
LGTM pending a check of showcase on mobile/tablet devices.
http://gwt-code-reviews.appspot.com/1409801/diff/1/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
File
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
(right):
Looks great on a tablet.
http://gwt-code-reviews.appspot.com/1409801/diff/1/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
File
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
(right):
Revision: 9959
Author: gwt.mirror...@gmail.com
Date: Thu Apr 7 13:47:10 2011
Log: Don't allow constants folding and copy propagation optimizations
to perform implicit type conversions.
Review by: r...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9959
Revision: 9960
Author: gwt.mirror...@gmail.com
Date: Thu Apr 7 14:18:12 2011
Log: Updating Showcase to use LayoutPanels throughout the hierarchy,
thus implementing ProvidesResize down to the examples. This allows the
examples to look better, especially examples that implement
Revision: 9961
Author: jlaba...@google.com
Date: Thu Apr 7 10:52:25 2011
Log: Fixing issue 6206 (CellWidget#getValue() is never updated) and
6216 (CellWidget should implement IsEditorC).
Review at http://gwt-code-reviews.appspot.com/1400802/.
Issue: 6206, 6216
Patch by: tbroyer
committed as r9960
http://gwt-code-reviews.appspot.com/1409801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r9961
http://gwt-code-reviews.appspot.com/1400802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: robertvawter,
Description:
Some small refactors to Css Resource Generation
Please review this at http://gwt-code-reviews.appspot.com/1406802/
Affected files:
M user/src/com/google/gwt/resources/client/CssResource.java
A
Reviewers: drfibonacci,
Description:
Reindented pom.xml files
Please review this at http://gwt-code-reviews.appspot.com/1410801/
Affected files:
M samples/expenses/pom.xml
M user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
--
Re-rolling the patch with changes just to JsoSplittable and
SplittableTest to fix the Safari4 test failure and improve the
robustness of the type detection code.
http://gwt-code-reviews.appspot.com/1407802/diff/6001/user/src/com/google/gwt/autobean/client/impl/JsoSplittable.java
File
Revision: 9962
Author: gwt.mirror...@gmail.com
Date: Thu Apr 7 16:16:56 2011
Log: Cherry picking r9961 into releases/2.3 for issues 6206 and 6216.
http://code.google.com/p/google-web-toolkit/source/detail?r=9962
Modified:
Revision: 9963
Author: unn...@google.com
Date: Thu Apr 7 11:55:26 2011
Log: Some small refactors to Css Resource Generation
Review at http://gwt-code-reviews.appspot.com/1406802
http://code.google.com/p/google-web-toolkit/source/detail?r=9963
Added:
Reviewers: fabiomfv,
Description:
make it possible to just use devmode on a particular module while
allowing the
others to run in prod mode
Please review this at http://gwt-code-reviews.appspot.com/1408802/
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
M
29 matches
Mail list logo
