Thomas, I went ahead and landed this because we need to start testing
2.5 for release and this patch is unwieldly large. I will follow up with
much smaller patches that fix the various issues. :)
http://gwt-code-reviews.appspot.com/1728806/
--
LGTM.
I'll make another CL updating the Maven artifacts.
http://gwt-code-reviews.appspot.com/1732804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/14 07:17:21, tbroyer wrote:
I'll make another CL updating the Maven artifacts.
http://gwt-code-reviews.appspot.com/1732804/
http://gwt-code-reviews.appspot.com/1732804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/14 07:25:50, tbroyer wrote:
On 2012/06/14 07:17:21, tbroyer wrote:
I'll make another CL updating the Maven artifacts.
http://gwt-code-reviews.appspot.com/1732804/
Oops, sorry, wrong link: https://gwt-code-reviews.appspot.com/1737805/
Reviewers: cromwellian, skybrian,
Message:
This is a follow up to http://gwt-code-reviews.appspot.com/1732804/
It unbundles org/json from gwt-dev before deploying to Maven Central,
and adds it as a dependency instead (as we did for requestfactory-*).
org.json is also added as a dependency to
On 2012/06/14 01:20:58, skybrian wrote:
To fix the compiler and close issue 7397, we only need to add json (of
any
version) to gwt-dev.jar. So I think I'm going to commit a tiny change
that just
does that. We can defer the other stuff until we have a better plan.
OK let's do that. Baby
On Wed, Jun 13, 2012 at 11:23 PM, Rajeev Dayal rda...@google.com wrote:
On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.com
wrote:
I don't think we support Java 1.5 anymore?
http://code.google.com/p/google-web-toolkit/issues/detail?id=6790
On Wed, Jun 13, 2012 at 3:15 PM, Alan Leung acle...@google.com wrote:
On Mon, Jun 11, 2012 at 5:23 PM, skybr...@google.com wrote:
I don't understand this code, but I wonder if there is any way to write
a smoke test for soyc?
I left a TODO for now.
Without challenging Alan's decision here
On 2012/06/14 15:19:09, rkj wrote:
I am a bit confused now. I follow the example:
https://developers.google.com/web-toolkit/doc/latest/tutorial/i18n
As I understand the GWT.create should create proper implementation
based on
properties file - why isn't that so?
The issue is that they would
Submitted as r11057
http://gwt-code-reviews.appspot.com/1734804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Prevent compilation failures due to type inferencing bugs (bug 6302954
at bugs.sun.com) in older versions of JDK6.
Please review this at http://gwt-code-reviews.appspot.com/1736805/
Affected files:
M user/src/com/google/gwt/core/client/GWT.java
M
Reviewers: skybrian,
Description:
Removes execution order dependency on EnumOrdinalizerTest
Please review this at http://gwt-code-reviews.appspot.com/1731806/
Affected files:
M dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
--
http://gwt-code-reviews.appspot.com/1739803/diff/6002/user/src/com/google/gwt/user/cellview/client/CellTree.java
File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1736805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. I'll submit this.
On 2012/06/14 07:32:40, tbroyer wrote:
because gwt-user
has no declared dependency on gwt-dev (this might be a mistake, or
not)
I'm guessing this is because we don't want GWT user code to have
dependencies on classes that should only be used in the compiler.
LGTM
http://gwt-code-reviews.appspot.com/1731806/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
(right):
Updated the CL with some fixes to the Ant build:
- failed in the absence of a CC environment variable
- tried to copy to elemental/java where as the source is in
elemental/src; instead of copying to src, I instead kept the generated
source separate and simply added elemented/idl/generated/src
I fixed those already but unfortunately it looks like the Google -
SVN mirror is stuck again. opps, no, my internal commit failed to
through) I'll accept your solution because it's better than copying
(doesn't pollute your SVN directories)
-Ray
On Thu, Jun 14, 2012 at 2:46 PM,
https://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml
File build.xml (right):
https://gwt-code-reviews.appspot.com/1727808/diff/8001/build.xml#newcode41
build.xml:41: call-subproject subproject=elemental subtarget=build
/
I asked Ray about this. Elemental is experimental and its
Reviewers: acleung,
Description:
Fix Super Dev Mode's code server to launch on localhost by default.
(There were comments about this but it wasn't actually true.)
Add -bindAddress option to override this. In particular, -bindAddress
0.0.0.0
restores previous behavior.
Please review this at
On 2012/06/15 00:48:51, skybrian wrote:
LGTM
http://gwt-code-reviews.appspot.com/1740803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1740803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
In particular, elemental will not build on a Windows box or an OSX box
that does not have XCode installed. The requirements for the code-gen
are Python 2.6 pre-installed and gcc pre-installed. So I don't think
we can add it to the default built, but rather, we will distribute the
jar in the 2.5
23 matches
Mail list logo
