Manuel Carrasco Moñino has posted comments on this change.
Change subject: Fix binary vs. internal variable names, remove unused Name
code.
..
Patch Set 1: Code-Review+1
--
To view, visit
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Adding key codes
..
Adding key codes
fixes issue 8203
Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M
Ray Cromwell has posted comments on this change.
Change subject: Adding key codes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3480
To unsubscribe, visit
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3480
Change subject: Adding key codes
..
Adding key codes
fixes issue 8203
Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M
Daniel Kurka has submitted this change and it was merged.
Change subject: Adding key codes
..
Adding key codes
fixes issue 8203
Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
doesn't fit into current IsXXX because if it was you wouldn't need
IsWidget2 :)
My take is that it's just
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
The part that I'm not comfortable with is, you can exactly have the same
effect with the current state.
Yes
Matthew Dempsky has uploaded a new change for review.
https://gwt-review.googlesource.com/3490
Change subject: Use Double.isNan(d) instead of d != d to test for NaN.
..
Use Double.isNan(d) instead of d != d to test for NaN.
Goktug Gokdogan has posted comments on this change.
Change subject: Use Double.isNaN(d) instead of d != d to test for NaN.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3490
To
Goktug Gokdogan has posted comments on this change.
Change subject: Adds Timer#isRunning().
..
Patch Set 2:
Daniel, do you have any other concerns?
--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe,
Colin Alworth has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
What is the thinking for the remaining 10%-ish of widgets - all of the cell
widgets (except CellPanel), remaining
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Fixes UiHandler method matching in generic classes
..
Fixes UiHandler method matching in generic classes
Method matching in UiHandler is completely
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3500
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
..
Adds an accessor to original throwable
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3510
Change subject: Fixes GWT.runAsync that was broken in a recent patch.
..
Fixes GWT.runAsync that was broken in a recent patch.
Brian Slesinsky has posted comments on this change.
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
..
Patch Set 1: Code-Review+1
(1 comment)
Seems basically okay.
Goktug Gokdogan has posted comments on this change.
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
..
Patch Set 1:
(1 comment)
File
Hello Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3500
to look at the new patch set (#2).
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3501
Change subject: Adds Element#toggleClassName.
..
Adds Element#toggleClassName.
Change-Id:
Brian Slesinsky has posted comments on this change.
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
..
Patch Set 2: Code-Review+2
(1 comment)
Hello Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3500
to look at the new patch set (#3).
Change subject: Adds an accessor to original throwable from
SerializableThrowable.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3511
Change subject: Adds Node#removeAllChildren.
..
Adds Node#removeAllChildren.
Change-Id:
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3512
Change subject: Move StackTraceDeobfuscator from core.server.impl to
core.server.
..
Move StackTraceDeobfuscator from
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
Hi Colin, the only approach in selecting classes is that these are what I'd
used so far, plus a few others.
Daniel Kurka has posted comments on this change.
Change subject: Adds Node#removeAllChildren.
..
Patch Set 1:
(3 comments)
File
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 8:
Hi Goktug,
Being said that, rest assured, I wouldn't -1 for just not using it.
Good, good--sorry if I got a
Daniel Kurka has posted comments on this change.
Change subject: Adds Element#toggleClassName.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3501
To unsubscribe, visit
26 matches
Mail list logo
