Re: [gwt-contrib] being cute with git describe

2013-10-22 Thread Thomas Broyer
FYI, Gerrit just uses git describe and no special branch/tag dance: https://gerrit.googlesource.com/gerrit/+/stable-2.8/gerrit-war/BUCK https://gerrit.googlesource.com/gerrit/+/stable-2.8/tools/git.defs (note that I deliberately used a release branch rather than master; also note that the

[gwt-contrib] Re: Where is gwt-customchecks.jar?

2013-10-22 Thread Andrés Testi
Thanks Colin! I'm glad to see the power of the community in action :-) - Andrés Testi El lunes, 21 de octubre de 2013 19:59:53 UTC-3, Colin Alworth escribió: Tentative patch up at https://gwt-review.googlesource.com/5063 - can someone sanity check it for me? It looks like step 4 (now step 3)

[gwt-contrib] Re: Where is gwt-customchecks.jar?

2013-10-22 Thread Colin Alworth
If only *all* of my changes were that easy to make... On Tuesday, October 22, 2013 8:15:12 AM UTC-5, Andrés Testi wrote: Thanks Colin! I'm glad to see the power of the community in action :-) - Andrés Testi El lunes, 21 de octubre de 2013 19:59:53 UTC-3, Colin Alworth escribió: Tentative

[gwt-contrib] Re: Where is gwt-customchecks.jar?

2013-10-22 Thread Andrés Testi
The changes may be small and easy, but consequences may be great. In this case, your change will save lots of useless google searches to newbie contributors ;-) - Andrés Testi El martes, 22 de octubre de 2013 10:32:43 UTC-3, Colin Alworth escribió: If only *all* of my changes were that easy

[gwt-contrib] Question about the source: how does GWT builds *.translatable.*, *.emul.*, etc. packages?

2013-10-22 Thread Cristiano
Hi all, I'm going on with my analysis of the GWT source code, and I have achieved one of my first step, that is creating a jdepend report. However I had to exclude many classes because their package directive does not match the expected package. The classes affected by this problem are located

[gwt-contrib] Re: Question about the source: how does GWT builds *.translatable.*, *.emul.*, etc. packages?

2013-10-22 Thread Jens
The build script does not compile these source files to classes. Instead it just bundles them into the jar as resource files. These are super source packages, meaning that they won't get compiled to .class files but instead are bundled as source files into the jar. The GWT compiler then puts

Re: [gwt-contrib] being cute with git describe

2013-10-22 Thread Stephen Haberman
- do we really want to keep the 0.0.0 special version? (would it really hurt if master currently said 2.5.1-250-g4a00f1e?) FWIW I like 0.0.0 because it strongly differentiates hand-made/master releases vs. official/release branch releases. And it always sorts before release versions, which

[gwt-contrib] Re: Question about the source: how does GWT builds *.translatable.*, *.emul.*, etc. packages?

2013-10-22 Thread Thomas Broyer
On Tuesday, October 22, 2013 5:39:34 PM UTC+2, Jens wrote: The build script does not compile these source files to classes. Instead it just bundles them into the jar as resource files. These are super source packages, meaning that they won't get compiled to .class files but instead are

Re: [gwt-contrib] Re: Question about the source: how does GWT builds *.translatable.*, *.emul.*, etc. packages?

2013-10-22 Thread John A. Tamplin
On Tue, Oct 22, 2013 at 12:11 PM, Thomas Broyer t.bro...@gmail.com wrote: As far as modularization is concerned, we'd like to have dependencies always in the same direction: rebind-client-shared-server (or rebind-client-server-shared, depending on modules) so we can make a client artifact

Re: [gwt-contrib] Re: Question about the source: how does GWT builds *.translatable.*, *.emul.*, etc. packages?

2013-10-22 Thread Thomas Broyer
On Tuesday, October 22, 2013 6:13:49 PM UTC+2, John A. Tamplin wrote: On Tue, Oct 22, 2013 at 12:11 PM, Thomas Broyer t.br...@gmail.comjavascript: wrote: As far as modularization is concerned, we'd like to have dependencies always in the same direction: rebind-client-shared-server (or

Re: [gwt-contrib] being cute with git describe

2013-10-22 Thread Matthew Dempsky
On Tue, Oct 22, 2013 at 9:10 AM, Stephen Haberman step...@exigencecorp.comwrote: Also FWIW, I am not a fan of master's git describe looking like 2.5.1-250- That seems misleading, because if we put the 2.5.1-rc0 tag directly on master's commit B: A - B [2.5.1-rc0] - C - D (master) And

Re: [gwt-contrib] Re: Bad news for GWT DevMode!

2013-10-22 Thread Brian Slesinsky
I expect that by next summer devmode will *only* work in IE and perhaps an older version of Firefox. Oddly enough, the IE plugin has apparently worked for years with no complaints. (But the issue is that nobody currently on the team has ever built it.) - Brian On Mon, Oct 21, 2013 at 6:56 AM,

Re: [gwt-contrib] Re: Bad news for GWT DevMode!

2013-10-22 Thread Colin Alworth
Amazingly, it still works great in the IE11 preview too! Only gotcha is that the missing plugin page thinks you are running firefox, so you need to manually grab the right copy of the IE plugin. On Tuesday, October 22, 2013 12:58:57 PM UTC-5, Brian Slesinsky wrote: I expect that by next

Re: [gwt-contrib] Re: Bad news for GWT DevMode!

2013-10-22 Thread Matthew Dempsky
On Tue, Oct 22, 2013 at 11:03 AM, Colin Alworth niloc...@gmail.com wrote: Amazingly, it still works great in the IE11 preview too! Only gotcha is that the missing plugin page thinks you are running firefox, so you need to manually grab the right copy of the IE plugin. Haha. We should file a

[gwt-contrib] Re: Gerrit presubmit changes

2013-10-22 Thread Matthew Dempsky
One more update: The presubmitter tools are now open source. They're written in Go and the source code is available at https://gwt.googlesource.com/buildglue/. You can easily download and build it using the go command: mkdir buildglue export GOPATH=$PWD/buildglue go get

Re: [gwt-contrib] being cute with git describe

2013-10-22 Thread Thomas Broyer
Le 22 oct. 2013 19:26, Matthew Dempsky mdemp...@google.com a écrit : On Tue, Oct 22, 2013 at 9:10 AM, Stephen Haberman step...@exigencecorp.com wrote: Also FWIW, I am not a fan of master's git describe looking like 2.5.1-250- That seems misleading, because if we put the 2.5.1-rc0 tag

[gwt-contrib] Re: Change in gwt[master]: Added disabled IE10 permutation

2013-10-22 Thread Matthew Dempsky
[Moving discussion to gwt-contrib] If we don't fallback, we'll need to figure out how to handle the GWT 2.6 release. Possible options: 1. Enable ie10 permutation without fallback. When users upgrade, they need to simultaneously fix their code by adding appropriate rebind rules for ie10. Or