[gwt-contrib] Re: Fixing a bug in CellTree where refreshing an empty list of children causes an AssertionError tha... (issue1463805)

2011-06-20 Thread dconnelly
LGTM http://gwt-code-reviews.appspot.com/1463805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added -XdisableSoycHtml command line flag for disabling HTML compile report generation. This wil... (issue1450807)

2011-05-31 Thread dconnelly
http://gwt-code-reviews.appspot.com/1450807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Consolidates all methodDependencies files into one per split point. (issue1453802)

2011-05-31 Thread dconnelly
http://gwt-code-reviews.appspot.com/1453802/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (right):

[gwt-contrib] Re: cleanups to soyc HTML report generation code. (issue1447811)

2011-05-31 Thread dconnelly
LGTM On 2011/05/31 16:06:31, zundel wrote: http://gwt-code-reviews.appspot.com/1447811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Added -XdisableSoycHtml command line flag for disabling HTML compile report generation. This wil... (issue1450807)

2011-05-27 Thread dconnelly
Reviewers: zundel, Description: Added -XdisableSoycHtml command line flag for disabling HTML compile report generation. This will not affect SOYC XML output. Please review this at http://gwt-code-reviews.appspot.com/1450807/ Affected files: M

[gwt-contrib] Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1451803)

2011-05-26 Thread dconnelly
Reviewers: zundel, Description: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown action under each method. Please review this at http://gwt-code-reviews.appspot.com/1451803/ Affected files: M

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1451803)

2011-05-26 Thread dconnelly
A NOOO On 2011/05/26 15:08:30, dconnelly wrote: http://gwt-code-reviews.appspot.com/1451803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

2011-05-26 Thread dconnelly
Reviewers: zundel, Description: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown action under each method. Review by: zun...@google.com Please review this at http://gwt-code-reviews.appspot.com/1443809/ Affected files: M

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

2011-05-26 Thread dconnelly
http://gwt-code-reviews.appspot.com/1443809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-25 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-25 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-25 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Implemented expression range shifting for IE block size transformation. Moved expression range s... (issue1446809)

2011-05-24 Thread dconnelly
Reviewers: zundel, Description: Implemented expression range shifting for IE block size transformation. Moved expression range shifting for both transformations inside the transformation classes. Modified constructors/instance variables for the JsAbstractTextTransformer to support updating the

[gwt-contrib] Re: Partial fix for buganizer issue 4466425. Created a method to shift the expression range indices ... (issue1451801)

2011-05-24 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Partial fix for buganizer issue 4466425. Created a method to shift the expression range indices ... (issue1451801)

2011-05-24 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-24 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-24 Thread dconnelly
http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix expression ranges in detailed SOYC output (issue1451801)

2011-05-24 Thread dconnelly
On 2011/05/24 22:23:08, dconnelly wrote: I named this patch set poorly... there were several things in JavaToJavaScriptCompiler that I had to merge in. http://gwt-code-reviews.appspot.com/1451801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Partial fix for buganizer issue 4466425. Created a method to shift the expression range indices ... (issue1451801)

2011-05-23 Thread dconnelly
Reviewers: zundel, Description: Partial fix for buganizer issue 4466425. Created a method to shift the expression range indices for the detailed SOYC reports after function clustering. Please review this at http://gwt-code-reviews.appspot.com/1451801/ Affected files: M

[gwt-contrib] Re: Changed formatting of SOYC compiler report to use large number grouping (ex: 7,923,764), (issue1449803)

2011-05-18 Thread dconnelly
http://gwt-code-reviews.appspot.com/1449803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Previous change to compiler report formatting switched to NumberFormat to format deciamls, but b... (issue1443803)

2011-05-18 Thread dconnelly
Reviewers: zundel, Description: Previous change to compiler report formatting switched to NumberFormat to format deciamls, but broke the report's Bytes bar graphs, which were off by a factor of 100 (displaying 0.282% instead of 28.2%). Please review this at