[gwt-contrib] Re: Fixes NPE when JDT doesn't generate a class file. (issue809801)

LGTM http://gwt-code-reviews.appspot.com/809801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right): http://gwt-code-reviews.appspot.com/809801/diff/1/3#newcode212 dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:212: assert enclosingClass != null; Nit: will

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

Why do we no longer visit annotation types? http://gwt-code-reviews.appspot.com/775804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

Ah, ok. My question was not phrased correctly, but I was actually wondering about visiting annotation type *refs*, not the annotation types themselves. My bad. Anyway, thanks for clearing that up. On 2010/08/19 15:46:05, scottb wrote: On Thu, Aug 19, 2010 at 11:41 AM,

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

LGTM http://gwt-code-reviews.appspot.com/775804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Report CompilationState errors deterministically. (issue773802)

LGTM. Is this designed to fix the test broken by issue 756802 (Change to CompilationStateBuilder to prevent recursive invalidation on changed units)? http://gwt-code-reviews.appspot.com/773802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

http://gwt-code-reviews.appspot.com/775804/diff/1/5 File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right): http://gwt-code-reviews.appspot.com/775804/diff/1/5#newcode419 dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:419: TypeRefVisitor apiVisitor = new TypeRefVisitor(cud)

[gwt-contrib] Re: Change to CompilationStateBuilder to prevent recursive invalidation on changed units. (issue756802)

http://gwt-code-reviews.appspot.com/756802/diff/1/8 File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right): http://gwt-code-reviews.appspot.com/756802/diff/1/8#newcode50 dev/core/src/com/google/gwt/dev/javac/Dependencies.java:50: this.myPackage = myPackage + '.'; When the incoming

[gwt-contrib] Re: Change to CompilationStateBuilder to prevent recursive invalidation on changed units. (issue756802)

LGTM. http://gwt-code-reviews.appspot.com/756802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes CompilationUnit.isCompiled(). (issue759801)

LGTM http://gwt-code-reviews.appspot.com/759801/diff/1/9 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (left): http://gwt-code-reviews.appspot.com/759801/diff/1/9#oldcode306 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:306: } Is it worth asserting that

[gwt-contrib] Re: Clean up JdtCompiler by moving out test-only code. (issue731801)

LGTM http://gwt-code-reviews.appspot.com/731801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes the unnecessary ErrorCompilationUnit. (issue730801)

LGTM http://gwt-code-reviews.appspot.com/730801/diff/2001/3003 File dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java (right): http://gwt-code-reviews.appspot.com/730801/diff/2001/3003#newcode74 dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java:74: return hasErrors;

[gwt-contrib] Re: Fixes issue #3708 (issue582801)

LGTM http://gwt-code-reviews.appspot.com/582801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] JreDocTool outputs to file instead of stdout

Reviewers: Dan Rice, Description: JreDocTool generates the JRE emulation reference as an HTML fragment. It currently prints the HTML to stdout; this version writes to a file (specified by -out) instead. Please review this at http://gwt-code-reviews.appspot.com/130816 Affected files:

[gwt-contrib] Update JreDocTool to output EZT

Reviewers: rdayal, Description: Change the output format of the emulated JRE doc generator from wiki to EZT. Please review this at http://gwt-code-reviews.appspot.com/124803 Affected files: build-tools/doctool/src/com/google/doctool/JreDocTool.java

[gwt-contrib] Re: Update JreDocTool to output EZT

On 2009/12/14 20:28:22, rdayal wrote: LGTM. Thanks Rajeev! Committed as r7312. http://gwt-code-reviews.appspot.com/124803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a CssResource interface generator

http://gwt-code-reviews.appspot.com/72808/diff/1/2 File user/src/com/google/gwt/resources/css/InterfaceGenerator.java (right): http://gwt-code-reviews.appspot.com/72808/diff/1/2#newcode202 Line 202: if (!Character.isJavaIdentifierPart(c)) { I recently wrote a very similar method for the plugin,

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

Shouldn't com.google.gwt.resources.ext.DefaultExtensions have been included in this patch? http://gwt-code-reviews.appspot.com/61802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

http://gwt-code-reviews.appspot.com/61802/diff/1011/17 File user/src/com/google/gwt/resources/ext/DefaultExtensions.java (right): http://gwt-code-reviews.appspot.com/61802/diff/1011/17#newcode28 Line 28: * {...@link com.google.gwt.resources.client.ClientBundle.SourceSource} annotation The @link