[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are

[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

On 2013/05/16 19:35:21, mdempsky wrote: Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? Oops, sorry, the link is just https://gwt-review.googlesource.com http://gwt-code-reviews.appspot.com/1832803

[gwt-contrib] Re: corrects typos (issue1902803)

Face palm. Does this break backwards compatibility at all? E.g., are any of the permuation methods user accessible? Do we need to add @Deprecated forwarding methods for them? http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors ---

[gwt-contrib] Re: corrects typos (issue1902803)

On 2013/04/17 23:12:34, mdempsky wrote: Face palm. (And that's at the typos being overlooked for so long, not at the patch!) http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you

[gwt-contrib] Re: Set visibility:hidden on the ruler element in LayoutImpl (issue1851803)

On 2013/04/01 14:36:56, bruno.ferreira wrote: Is this problem solved on GWT 2.5.1? I believe so. This patch was merged and included in GWT 2.5.1. http://gwt-code-reviews.appspot.com/1851803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

LGTM http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right): http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

On 2013/02/28 01:45:15, jtam wrote: Switched to Public. Not sure what you would like me to do in terms of unit tests. This is just exposing an internal which should be already tested. I think just adding appropriate asserts for isRunning()'s return value to AnimationTest would be sufficient.

[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)

On 2013/01/29 22:54:41, goktug wrote: Can you add a test case? It looks like that line is not covered in any test cases. I think it should be covered by JsonUtilTest.java already, but it looks like we don't actually test that in production mode. Also, I think we don't run the elemental test

[gwt-contrib] Fix for typo in JsJsonString (issue1802804)

LGTM http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails

[gwt-contrib] Re: Issue 7112 (issue1649803)

On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode, and

[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)

http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):

[gwt-contrib] Re: GWT does not normalize IE mangling from http 204 code to 1223 (Issue 5031) (issue1875803)

Thanks for the patch. If you don't mind, could you try uploading the next revision to Gerrit insead? See instructions at: https://groups.google.com/d/msg/google-web-toolkit-contributors/fmHDlsnfdEQ/fc6lvNdxROQJ If that proves to be too much work though, you can continue using Rietveld.

[gwt-contrib] Re: GWT does not normalize IE mangling from http 204 code to 1223 (Issue 5031) (issue1875803)

http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml File user/src/com/google/gwt/http/HTTP.gwt.xml (right): http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31

[gwt-contrib] Re: Update devmode Firefox plugin to support Firefox 17 on the Mac: (issue1872803)

LGTM http://gwt-code-reviews.appspot.com/1872803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Windows DLL for Firefox 17 to dev mode plugin. (issue1871803)

LGTM http://gwt-code-reviews.appspot.com/1871803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update devmode Firefox plugin to support Firefox 17 on 64-bit Linux. (issue1870803)

LGTM http://gwt-code-reviews.appspot.com/1870803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser, (issue1868803)

LGTM http://gwt-code-reviews.appspot.com/1868803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Minor cleanup in SerializableTypeOracleBuilder: (issue1869803)

LGTM too. http://gwt-code-reviews.appspot.com/1869803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java (right):

[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)

LGTM http://gwt-code-reviews.appspot.com/1861804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Thanks minichate! (issue1863803)

LGTM too http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Chrome devmode plugin: recompile Windows DLL to be statically linked. (issue1860803)

LGTM http://gwt-code-reviews.appspot.com/1860803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)

LGTM, nice catch. http://gwt-code-reviews.appspot.com/1861803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

Alternatively, take a look at Patch Set #1, which simply added an extra parameter to exec() to pass in a custom JavaCompiler instance. Would that patch (updated to make the exec() methods public) be preferable? http://gwt-code-reviews.appspot.com/1859803/ --

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)

Reviewers: skybrian, tbroyer, Description: Replace instances of element.setInnerHTML(safeHtml.asString()) with element.setInnerSafeHtml(safeHtml). Please review this at http://gwt-code-reviews.appspot.com/1857803/ Affected files: M

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

LGTM http://gwt-code-reviews.appspot.com/1858803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)

http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile#newcode57 plugins/npapi/Makefile:57: EXTENSION_FILES = *.html *.js *.png *.txt \ Oops, I did want to comment