[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Either way should be fine. We could have a visitor pass after all

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Regarding git procedure, I've already rolled back on google/pu and we

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Oops, that wasn't very clear. Let me try again: If think you're going to

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-10 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Hi, we had a performance regression reported to us so we rolled this CL

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-10 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Huh. I knew this correct way was slower but I'm surprised it actually

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-30 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 8: Code-Review+2 -- To view, visit

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-30 Thread Stephen Haberman
Stephen Haberman has submitted this change and it was merged. Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously,

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-29 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: Interesting, thanks, Roberto, I never would have thought of/found the

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-29 Thread Stephen Haberman
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#5). Change subject: Fix non-final field initializers running before the super cstr.

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-29 Thread Stephen Haberman
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#7). Change subject: Fix non-final field initializers running before the super cstr.

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-29 Thread Stephen Haberman
Hello Ray Cromwell, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3030 to look at the new patch set (#8). Change subject: Fix non-final field initializers running before the super cstr.

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-29 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 8: Okay, I believe this is correct now. CompilerTest all passes. I had not

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Stephen Haberman
Stephen Haberman has uploaded a new change for review. https://gwt-review.googlesource.com/3030 Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 1: (1 comment) Commit

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Stephen Haberman
Stephen Haberman has uploaded a new patch set (#2). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 1: (1 comment) Commit

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Stephen Haberman
Stephen Haberman has uploaded a new patch set (#3). Change subject: Fix non-final field initializers running before the super cstr. .. Fix non-final field initializers running before the super cstr. Previously, any field

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 3: Is it possible to write a regression test for this too? -- To view, visit

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Ray Cromwell
Ray Cromwell has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 3: Code-Review+1 It would be nice to have a GWTTestCase (to be run in web-mode)

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: Okay, I added a test in CompilerTest--I had went looking for where to put

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-05-28 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 4: I'll take a look. -- To view, visit