Roberto Lublinerman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Either way should be fine. We could have a visitor pass after all
Brian Slesinsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Regarding git procedure, I've already rolled back on google/pu and we
Brian Slesinsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Oops, that wasn't very clear. Let me try again:
If think you're going to
Brian Slesinsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Hi, we had a performance regression reported to us so we rolled this CL
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 9:
Huh. I knew this correct way was slower but I'm surprised it actually
Roberto Lublinerman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 8: Code-Review+2
--
To view, visit
Stephen Haberman has submitted this change and it was merged.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Fix non-final field initializers running before the super cstr.
Previously,
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 4:
Interesting, thanks, Roberto, I never would have thought of/found the
Hello Ray Cromwell, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3030
to look at the new patch set (#5).
Change subject: Fix non-final field initializers running before the super
cstr.
Hello Ray Cromwell, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3030
to look at the new patch set (#7).
Change subject: Fix non-final field initializers running before the super
cstr.
Hello Ray Cromwell, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3030
to look at the new patch set (#8).
Change subject: Fix non-final field initializers running before the super
cstr.
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 8:
Okay, I believe this is correct now. CompilerTest all passes. I had not
Stephen Haberman has uploaded a new change for review.
https://gwt-review.googlesource.com/3030
Change subject: Fix non-final field initializers running before the super
cstr.
..
Fix non-final field initializers running
Matthew Dempsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 1:
(1 comment)
Commit
Stephen Haberman has uploaded a new patch set (#2).
Change subject: Fix non-final field initializers running before the super
cstr.
..
Fix non-final field initializers running before the super cstr.
Previously, any field
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 1:
(1 comment)
Commit
Stephen Haberman has uploaded a new patch set (#3).
Change subject: Fix non-final field initializers running before the super
cstr.
..
Fix non-final field initializers running before the super cstr.
Previously, any field
Matthew Dempsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 3:
Is it possible to write a regression test for this too?
--
To view, visit
Ray Cromwell has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 3: Code-Review+1
It would be nice to have a GWTTestCase (to be run in web-mode)
Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 4:
Okay, I added a test in CompilerTest--I had went looking for where to put
Roberto Lublinerman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
..
Patch Set 4:
I'll take a look.
--
To view, visit
21 matches
Mail list logo