I have tacitly presumed that a LGTM from the reviewers is kinda mandatory
for a commit to be made. However, I have just noticed a commit made today
without a explicit LGTM.
http://code.google.com/p/google-web-toolkit/source/detail?r=10780
http://gwt-code-reviews.appspot.com/1506802
--
On Wed, Dec 7, 2011 at 3:58 PM, karthik reddy karthik.ele...@gmail.comwrote:
I have tacitly presumed that a LGTM from the reviewers is kinda
mandatory for a commit to be made. However, I have just noticed a commit
made today without a explicit LGTM.
Since GWT code is committed to an
I see. Thanks for clarifying, John.
--
Karthik Reddy
https://plus.google.com/103243388366746199136
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Note also that sometimes we have to rollback or patch something in an
emergency that has broken important internal apps, so we will often
rollback or quickfix these without the regular delay of going through
the public issue tracker, but hopefully these are rare instances.
-Ray
On Wed, Dec 7,
