Sorry, this was shipped in GWT 2.4 without such a check, and such a check
would be inappropriate if the script were some sort of dynamically generated
content using a constant URL. If someone were to want to add such a check,
I'd suggest that it be added as a builder option.
On Thu, Sep 8, 2011
Updated documentation.
http://gwt-code-reviews.appspot.com/1451818/diff/9016/user/test/com/google/gwt/core/CoreSuite.java
File user/test/com/google/gwt/core/CoreSuite.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/9016/user/test/com/google/gwt/core/CoreSuite.java#newcode28
On 2011/06/27 19:25:36, zundel wrote:
Updated documentation.
http://gwt-code-reviews.appspot.com/1451818/diff/9016/user/test/com/google/gwt/core/CoreSuite.java
File user/test/com/google/gwt/core/CoreSuite.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The onerror mechanism is kind of new, so it isn't supported in older
browsers like safari 3. The workarounds suggested all require checking
something expected in the script, and
this is meant to be more general purpose.
on Windows, onFail never returns. in Safari 3, the onload
callback is
http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
Full review this time.
http://gwt-code-reviews.appspot.com/1451818/diff/10011/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated patch.
http://gwt-code-reviews.appspot.com/1451818/diff/10011/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/10011/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
Clicked through @googledevtools' tweet and found this nit reading the
javadoc.
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated patch with suggestions.
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
28 matches
Mail list logo
