[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-03 Thread Uwe Maurer
I submitted this patch: http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1553 Uwe On Mar 2, 3:14 pm, Emily Crutcher e...@google.com wrote: LGTM On Mon, Mar 2, 2009 at 7:49 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I moved the SliderBar to

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
Hi Emily, thanks for code review. On Fri, Feb 27, 2009 at 5:13 PM, Emily Crutcher e...@google.com wrote: The changes look great. Thank you for doing this. Any chance you could you create a gen2 version of SliderBar and deprecate the widgetideas version instead on modifying the widgetideas

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
Hi, I moved the SliderBar to com.google.gwt.gen2.picker.client package, and the demo to the corresponding package. I added methods to use the new event handling to the Slider Bar, and removed the old event methods. I added style injection via Gen2CssInjector. (and added the images and css to

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Emily Crutcher
LGTM On Mon, Mar 2, 2009 at 7:49 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I moved the SliderBar to com.google.gwt.gen2.picker.client package, and the demo to the corresponding package. I added methods to use the new event handling to the Slider Bar, and removed the old event

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-02-27 Thread Emily Crutcher
The changes look great. Thank you for doing this. Any chance you could you create a gen2 version of SliderBar and deprecate the widgetideas version instead on modifying the widgetideas version in place? We are slowly retiring the old widgetideas package in favor of the gen2 package hierarchy, so