[gwt-contrib] Re: CompiledClasses now compute anonymous class status from JDT.

2009-11-03 Thread amitmanjhi
As mentioned in the detailed comments, because more classes will pass the isAnonymous() filter, the matching algorithm will break. Perhaps isAnonymous() can be renamed to isLocal() (since that is exactly what is being computed). isAnonymous() can then be isLocal()

[gwt-contrib] Re: CompiledClasses now compute anonymous class status from JDT.

2009-11-03 Thread scottb
BTW: the main thing I wanted to ask was if this will impact your CCL code in any way. John T was nervous about me removing the call to isClassnameGenerated() when making the anonymous class determination. http://gwt-code-reviews.appspot.com/89817/diff/1/3 File

[gwt-contrib] Re: CompiledClasses now compute anonymous class status from JDT.

2009-11-03 Thread amitmanjhi
http://gwt-code-reviews.appspot.com/89817/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right): http://gwt-code-reviews.appspot.com/89817/diff/1/3#newcode80 Line 80: boolean anonymous = false; a small nit: perhaps move this to a separate method? as in this.anonymous =