[gwt-contrib] Re: Fixes two issues (issue1181802)

2010-12-02 Thread rchandia
This is actually a repost of tboryer's patch originally submitted at: http://gwt-code-reviews.appspot.com/1181802 On 2010/12/02 22:33:23, rchandia wrote: http://gwt-code-reviews.appspot.com/1181802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes two issues (issue1181802)

2010-12-02 Thread Chris Conroy
that's a link to this review :P On Thu, Dec 2, 2010 at 5:39 PM, rchan...@google.com wrote: This is actually a repost of tboryer's patch originally submitted at: http://gwt-code-reviews.appspot.com/1181802 On 2010/12/02 22:33:23, rchandia wrote:

[gwt-contrib] Re: Fixes two issues (issue1181802)

2010-12-02 Thread Rodrigo Chandia
Gah! I meant: http://gwt-code-reviews.appspot.com/1170801 El 2 de diciembre de 2010 17:40, Chris Conroy con...@google.com escribió: that's a link to this review :P On Thu, Dec 2, 2010 at 5:39 PM, rchan...@google.com wrote: This is actually a repost of tboryer's patch originally submitted

[gwt-contrib] Re: Fixes two issues (issue1181802)

2010-12-02 Thread conroy
LGTM looks like this crept in in the massive r8946. In addition to being moved, the parse method was changed from public Double parse(CharSequence object) throws ParseException { -try { - return Double.valueOf(object.toString()); -} catch (NumberFormatException e) { - throw

[gwt-contrib] Re: Fixes two issues (issue1181802)

2010-12-02 Thread Ray Ryan
LGTM @conroy, yup, that change to use NumberFormat was intentional. The rint(), not so much. On Thu, Dec 2, 2010 at 2:50 PM, con...@google.com wrote: LGTM looks like this crept in in the massive r8946. In addition to being moved, the parse method was changed from public Double