Or CloudTasks.
@rchandia - please hold off on any big refactor until I get my changes
in. I'll try to send them for review today.
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No problem.
On Fri, Apr 22, 2011 at 8:20 AM, jlaba...@google.com wrote:
Or CloudTasks.
@rchandia - please hold off on any big refactor until I get my changes
in. I'll try to send them for review today.
http://gwt-code-reviews.appspot.com/1427803/
--
I'm getting up to my elbows in there too, trying to narrow the exposure of
ClientFactory. John, are there particular spots I should avoid?
On Fri, Apr 22, 2011 at 5:27 AM, Rodrigo Chandia rchan...@google.comwrote:
No problem.
On Fri, Apr 22, 2011 at 8:20 AM, jlaba...@google.com wrote:
Or
+1 on CloudTasks, I'll defer the CL 'til John finishes so that the merge
onus is on me.
On Fri, Apr 22, 2011 at 12:03 PM, Ray Ryan rj...@google.com wrote:
I'm getting up to my elbows in there too, trying to narrow the exposure of
ClientFactory. John, are there particular spots I should avoid?
I forgot to check during the review, but we usually put the .project,
.classpath, .checkstyle, .settings, and war directory in
trunk/eclipse/samples/MobileWebApp
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yes, I'll make a patch with those files. I held on that until I could test
GPE with the fix for the validation jars
On Thu, Apr 21, 2011 at 1:42 PM, jlaba...@google.com wrote:
I forgot to check during the review, but we usually put the .project,
.classpath, .checkstyle, .settings, and war
I just realized that I don't like the name of this sample. It's not just
about being a mobile app. It's about being a well architected one, which
provides both a mobile and desktop UI.
Shall we call it tasks instead?
http://gwt-code-reviews.appspot.com/1427803/
--
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I just realized all files are missing Google headers and other
checkstyle issues, please wait on the review.
On 2011/04/20 14:54:32, rchandia wrote:
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1427803/diff/4001/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/1427803/diff/4001/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as of r10041
http://gwt-code-reviews.appspot.com/1427803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Sorry for the belated review. This is a great sample, we'll get a lot of
mileage out of it.
My only complaint is that the clientFactory has too many getters and is
passed around too much. I'll take a crack at fixing that myself.
The app also doesn't use the Editor framework like it
If Rodrigo has time to add Editors, its likely to get done sooner than I
can get to it.
As far as ClientFactory, should we consider using gin?
On 2011/04/20 21:51:42, rjrjr wrote:
LGTM
Sorry for the belated review. This is a great sample, we'll get a lot
of mileage
out of it.
My only
Re: gin, the dependencies will be too complicated for a sample. And this is
simple enough that we can just do what gin would have done by hand, makes it
a better illustration really.
On Wed, Apr 20, 2011 at 3:03 PM, jlaba...@google.com wrote:
If Rodrigo has time to add Editors, its likely to
18 matches
Mail list logo
