Very nice, as always.
http://gwt-code-reviews.appspot.com/1233803/diff/1/3
File user/src/com/google/gwt/uibinder/elementparsers/TreeItemParser.java
(right):
http://gwt-code-reviews.appspot.com/1233803/diff/1/3#newcode39
user/src/com/google/gwt/uibinder/elementparsers/TreeItemParser.java:39:
Taking this a bit further, if we're going to be playing with interfaces we
might as well go the whole nine yards:
interface IsTreeItem {
TreeItem asTreeItem();
}
interface HasTreeItems {
void addItem(IsTreeItem);
void addItem(Widget);
void addItem(SafeHtml);
/* No addItem(String),
On Wed, Jan 5, 2011 at 12:47 PM, Ray Ryan rj...@google.com wrote:
Taking this a bit further, if we're going to be playing with interfaces we
might as well go the whole nine yards:
interface IsTreeItem {
TreeItem asTreeItem();
}
interface HasTreeItems {
void addItem(IsTreeItem);
There is an existing overload that accepts a string and interprets it as
HTML, so that's not an option. And asking Konstantin to add a new
addItemText(String) method seems too far outside the scope of this patch.
On Wed, Jan 5, 2011 at 10:02 AM, John Tamplin j...@google.com wrote:
On Wed, Jan
On Wed, Jan 5, 2011 at 1:09 PM, Ray Ryan rj...@google.com wrote:
There is an existing overload that accepts a string and interprets it as
HTML, so that's not an option. And asking Konstantin to add a new
addItemText(String) method seems too far outside the scope of this patch.
Ok, we can
