[gwt-contrib] Re: Request for smoke testers for 1.5.3

2008-10-17 Thread Amit Manjhi
My mistake. I corrected it to r3751 in the comments. Thanks Fred! 1. Comment #6 in issue 2950 (Time.valueOf fails with 08 and 09 numbers) refers to r3743 which is the wrong commit for this issue Fred Sauer [EMAIL PROTECTED] On Thu, Oct 16, 2008 at 7:39 PM, Ray Ryan [EMAIL

[gwt-contrib] Re: Request for smoke testers for 1.5.3

2008-10-17 Thread Fred Sauer
Thanks Amit, How about an issue for the getAbsoluteTop()/Left() change? That's a significant change and deserves and issue for future reference. Fred Sauer [EMAIL PROTECTED] On Fri, Oct 17, 2008 at 7:54 AM, Amit Manjhi [EMAIL PROTECTED] wrote: My mistake. I corrected it to r3751 in the

[gwt-contrib] Code Review: gwt-google-apis maps Formatting and comment cleanup

2008-10-17 Thread Eric Ayers
Hello Miguel, Would you mind reviewing the attached patch? It only changes comments and formatting. The API suffered through a long bout of build breakage. While debugging it, I ran across some comments that were not at all clear in the Maps Test. relative to releases/maps/1.0 branch in

[gwt-contrib] review request: JUnit hang

2008-10-17 Thread Freeland Abbott
I recently tracked down a problem where a colleague got JUnit to hang indefinitely with a bad GWTTestCase. The attached patch aims at closing the front door problem; he had done: TestSuite.addTest(new MyGwtTestCase()) instead of TestSuite.addTestSuite(MyGwtTestCase.class); and, while the

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Bruce Johnson
sorry for the useless spammy reply, but I can help it: this is super exciting On Fri, Oct 17, 2008 at 12:24 PM, Lex Spoon [EMAIL PROTECTED] wrote: Hi, Bob, Can you be the main reviewer for the merge of the runAsync branch to the trunk? The attached patch is the outstanding difference

[gwt-contrib] [google-web-toolkit commit] r3778 - tools/lib/jetty

2008-10-17 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 17 10:20:32 2008 New Revision: 3778 Added: tools/lib/jetty/ tools/lib/jetty/jetty-6.1.11-src.zip (contents, props changed) tools/lib/jetty/jetty-6.1.11.jar (contents, props changed) Log: Adding Jetty 6.1.11 to tools. Added:

[gwt-contrib] Code Review: gwt-google-apis gears WorkerPoolDemo UI cleanups

2008-10-17 Thread Eric Ayers
This patch cleans up the UI a bit for the worker pool demo. I struggled a but getting the animation to look roughly centered in the vertical panel - in the end I punted and used an AbsolutePanel. M samples/workerpool/src/com/google/gwt/gears/sample/workerpool/client/WorkerPoolDemo.java M

[gwt-contrib] review request: JUnit hang back door closing

2008-10-17 Thread Freeland Abbott
Scott, can you review-or-delegate both this and my earlier review request: JUnit hang I just sent a patch up to block sending a bad Test to the client (i.e. to fail early if the test is unnamed), but that led me to thinking about the more general how-not-to-hang-on-unspecified-error case. We send

[gwt-contrib] [google-web-toolkit commit] r3779 - in releases/1.6/eclipse/samples/DynaTable2: . war/WEB-INF

2008-10-17 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Fri Oct 17 10:59:28 2008 New Revision: 3779 Removed: releases/1.6/eclipse/samples/DynaTable2/jetty-6.1.11.jar Modified: releases/1.6/eclipse/samples/DynaTable2/DynaTable2 compile.launch releases/1.6/eclipse/samples/DynaTable2/DynaTable2 server.launch

[gwt-contrib] Re: Request for smoke testers for 1.5.3

2008-10-17 Thread Ray Ryan
John Tamplin just created issue 2996 for it. Thanks again, Fred. rjrjr On Fri, Oct 17, 2008 at 7:20 AM, Fred Sauer [EMAIL PROTECTED] wrote: Thanks Amit, How about an issue for the getAbsoluteTop()/Left() change? That's a significant change and deserves and issue for future reference. Fred

[gwt-contrib] Re: Code Review: gwt-google-apis gears WorkerPoolDemo UI cleanups

2008-10-17 Thread Alex Rudnick
LGTM. (also: that's a pretty cool demo!) On Fri, Oct 17, 2008 at 1:45 PM, Eric Ayers [EMAIL PROTECTED] wrote: This patch cleans up the UI a bit for the worker pool demo. I struggled a but getting the animation to look roughly centered in the vertical panel - in the end I punted and used an

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Ray Cromwell
I'm super excited about this too, as well as a merge of OOPHM to trunk :) Comment below: On Fri, Oct 17, 2008 at 9:24 AM, Lex Spoon [EMAIL PROTECTED] wrote: 2. The linkers are updated for this structure, though most of them simply fail if there is more than one fragment. This is of great

[gwt-contrib] punch list for getting OOPHM merged into trunk

2008-10-17 Thread John Tamplin
I think it is time to decide on the criteria for when OOPHM should get merged to trunk so we can be working down that list. Since we forked 1.6 and the trunk is available for 2.0 stuff, I think the criteria should be when developers working from trunk can switch to OOPHM with minimal disruption.

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Lex Spoon
On Fri, Oct 17, 2008 at 3:46 PM, Ray Cromwell [EMAIL PROTECTED] wrote: This is of great concern to me. Is there some fundamental reason why linkers won't work with multiple fragments, or it is just that there was an API change and some of the implementations need to be fixed? For example, I

[gwt-contrib] Announcing GWT 1.5.3

2008-10-17 Thread Ray Ryan
Hi, all. We have just deprecated GWT 1.5.2, and replaced it with GWT 1.5.3. This new release has a small handful of patches, mainly aimed at fixing RPC problems with Android. You can download the update from the usual location: http://code.google.com/webtoolkit/download.html You may find that

[gwt-contrib] Re: punch list for getting OOPHM merged into trunk

2008-10-17 Thread John Tamplin
On Fri, Oct 17, 2008 at 6:47 PM, Ray Cromwell [EMAIL PROTECTED] wrote: For trunk work, I'm personally not too concerned with this. I think people compiling the trunk and living on the bleeding edge won't mind upgrading their Firefox distributions, although I agree it might be an issue when

[gwt-contrib] Re: punch list for getting OOPHM merged into trunk

2008-10-17 Thread John Tamplin
On Fri, Oct 17, 2008 at 10:28 PM, Sam Gross [EMAIL PROTECTED] wrote: I'll take a look at getting the XPCOM plugin to work in FF2/Gecko 1.8 this weekend. I was able to get the Mac version to work in Firefox 2 with relatively few changes, so I hope the same will be true on other platforms.