[gwt-contrib] Re: Issue 4027: TextBox fires JSException in IE on double click (issue151804)

2010-04-07 Thread jlabanca
This patch will be in GWT 2.1. If you compiled it into the GWT 1.7.1 jar and it works, then it should be fine as the change was isolated to that one file. http://gwt-code-reviews.appspot.com/151804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply

[gwt-contrib] Changes CustomizedShell to use the new Table widget. (issue318801)

2010-04-07 Thread jgw
Reviewers: Ray Ryan, Description: Changes CustomizedShell to use the new Table widget. Please review this at http://gwt-code-reviews.appspot.com/318801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/cells/client/DateCell.java M

[gwt-contrib] Re: Changes CustomizedShell to use the new Table widget. (issue318801)

2010-04-07 Thread jgw
http://gwt-code-reviews.appspot.com/318801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using remove me as the subject.

[gwt-contrib] Added method to change the size of a MutableArray. Added factory method to construct a nonempty ... (issue319801)

2010-04-07 Thread rchandia
Reviewers: fabbott, Dan Rice, Description: Added method to change the size of a MutableArray. Added factory method to construct MeutableArray of specific size. These provide a O(n) way to initialize a MutableArray as shown by com.google.gwt.collections.MutableArrayBenchmarkTest Please review

[gwt-contrib] Fix checkstyle sort order. (issue316802)

2010-04-07 Thread rice
Reviewers: rchandia, Description: Fix checkstyle sort order. Review by: rchan...@google.com Please review this at http://gwt-code-reviews.appspot.com/316802/show Affected files: M bikeshed/test/com/google/gwt/collections/ImmutableArrayTest.java Index:

[gwt-contrib] [google-web-toolkit] r7886 committed - Fix checkstyle errors and remove some whitespace.

2010-04-07 Thread codesite-noreply
Revision: 7886 Author: r...@google.com Date: Wed Apr 7 05:28:43 2010 Log: Fix checkstyle errors and remove some whitespace. http://code.google.com/p/google-web-toolkit/source/detail?r=7886 Modified: /trunk/bikeshed/src/com/google/gwt/bikeshed/list/client/IdentityColumn.java

[gwt-contrib] Checkstyle fixes. (issue320801)

2010-04-07 Thread rice
Reviewers: Ray Ryan, Description: Checkstyle fixes. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/320801/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java M

[gwt-contrib] Re: Fix checkstyle sort order. (issue316802)

2010-04-07 Thread rchandia
LGTM Thanks! It seems I need to check my Eclipse Checkstyle setup. http://gwt-code-reviews.appspot.com/316802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added method to change the size of a MutableArray. Added factory method to construct a nonempty ... (issue319801)

2010-04-07 Thread rice
LGTM http://gwt-code-reviews.appspot.com/319801/diff/1/3 File bikeshed/src/com/google/gwt/collections/MutableArray.java (right): http://gwt-code-reviews.appspot.com/319801/diff/1/3#newcode150 bikeshed/src/com/google/gwt/collections/MutableArray.java:150: * truncated. If {...@code newSize} is

[gwt-contrib] [google-web-toolkit] r7887 committed - Changes ListRegistration to carry information about its associated han...

2010-04-07 Thread codesite-noreply
Revision: 7887 Author: gwt.mirror...@gmail.com Date: Wed Apr 7 09:03:27 2010 Log: Changes ListRegistration to carry information about its associated handler and range of interest. This allows ListListModel (and theoretically other models) to call back directly to views whose range of interest

[gwt-contrib] [google-web-toolkit] r7888 committed - Fix checkstyle sort order....

2010-04-07 Thread codesite-noreply
Revision: 7888 Author: r...@google.com Date: Wed Apr 7 06:00:18 2010 Log: Fix checkstyle sort order. Review at http://gwt-code-reviews.appspot.com/316802 Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7888 Modified:

[gwt-contrib] Re: Adds ProvidesKey and makes the ListModel the source of the key (issue307801)

2010-04-07 Thread jlabanca
committed as r7866 http://gwt-code-reviews.appspot.com/307801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using remove me as the subject.

[gwt-contrib] Re: Checkstyle fixes. (issue320801)

2010-04-07 Thread Ray Ryan
Lgtm On Apr 7, 2010 11:36 AM, r...@google.com wrote: Reviewers: Ray Ryan, Description: Checkstyle fixes. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/320801/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java

[gwt-contrib] [google-web-toolkit] r7889 committed - Checkstyle fixes....

2010-04-07 Thread codesite-noreply
Revision: 7889 Author: r...@google.com Date: Wed Apr 7 06:59:56 2010 Log: Checkstyle fixes. Review at http://gwt-code-reviews.appspot.com/320801 http://code.google.com/p/google-web-toolkit/source/detail?r=7889 Modified:

[gwt-contrib] node.getNodeValue() limited in FireFox to 4096 characters. If length is longer it gets truncated. (issue325801)

2010-04-07 Thread markovuksanovic
Reviewers: Ray Ryan, Description: Fix for issue http://code.google.com/p/google-web-toolkit/issues/detail?id=719 Please review this at http://gwt-code-reviews.appspot.com/325801/show Affected files: user/src/com/google/gwt/xml/XML.gwt.xml

[gwt-contrib] [google-web-toolkit] r7890 committed - Clean up mail sample app; simplify table refresh for selection changes...

2010-04-07 Thread codesite-noreply
Revision: 7890 Author: r...@google.com Date: Wed Apr 7 11:20:20 2010 Log: Clean up mail sample app; simplify table refresh for selection changes Review at http://gwt-code-reviews.appspot.com/324801 Review by: j...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7890

[gwt-contrib] Re: Fixes a couple of issues with the RemoteUI and GPE DevMode view interaction. The problem is GPE... (issue323801)

2010-04-07 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using remove me as the subject.

[gwt-contrib] Re: Fixes a couple of issues with the RemoteUI and GPE DevMode view interaction. The problem is GPE... (issue323801)

2010-04-07 Thread jat
LGTM http://gwt-code-reviews.appspot.com/323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7891 committed - Rename libraries to all-lowercase.

2010-04-07 Thread codesite-noreply
Revision: 7891 Author: j...@google.com Date: Wed Apr 7 17:19:42 2010 Log: Rename libraries to all-lowercase. http://code.google.com/p/google-web-toolkit/source/detail?r=7891 Added: /changes/jat/csproto/jni/linux/prebuilt/libshmfutex_linux_x86.so

[gwt-contrib] Makes the various views a bit more modular, isolating them from the (issue328801)

2010-04-07 Thread rjrjr
Reviewers: amitmanjhi, Description: Makes the various views a bit more modular, isolating them from the entry point and paving the way to give them more real implementations. Extracts ValuesListView interface from the ValuesListViewTable widget. Also extracts the requests that populate them out