[gwt-contrib] Re: Allows Linkers to mark themselves as shardable by including a (issue678802)

close me http://gwt-code-reviews.appspot.com/678802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Faster edit-distance computation in JsFunctionClusterer (issue669801)

Hi Andre, I'm waiting on Ray C or Lex to give the LGTM, but I noticed this last patch you uploaded left out the editdistance library files. On Mon, Aug 9, 2010 at 4:48 PM, avassalo...@google.com wrote: http://gwt-code-reviews.appspot.com/669801/diff/33001/34006 File

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

http://gwt-code-reviews.appspot.com/717801/diff/20002/33060 File user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java (right): http://gwt-code-reviews.appspot.com/717801/diff/20002/33060#newcode54 user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java:54: public ProxyListPlace

Re: [gwt-contrib] RR: What if UiBinder could take a factory?

Hey Ray, Thanks for trying to make GIN user's lives easier when using UiBinder. However, injecting an injector wouldn't really work. Most GIN applications will end up having one top level Ginjector that would have a getter for some top level application widget. When you start creating multiple

Re: [google-gin] Re: [gwt-contrib] RR: What if UiBinder could take a factory?

Hi all, this topic comes up so often that we should really find a solution. :) The short story is that we might need to fix this issue but could potentially work without it: http://code.google.com/p/google-gin/issues/detail?id=95(Allow classes created by a Generator to participate in dependency

Re: [google-gin] Re: [gwt-contrib] RR: What if UiBinder could take a factory?

If you inject your ginjector somewhere in its own dependency tree, it will inject itself, i.e. it is automatically bound as a singleton. Does this work if you have multiple Ginjectors? What I've done before was to have a hierarchy of Ginjectors and the top level one would be what gets

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

On Tue, Aug 10, 2010 at 6:40 AM, jlaba...@google.com wrote: http://gwt-code-reviews.appspot.com/717801/diff/20002/33060 File user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java (right): http://gwt-code-reviews.appspot.com/717801/diff/20002/33060#newcode54

Re: [gwt-contrib] devmode classloader retention

Thanks so much for digging into this, Stephen. @John, Bob, Ray: can you guys take a look at this and maybe create yourselves issues? It seems like this is a real performance issue, with the user ending up in sluggish performance or else having to restart DevMode, which is certainly slower than

[gwt-contrib] Re: Better error message on garbage in text. (issue748801)

http://gwt-code-reviews.appspot.com/748801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [google-gin] Re: [gwt-contrib] RR: What if UiBinder could take a factory?

On Tue, Aug 10, 2010 at 9:04 AM, Peter Schmitt ara...@gmail.com wrote: Hi all, this topic comes up so often that we should really find a solution. :) The short story is that we might need to fix this issue but could potentially work without it:

[gwt-contrib] [google-web-toolkit] r8510 committed - Recommiting the new CrossSiteIframeLinker....

Revision: 8510 Author: sp...@google.com Date: Tue Aug 10 07:06:57 2010 Log: Recommiting the new CrossSiteIframeLinker. This linker works cross-site, because it uses a script tag to download code instead of XHR. However, like the iframe linker, it still uses an iframe to hold all the installed

[gwt-contrib] PUBLIC: Fix compile errors in user/build.xml compile.tests target. (issue749801)

Reviewers: Ray Ryan, Description: PUBLIC: Fix compile errors in user/build.xml compile.tests target. Please review this at http://gwt-code-reviews.appspot.com/749801/show Affected files: M user/build.xml Index: user/build.xml

[gwt-contrib] Re: PUBLIC: Fix compile errors in user/build.xml compile.tests target. (issue749801)

LGTM http://gwt-code-reviews.appspot.com/749801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [google-gin] Re: [gwt-contrib] RR: What if UiBinder could take a factory?

I think the scheme I sketched gets around this issue. Gin isn't aware of any of the generated code. Rather, the generated code is aware of the public Ginjector interface. When Gin is asked to inject a MyUiBinder, it's just going to write GWT.create(MyUiBinder), and then call that instance's

[gwt-contrib] Re: Replacing ListView with HasData and HasRows (issue723801)

committed as r8511 http://gwt-code-reviews.appspot.com/723801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replacing ListView with HasData and HasRows (issue745801)

committed as r8511 http://gwt-code-reviews.appspot.com/745801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

Comment by natewingone: @br...@google.com: It's not just mobile apps that want every byte to count. If you use GWT to enhance a largely static website, and the website must be fast to load for new users, you have to make sure javascript is as small as possible. For comparison the current

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

Q: Can Object.typeId be gotten rid of? If not, what else is it being used for? http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8513 committed - Better error message on garbage in text....

Revision: 8513 Author: gwt.mirror...@gmail.com Date: Tue Aug 10 08:37:35 2010 Log: Better error message on garbage in text. Review at http://gwt-code-reviews.appspot.com/748801 Review by: cheng...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8513 Modified:

[gwt-contrib] Generating Image with Generator

Hello, I'm trying to generate a bunch of ClientBundles with the associated images in the same directory. I can't figure out how to write the image files to the same directory as the java files generated with GeneratorContext.tryCreate(...). I also tried using GeneratorContext.tryCreateResource

[gwt-contrib] Why is JClassType#getAnnotations() not public?

Hi, In one of my generator I would need to scan the list of all annotations in order to find one that is marked with another annotation. Unfortunately, there doesn't seem to be any public mechanism in JClassType to access the list of all annotations. Looking at the class I see: getAnnotations()

[gwt-contrib] Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

Reviewers: scottb, robertvawter, cromwellian, Description: Removed use of a global table (typeIdArray) for testing castability between types. This information is now stored per class prototype as a castableMap. Please review this at http://gwt-code-reviews.appspot.com/750801/show Affected

[gwt-contrib] Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

Reviewers: knorton, Description: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. Please review this at http://gwt-code-reviews.appspot.com/738801/show Affected files: M user/src/com/google/gwt/user/client/ui/ValueBoxBase.java Index:

[gwt-contrib] Add the ability to change the size of a widget in the (issue719802)

Reviewers: jgw, Description: Add the ability to change the size of a widget in the DockLayoutPanel after it has already been added. Please review this at http://gwt-code-reviews.appspot.com/719802/show Affected files: M user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java Index:

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

On Mon, Aug 2, 2010 at 2:14 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/719802/diff/1/2 File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/719802/diff/1/2#newcode315

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

http://gwt-code-reviews.appspot.com/738801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] GWT-RPC generic object serialization...

It seems that the issue of generic Object serialization comes up a lot in the arena of GWT-RPC, but good solutions seem to be far more elusive than the postings of the problem. The most relevant proposed solution that I found came from Scott Blum (

[gwt-contrib] Re: Faster edit-distance computation in JsFunctionClusterer (issue669801)

http://gwt-code-reviews.appspot.com/669801/diff/33001/34006 File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java (right): http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43 dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

Scott, I'm working on getting rid of it now (I'll create a different bug issue). My quick and dirty attempt to get rid of it had a few issues, so I decided to release the main typeIdArray change first. Yes, I agree, it should be able to be gotten rid of, since it's main purpose was indeed to be

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

http://gwt-code-reviews.appspot.com/738801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Problem in Large scale application development and MVP

I recently tried to follow the Large scale application development and MVP tutorial. The tutorial was great but I am having a hard time with a few things. If you try and add a contact to the list, the contact is created. If you try and add another contact, you are taken to the edit screen of

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

http://gwt-code-reviews.appspot.com/719802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Thoughts on GWT-RPC generic object serialization

It seems that the issue of having a mechanism for generic GWT-RPC object serialization comes up frequently. While the motivation by the developer for being able to do this in their code varies, the end result is generally the same: a reference explicitly or implicitly is made for GWT to serialize

Re: [gwt-contrib] Why is JClassType#getAnnotations() not public?

On Sun, Aug 8, 2010 at 3:57 PM, PhilBeaudoin philippe.beaud...@gmail.comwrote: In one of my generator I would need to scan the list of all annotations in order to find one that is marked with another annotation. Unfortunately, there doesn't seem to be any public mechanism in JClassType to

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

Committed in r8509 http://code.google.com/p/google-web-toolkit/source/detail?r=8509 http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Allow RPC stats system extensions (issue751801)

Reviewers: Dan Rice, scottb, Lex, Description: This patch allows for the extension of the RPC stats system by moving the stats methods into an object, making them non-static. This would allow application developers to extend the ProxyCreator to use a different implementation of the stats

[gwt-contrib] When dev mode fails to load a module, update the $wnd.title with a summary of the (issue750802)

Reviewers: scottb, Description: When dev mode fails to load a module, update the $wnd.title with a summary of the error, so that the error can be seen even when the browser is minimized in task bar. This can be useful when developing by keeping all windows full-screen, i.e. it can save the

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

Did I already mention how awesome it is that you fixed this? awesome! /kelly On Tue, Aug 10, 2010 at 5:05 PM, fre...@google.com wrote: Committed in r8509 http://code.google.com/p/google-web-toolkit/source/detail?r=8509 http://gwt-code-reviews.appspot.com/730802/show -- If you

[gwt-contrib] Re: When dev mode fails to load a module, update the $wnd.title with a summary of the (issue750802)

LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on CssResource in google-web-toolkit

Comment by ehboto: It would be useful to allow usage of the @media rule in the resource's css file: http://www.w3.org/TR/CSS2/media.html#at-media-rule That way making widgets that work both on the screen and when printed wouldn't require any wacky workarounds. (btw there's already an

[gwt-contrib] For synthetic this refs, use params rather than fields while in constructors (issue752801)

Reviewers: tobyr, Please review this at http://gwt-code-reviews.appspot.com/752801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JField.java M dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java --

Re: [google-gin] Re: [gwt-contrib] RR: What if UiBinder could take a factory?

On Tue, Aug 10, 2010 at 11:01 AM, Peter Schmitt ara...@gmail.com wrote: I think the scheme I sketched gets around this issue. Gin isn't aware of any of the generated code. Rather, the generated code is aware of the public Ginjector interface. When Gin is asked to inject a MyUiBinder, it's just

[gwt-contrib] Re: Add Mnemonics/Shortcuts for frequently used buttons on the Dev Shell (Swing UI) (issue708801)

What's about a commit to the main trunk? The patch still hasn't been applied although it's been accepted: http://code.google.com/p/google-web-toolkit/issues/detail?id=5150 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

Reviewers: cromwellian, Ray Ryan, robertvawter, Description: Enables setter methods to be directly called on Record/proxy objects, instead of going through a DeltaValueStore. Also removes the now unnecessary DeltaValueStore from the public api. Patch by: amitmanjhi Review by: rjrjr,

[gwt-contrib] Re: Annotate the SpeedTracer log data with some extra info. (issue753801)

http://gwt-code-reviews.appspot.com/753801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompilationState.java (right): http://gwt-code-reviews.appspot.com/753801/diff/1/3#newcode93 dev/core/src/com/google/gwt/dev/javac/CompilationState.java:93: generatedUnitsAddEvent.addData(# new

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8515 committed - PUBLIC: Fix compile errors in user/build.xml compile.tests target....

Revision: 8515 Author: gwt.mirror...@gmail.com Date: Tue Aug 10 20:34:17 2010 Log: PUBLIC: Fix compile errors in user/build.xml compile.tests target. Review at http://gwt-code-reviews.appspot.com/749801 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8515

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables setter methods to be directly called on Record/proxy objects, instead of going through a... (issue752802)

http://gwt-code-reviews.appspot.com/752802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

I have a working version now that removes the use of the typeId, that's passing our tests. I will clean it up and submit it as a separate patch tomorrow(unless you think it's worth adding to this one?) Jason http://gwt-code-reviews.appspot.com/750801/show --