Revision: 8965
Author: b...@google.com
Date: Wed Oct 6 10:46:19 2010
Log: Resolves ROO-1508 by requiring CompositeEditors to return a canonical
component Editor instance for path traversal.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/965801
That sounds reasonable. We should either have a boolean to refresh the
headers, or just refresh them all the time. Please open an issue in
jira and assign it to me.
Awesome. I opened the issue, though it looks like I don't have rights to
assign it over to you:
In Panel:
@Override
protected void onLoad() {
}
No `super.onLoad()` means attach events don't fire for panels. I assume
this was not intended?
Given my last ping garnered a response, can I also open an issue in
roo's jira for this?
The AttachEvent is very handy, just seems
Revision: 8966
Author: r...@google.com
Date: Wed Oct 6 11:53:24 2010
Log: Clean up Cell-related javadoc
Review at http://gwt-code-reviews.appspot.com/966801
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8966
Modified:
Revision: 8967
Author: con...@google.com
Date: Thu Oct 7 04:47:10 2010
Log: Rolling back r8960 because of ant build issues
*** Original change description ***
Create the list of packages to javadoc dynamically
Link out to JSON and JSR 303 javadoc on the Web
Review at
Thank you, my editor works now, and on the first try too, I have a
very complex object graph and it just handles' it. GWT has never
been so good.
On Thu, Oct 7, 2010 at 10:52 AM, codesite-nore...@google.com wrote:
Revision: 8965
Author: b...@google.com
Date: Wed Oct 6 10:46:19 2010
Log:
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I believe it should be Returns instead of Return. That is, the
recommended practice is to use 3rd person for method descriptions.
http://gwt-code-reviews.appspot.com/967801/diff/1/3
File
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstantsAnnot.java
(right):
Reviewers: bobv,
Description:
Public: Use a seperate sample.extraclasspath so each sample can specify
their own jars.
Review by: b...@google.com
Please review this at http://gwt-code-reviews.appspot.com/969801/show
Affected files:
M common.ant.xml
M samples/common.ant.xml
M
[+jlabanca]
John is working on a related packaging problem. It seems like this
would dovetail.
On Thu, Oct 7, 2010 at 10:11 AM, ncha...@google.com wrote:
Reviewers: bobv,
Description:
Public: Use a seperate sample.extraclasspath so each sample can specify
their own jars.
Review by:
LGTM
http://gwt-code-reviews.appspot.com/969801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8968
Author: r...@google.com
Date: Wed Oct 6 14:58:29 2010
Log: Cherrypick Cell javadoc fixes into 2.1 branch
g4 integrate @=17576594
g4 integrate @=17577421
g4 integrate @=17579355
http://code.google.com/p/google-web-toolkit/source/detail?r=8968
Modified:
Revision: 8969
Author: ncha...@google.com
Date: Thu Oct 7 07:43:12 2010
Log: Public: Use a seperate sample.extraclasspath so each sample can
specify their own jars.
Review at http://gwt-code-reviews.appspot.com/969801
Review by: b...@google.com
Revision: 8970
Author: unn...@google.com
Date: Thu Oct 7 08:07:05 2010
Log: Remove JSON dependency from log sample and other users that don't use
json
http://code.google.com/p/google-web-toolkit/source/detail?r=8970
Modified:
Hi Bob,
If you're interested in more use cases for the editor framework,
here's another one for you...
The problem is actually pretty common, the idea is that if you want to
create, or layout, an object in the hierarchy where it technically
isn't, you can't. This happens quite a bit, and when
Reviewers: robertvawter,
Description:
Fixing LogExample and DynaTableRf for distro builds. The samples were
being compiled, but they weren't included in the eclipse.generate
target. We also now include json.jar and validation-api-1.0.0.GA.jar in
gwt-servlet.jar. And for DynaTableRf (and
Hello Google Plugin for Eclipse users,
According to our usage statistics, less than 2% of our user base uses
Eclipse 3.3 with the Google Plugin for Eclipse. Supporting Eclipse 3.3
limits the set of features offered by Eclipse that we can leverage and
increases our maintenance burden. So, we have
http://gwt-code-reviews.appspot.com/964802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/964802/diff/1/4
File samples/dynatable/build.xml (right):
http://gwt-code-reviews.appspot.com/964802/diff/1/4#newcode10
samples/dynatable/build.xml:10: fileset id=sample.server.libs
dir=${gwt.tools.lib}
On 2010/10/07 19:56:25, bobv wrote:
Can you put this
LGTM
http://gwt-code-reviews.appspot.com/964802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8971
Author: j...@google.com
Date: Thu Oct 7 10:04:32 2010
Log: Fix the DevMode Swing UI to avoid clipping buttons when the URL
is too large or the window is resized.
Patch by: jat
Review by: fredsa
Review at http://gwt-code-reviews.appspot.com/952802
I believe I've encountered the bug. What I see is on reception, all
the entities proxies are made immutable.
They stay frozen, and finally, when flushing the driver, there is yet
another loop to freeze all the AutoBeans. Nowhere in between were the
beans made mutable. This is necessary because
Revision: 8972
Author: gwt.mirror...@gmail.com
Date: Thu Oct 7 13:59:41 2010
Log: Fixing LogExample and DynaTableRf for distro builds. The samples were
being compiled, but they weren't included in the eclipse.generate target.
We also now include json.jar and validation-api-1.0.0.GA.jar in
r8965 fixed the remaining issue. The other issue was on the AutoBean
itself and was previously fixed. However, I believe I have found
another issue in AbstractAutoBean which I just posted.
On Thu, Oct 7, 2010 at 4:57 PM, Ray Cromwell cromwell...@gmail.com wrote:
Patrick,
Are you using an
http://gwt-code-reviews.appspot.com/941802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8973
Author: p...@google.com
Date: Thu Oct 7 11:13:29 2010
Log: Cherry picking changes from trunk to GWT 2.1.0-rc1
* Correcting the servlet URL mapping in the LogExample sample.
* Fix verifyPositionStatic() so that RootPanel.get() is explicitly allowed,
e.g.,
Revision: 8974
Author: gwt.mirror...@gmail.com
Date: Thu Oct 7 14:19:41 2010
Log: Add tag for gwt 2.1.0 rc1
http://code.google.com/p/google-web-toolkit/source/detail?r=8974
Added:
/tags/2.1.0-rc1/2.1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Thu, Oct 7, 2010 at 1:55 PM, Patrick Julien pjul...@gmail.com wrote:
They stay frozen, and finally, when flushing the driver, there is yet
another loop to freeze all the AutoBeans. Nowhere in between were the
beans made mutable. This is necessary because we sometimes have
custom setters
Yes, I know, rc.edit() is called, this is just before the flush,
rc.edit has been called well before this.
On Thu, Oct 7, 2010 at 5:23 PM, BobV b...@google.com wrote:
On Thu, Oct 7, 2010 at 1:55 PM, Patrick Julien pjul...@gmail.com wrote:
They stay frozen, and finally, when flushing the driver,
And I might add, otherwise the flush would fail, values coming from
the editors directly are fine
On Thu, Oct 7, 2010 at 5:25 PM, Patrick Julien pjul...@gmail.com wrote:
Yes, I know, rc.edit() is called, this is just before the flush,
rc.edit has been called well before this.
On Thu, Oct 7,
FYI, if I modify to:
@Override
public String saveTriggered() {
getRequestContext().edit(getValue());
getValue().setActive(!view.isPracticeDeactivated());
save();
return null;
}
still throws
Reduced test
never mind,
rc.edit(response); returns a value, and that one is not frozen
On Thu, Oct 7, 2010 at 5:35 PM, Patrick Julien pjul...@gmail.com wrote:
FYI, if I modify to:
�...@override
public String saveTriggered() {
getRequestContext().edit(getValue());
On Thu, Oct 7, 2010 at 2:35 PM, Patrick Julien pjul...@gmail.com wrote:
FYI, if I modify to:
�...@override
public String saveTriggered() {
getRequestContext().edit(getValue());
getValue().setActive(!view.isPracticeDeactivated());
Revision: 8975
Author: gwt.mirror...@gmail.com
Date: Thu Oct 7 16:11:08 2010
Log: Removing incorrect tag
http://code.google.com/p/google-web-toolkit/source/detail?r=8975
Deleted:
/tags/2.1.0-rc1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8976
Author: gwt.mirror...@gmail.com
Date: Thu Oct 7 16:12:56 2010
Log: Adding correct 2.1.0-rc1 tag
http://code.google.com/p/google-web-toolkit/source/detail?r=8976
Added:
/tags/2.1.0-rc1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks Thomas I really appreciate your Test Case with more than 2
languages and the link to GWT incubator.
I will work on a solution to cover multilingual application.
Regards,
Bernie1953
On Oct 6, 12:29 pm, Thomas Broyer t.bro...@gmail.com wrote:
On Oct 6, 2:24 pm, Bernie1953
36 matches
Mail list logo
