Comment by eplischke:
... or if you have multi-locales than you can do this way:
extend-property name=locale values=en,de/
set-property-fallback name=locale value=en/
set-property name=locale value=en,de/
For more information:
Reviewers: jlabanca,
Description:
Some of the unit tests in CreateEventTest have listeners
that fire multiple times. This occasionally causes a failure
in an unrelated test. Assuming that the extra firings
are spurious, I've added an explicit 'cancel()' method
to bypass the assertions if they
LGTM
http://gwt-code-reviews.appspot.com/1223801/diff/1/2
File user/test/com/google/gwt/user/client/ui/CreateEventTest.java
(right):
http://gwt-code-reviews.appspot.com/1223801/diff/1/2#newcode738
user/test/com/google/gwt/user/client/ui/CreateEventTest.java:738:
listener.assertReceived();
Reviewers: jlabanca, rdayal,
Description:
Add a warning in GWTTestCase to help users that accidentally run a GWT
JUnit Test as a JUnit Test.
This mistake is easy to make (especially in Eclipse.) Therefore, we
display a helpful error suggesting the user run as a GWTJUnitTest if an
exception is
http://gwt-code-reviews.appspot.com/1223801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1223801/diff/1/2
File user/test/com/google/gwt/user/client/ui/CreateEventTest.java
(right):
http://gwt-code-reviews.appspot.com/1223801/diff/1/2#newcode738
user/test/com/google/gwt/user/client/ui/CreateEventTest.java:738:
listener.assertReceived();
On
LGTM
http://gwt-code-reviews.appspot.com/1223801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1224801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: pdr,
Description:
Fixing a bug in CellTable and CellList where we get an index out of
bounds exception if we try to access the keyboard selected element when
keyboard selection is disabled.
Please review this at http://gwt-code-reviews.appspot.com/1225801/show
Affected files:
M
On 2010/12/16 16:51:04, jlabanca wrote:
LGTM
http://gwt-code-reviews.appspot.com/1225801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Dec 15, 2010 at 5:40 PM, jlaba...@google.com wrote:
LGTM
Don't forget test cases.
By which I'm sure John meant before you submit this.
You guys are doing an awesome job with the HTML5 stuff! I can't wait to
see this stuff in action.
Revision: 9450
Author: ncha...@google.com
Date: Thu Dec 16 09:46:38 2010
Log: warning bootstrap is broken
http://code.google.com/p/google-web-toolkit/source/detail?r=9450
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Wed Dec 15
Revision: 9451
Author: ncha...@google.com
Date: Thu Dec 16 09:47:49 2010
Log: escape wikilink
http://code.google.com/p/google-web-toolkit/source/detail?r=9451
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Thu Dec 16 09:46:38 2010
Revision: 9453
Author: jlaba...@google.com
Date: Thu Dec 16 06:19:53 2010
Log: Fixing a bug in CellTable and CellList where we get an index out of
bounds exception if we try to access the keyboard selected element when
keyboard selection is disabled.
Review at
committed as r9453
http://gwt-code-reviews.appspot.com/1225801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9454
Author: jlaba...@google.com
Date: Thu Dec 16 07:24:08 2010
Log: Cherry picking r9453 into release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9454
Modified:
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellList.java
Thanks for looking into this.
A couple of questions/comments before I give the LGTM..
http://gwt-code-reviews.appspot.com/1224801/diff/1/2
File user/src/com/google/gwt/junit/client/GWTTestCase.java (right):
http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode445
Revision: 9455
Author: j...@google.com
Date: Thu Dec 16 09:38:49 2010
Log: Merge pt_PT fix for AD era name into 2.1 release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9455
Modified:
Revision: 9456
Author: j...@google.com
Date: Thu Dec 16 09:22:20 2010
Log: Change era names in pt_PT to match pt (a Portuguese specialist replied
it should also
be changed).
Patch by: jat
Review by: pdr
http://code.google.com/p/google-web-toolkit/source/detail?r=9456
Modified:
Revision: 9457
Author: p...@google.com
Date: Thu Dec 16 12:56:48 2010
Log: Removing the 2.1.1 tag.
http://code.google.com/p/google-web-toolkit/source/detail?r=9457
Deleted:
/tags/2.1.1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9458
Author: p...@google.com
Date: Thu Dec 16 12:57:29 2010
Log: Adding the 2.1.1 tag.
http://code.google.com/p/google-web-toolkit/source/detail?r=9458
Added:
/tags/2.1.1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: tobyr, zundel, robertvawter,
Description:
Experimental framework for generator result caching in dev mode.
Please review this at http://gwt-code-reviews.appspot.com/1227801/show
Affected files:
A dev/core/src/com/google/gwt/core/ext/GeneratorContextExt.java
A
http://gwt-code-reviews.appspot.com/1221801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel,
Description:
Re-enable a few style tests now that old linux hosted mode is gone
Please review this at http://gwt-code-reviews.appspot.com/1228801/show
Affected files:
M user/test/com/google/gwt/dom/client/StyleTest.java
Index:
Reviewers: zundel,
Description:
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
Please review this at http://gwt-code-reviews.appspot.com/1229801/show
Affected files:
M
Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone
http://gwt-code-reviews.appspot.com/1228801
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the
LGTM
thanks for looking into the tests as well
On 2010/12/16 21:59:57, fredsa wrote:
Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone
http://gwt-code-reviews.appspot.com/1228801
Re-enable XML
Did you try running this test on a Mac?
On 2010/12/16 21:57:24, fredsa wrote:
http://gwt-code-reviews.appspot.com/1229801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
So this patch just backs out r5374. Can we be more specific in the
comment and say that the error was pre gecko 1.8? (Mozilla 1.7 was linux
hosted mode)
(checked with svn diff -c 5374
user/test/com/google/gwt/dom/client/StyleTest.java)
here is the log
Reviewers: unnurg, burdon_google.com,
Description:
Make the logging framework provide a default uncaught exception handler.
Please review this at http://gwt-code-reviews.appspot.com/1223802/show
Affected files:
M user/src/com/google/gwt/logging/client/LogConfiguration.java
Index:
Unnur, is there a test I can extend for this?
http://gwt-code-reviews.appspot.com/1223802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1226801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I second this request for info :)
We are using TinyMCE right now and worked hard to get it to integrate;
but we don't really like it and there are oddities that we still deal
with sometimes. If someone has sample integration code that could be
shared, we would appreciate being able to see it to
Reviewers: rchandia,
Description:
Basic MessageIntrpolation.
Refactored the bootstrap to hook via ValidatorFactory
[JSR 303 TCK Result] 44 of 258 (17.05%) Pass with 12 Failures and 12
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1230801/show
Affected files:
M
Revision: 9460
Author: ncha...@google.com
Date: Thu Dec 16 21:53:00 2010
Log: Link to CL
http://code.google.com/p/google-web-toolkit/source/detail?r=9460
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Thu Dec 16 09:47:49 2010
+++
Reviewers: rchandia,
Description:
Handle composite constraints.
[JSR 303 TCK Result] 36 of 258 (13.95%) Pass with 15 Failures and 16
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1231801/show
Affected files:
M
36 matches
Mail list logo
