I guess that's why it says *a* BasicPlace rather than just BasicPlace.
Yes, it's up to you to define such a class. David Chandler (or was it Chris
Ramsdale?) once answered about this paragraph and acknowledged it wasn't
very clear…
--
Reviewers: bobv, rjrjr,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5872
This is a first step in the right direction, but I suppose you'd want to
go farther. Noticeably:
- it's using UmbrellaException from c.g.g.event.shared. Maybe it should
define its own
@Jeff -
I'm a little behind this week because of the snow in Atlanta (all four
inches it took to shutdown the city for four days), but I'll review this
patch next week. Thanks for submitting it.
http://gwt-code-reviews.appspot.com/1149803/show
--
Reviewers: rjrjr,
Description:
Adding new SimpleLayoutPanel widget, which is a subclass of SimplePanel
that ProvidesResize to its child. This is useful when an application
needs a content container to hold a Widget that RequiresResize.
Issue: 5501
Please review this at
Reviewers: ,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5563
Following my proposal (copied here from the issue tracker):
The fix should IMO be (and I believe it was in my initial patch that
introduced the handler/mapper dichotomy) to ignore classes in the
lgtm
http://gwt-code-reviews.appspot.com/1291801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9543
Author: robertvaw...@google.com
Date: Fri Jan 14 04:27:42 2011
Log: Public (by t.broyer):
Don't allow exceptions escaping from RequestFactory Receiver callback
methods to prevent other callbacks from being called.
Issue 5872
http://gwt-code-reviews.appspot.com/1290801/show
Patch
Revision: 9544
Author: gwt.mirror...@gmail.com
Date: Fri Jan 14 08:50:59 2011
Log: Public (by t.broyer):
Don't flush RequestFactoryEditorDelegate when its associated request is
locked.
Issue 5752.
http://gwt-code-reviews.appspot.com/1284801/show
Patch by: t.broyer
Review by: bobv
Revision: 9545
Author: b...@google.com
Date: Fri Jan 14 04:49:07 2011
Log: Integrate RequestFactory Receiver exception handling fixes into 2.2
branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9545
Added:
Bug report
http://code.google.com/p/google-web-toolkit/issues/detail?id=5876
http://gwt-code-reviews.appspot.com/1289801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9546
Author: b...@google.com
Date: Fri Jan 14 05:45:45 2011
Log: Integrate fix for issue 5752 into GWT 2.2 branch.
Don't flush RequestFactoryEditorDelegate when its associated request is
locked.
http://code.google.com/p/google-web-toolkit/source/detail?r=9546
Modified:
Revision: 9547
Author: b...@google.com
Date: Fri Jan 14 06:09:32 2011
Log: Integrate Editor fix to GWT 2.2 branch.
Ensure that Editor framework descends into LeafValueEditors that require
delegates.
http://code.google.com/p/google-web-toolkit/source/detail?r=9547
Modified:
Revision: 9548
Author: gwt.mirror...@gmail.com
Date: Fri Jan 14 09:22:31 2011
Log: Adding new SimpleLayoutPanel widget, which is a subclass of
SimplePanel that ProvidesResize to its child. This is useful when an
application needs a content container to hold a Widget that RequiresResize.
committed as r9548
http://gwt-code-reviews.appspot.com/1291801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9549
Author: gwt.mirror...@gmail.com
Date: Fri Jan 14 09:23:46 2011
Log: Public (by t.broyer):
Ensure that Editor framework descends into LeafValueEditors that require
delegates.
Issue 5795.
http://gwt-code-reviews.appspot.com/1249801/show
Patch by: t.broyer
Review by: bobv
Revision: 9550
Author: ncha...@google.com
Date: Fri Jan 14 06:38:38 2011
Log: Fix a generics compile error on OSX java 1.6
Review at http://gwt-code-reviews.appspot.com/1289801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9550
Modified:
Reviewers: jlabanca, rjrjr,
Description:
Fix bug on IE where onload events don't fire for IFrames.
This is a bugfix for
http://code.google.com/p/google-web-toolkit/issues/detail?id=1720
Please review this at http://gwt-code-reviews.appspot.com/1294801/show
Affected files:
M
http://gwt-code-reviews.appspot.com/1294801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9551
Author: gwt.mirror...@gmail.com
Date: Fri Jan 14 10:41:19 2011
Log: JAR files for client-side JSR 303 validation. Matches trunk changes at
r9233.
http://code.google.com/p/google-web-toolkit/source/detail?r=9551
Added:
/tools/lib/hibernate/validator/tck
Revision: 9552
Author: b...@google.com
Date: Fri Jan 14 07:30:53 2011
Log: Rolling back r9549 due to downstream build breaks.
http://code.google.com/p/google-web-toolkit/source/detail?r=9552
Modified:
/trunk/user/src/com/google/gwt/editor/rebind/model/EditorModel.java
LGTM
I tested in a sample app with a concrete class TestPlaceHistoryMapper
extends TestAbstractPlaceHistoryMapper, which implements
PlaceHistoryMapper. Works fine.
Thank you, Thomas!
http://gwt-code-reviews.appspot.com/1292801/show
--
Revision: 9553
Author: mrruss...@google.com
Date: Fri Jan 14 11:06:02 2011
Log: create a tag for the 2.2-M1 release
http://code.google.com/p/google-web-toolkit/source/detail?r=9553
Added:
/tags/2.2-M1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002
File user/test/com/google/gwt/dom/client/FrameTests.java (right):
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49
user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer
timer = new Timer() {
Do you need
Reviewers: rjrjr, tbroyer,
Description:
Re-roll r9549 with a fix that ensures that sub-editors of a
LeafValueEditor will be ignored.
Patch by: t.broyer, bobv
Review by: bobv, rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1295801/show
Affected files:
M
I do not think moving countMarkedTests.sh into the build is a good idea.
Would you mind leaving the script out until there is a platform agnostic
alternative?
On 2011/01/14 00:47:40, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1288801/show
--
LGTM
http://gwt-code-reviews.appspot.com/1295801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as of r9550
On 2011/01/14 17:19:46, Nick Chalko wrote:
Bug report
http://code.google.com/p/google-web-toolkit/issues/detail?id=5876
http://gwt-code-reviews.appspot.com/1289801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9554
Author: rchan...@google.com
Date: Fri Jan 14 08:49:42 2011
Log: Cherry picking r9550 for Issue 5876
http://code.google.com/p/google-web-toolkit/source/detail?r=9554
Modified:
/releases/2.2/user/test/com/google/gwt/requestfactory/client/RequestFactoryTestBase.java
Revision: 9555
Author: b...@google.com
Date: Fri Jan 14 08:57:14 2011
Log: Re-roll r9549 with a fix that ensures that sub-editors of a
LeafValueEditor will be ignored.
Patch by: t.broyer, bobv
Review by: bobv, rjrjr
Review at http://gwt-code-reviews.appspot.com/1295801
Revision: 9556
Author: b...@google.com
Date: Fri Jan 14 09:32:27 2011
Log: Integrate EditorModel LeafValueEditor+CompositeEditor fix into GWT 2.2
branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9556
Modified:
Awesome!
Thanks a lot Ray and Bob for the fast reviews (and fix). I can't wait for
2.2 to be released!
(well, now I have 5 open issues with RequestFactory assigned to me by my
team, let's see if they're RF issues of –much more likely– issues with
either user code or my heavy use of
Reviewers: jlabanca, rice,
Description:
Improve canvas for browsers (and permutations) with partial canvas
support.
Please review this at http://gwt-code-reviews.appspot.com/1296801/show
Affected files:
M user/src/com/google/gwt/canvas/client/Canvas.java
M
Revision: 9557
Author: fre...@google.com
Date: Fri Jan 14 16:09:06 2011
Log: Edited wiki page WebModeExceptions through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9557
Modified:
/wiki/WebModeExceptions.wiki
===
---
http://gwt-code-reviews.appspot.com/1288801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/15 00:19:29, Nick Chalko wrote:
Done
http://gwt-code-reviews.appspot.com/1288801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
35 matches
Mail list logo
