http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Great thought, Thomas. I changed resolveServiceClass to take a
RequestContext class as you suggest.
On 2011/03/12 10:16:35, tbroyer wrote:
A few more thoughts:
- resolveServiceClass would benefit from being cached at the
ServiceLayerCache
level
- I know this is only about the server-side,
I support the move of the AsyncCallback! What is the purpose of adding
AsyncProvider to GWT's types? It seems only really useful if using
dependency injection (other usages are usually abuses :) and I don't see
why GWT would want that kind of dependency?
On Mon, Mar 14, 2011 at 12:37 PM, Ray Ryan rj...@google.com wrote:
[+google-...@googlegroups.com]
What dependency? DI is a pattern, not a commitment to a particular
framework. That said, I agree that taking AsyncProvider from Gin is a bit
presumptuous. I meant to include the gin community
ServiceInheritanceTest is still missing from RequestContextSuite (not
Jre)
http://gwt-code-reviews.appspot.com/1384802/diff/1006/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384802/diff/6005/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
Comment by kujans...@googlemail.com:
Are there any news? Or even a release ETA?
Would love to see that :)
For more information:
http://code.google.com/p/google-web-toolkit/wiki/RpcAuth
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I removed the corresponding try/catch in ResolverServiceLayer also.
http://gwt-code-reviews.appspot.com/1384802/diff/6005/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
Mark,
This is something we are interested in supporting at some point in the
future. The issue tracking it is here:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5577
On Sun, Feb 20, 2011 at 7:16 PM, Mark Renouf mark.ren...@gmail.com wrote:
Hi all,
I'm just writing to let
On 2011/03/16 16:52:48, drfibonacci wrote:
I removed the corresponding try/catch in ResolverServiceLayer also.
http://gwt-code-reviews.appspot.com/1384802/diff/6005/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
File
Great, thanks for the heads up, I will star the issue. Let me know if
I can help.
On Wed, Mar 16, 2011 at 12:58 PM, Chris Conroy con...@google.com wrote:
Mark,
This is something we are interested in supporting at some point in the
future. The issue tracking it is
here:
Revision: 9857
Author: drfibona...@google.com
Date: Wed Mar 16 07:05:51 2011
Log: Fix issue 5807 on server side. Previously reviewed at 1370803.
Review at http://gwt-code-reviews.appspot.com/1384802
http://code.google.com/p/google-web-toolkit/source/detail?r=9857
Added:
Reviewers: rjrjr,
Description:
Update UiBinder to use SafeHtml instead of String in HtmlPanelParser
constructor
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1384805/
Affected files:
M
Reviewers: jat,
Description:
Fix docs/warnings
Please review this at http://gwt-code-reviews.appspot.com/1380805/
Affected files:
M dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java
M dev/core/src/com/google/gwt/core/ext/Linker.java
M
On 2011/03/16 20:14:54, rice wrote:
LGTM for the validation parts.
http://gwt-code-reviews.appspot.com/1380805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1384805/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HTMLPanelParser.java
File
user/src/com/google/gwt/uibinder/elementparsers/HTMLPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/1384805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9858
Author: sco...@google.com
Date: Wed Mar 16 09:22:21 2011
Log: Fix the worst concurrent modification problems in compiler
memory-light set/map.
Due to a bug in com.google.gwt.dev.util.collect.HashMap.put(), we were
eagerly growing the underlying table even when the key was
Revision: 9859
Author: unn...@google.com
Date: Wed Mar 16 11:12:59 2011
Log: Make devmode.js have a module specific filename
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9859
Modified:
Reviewers: cromwellian,
Description:
Adds flag to enable EnumOrdinalizer result stats
Please review this at http://gwt-code-reviews.appspot.com/1386802/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M
Revision: 9860
Author: drfibona...@google.com
Date: Wed Mar 16 12:12:36 2011
Log: Rolling back ServiceInheritanceTest to make it GWT safe so can run in
RequestFactorySuite also
Review at http://gwt-code-reviews.appspot.com/1384802
http://gwt-code-reviews.appspot.com/1384805/diff/2003/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
File user/src/com/google/gwt/user/client/ui/HTMLPanel.java (right):
http://gwt-code-reviews.appspot.com/1384805/diff/2003/user/src/com/google/gwt/user/client/ui/HTMLPanel.java#newcode134
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I removed the latest patch set since the latest diffs were broken. I used
the rietveld script so SVN base path was correct, but the internal rollback
and reapply seems to have confused rietveld. I may have to create a new
issue.
On Wed, Mar 16, 2011 at 7:30 PM, drfibona...@google.com wrote:
Reviewers: drfibonacci,
Description:
Fixing issue 5807 on server side, new issue due to rietveld problems
Formerly at 1384802
Please review this at http://gwt-code-reviews.appspot.com/1384806/
Affected files:
M user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
M
http://gwt-code-reviews.appspot.com/1384802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
28 matches
Mail list logo
