Hi Bod and Dan,
Very happy to see that this issue is on its way to be solved :)
Nevertheless, I think it would be useful if JDO management code and
RPC serialization can be separated : instead of having
for (Class iface : interfaces) {
if (javax.jdo.spi.Detachable.equals(iface.getName())) {
On 2009/06/19 17:30:23, jgw wrote:
On 2009/06/19 01:37:23, scottb wrote:
LGTM. Good catches, all.
BTW, Scott -- could you please go ahead and commit this when you have a
moment? I'd like to get these into the 1.6 maintenance release.
http://gwt-code-reviews.appspot.com/42802
Reviewers: jlabanca,
Please review this at http://gwt-code-reviews.appspot.com/49803
Affected files:
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Index:
Note that the referenced Firefox bug is marked as fixed/resolved, but it
didn't make it into the Firefox 3.5 release branch (they're expecting to
ship a fix in 3.5.1, which essentially means we're all going to be stuck
with this behavior for at least a year or so).
I've tested this patch on a
Looks good, modulo my comment about repeating method declarations in the
formatter interfaces.
http://gwt-code-reviews.appspot.com/49802/diff/1/5
File user/src/com/google/gwt/user/client/ui/RichTextArea.java (right):
http://gwt-code-reviews.appspot.com/49802/diff/1/5#newcode485
Line 485: void
LGTM
http://gwt-code-reviews.appspot.com/49803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/49802/diff/1/5
File user/src/com/google/gwt/user/client/ui/RichTextArea.java (right):
http://gwt-code-reviews.appspot.com/49802/diff/1/5#newcode485
Line 485: void undo();
It prevents a deprecation compiler warning when using the methods. If
we inherit them
Author: jlaba...@google.com
Date: Tue Jun 30 06:58:38 2009
New Revision: 5639
Modified:
trunk/user/src/com/google/gwt/user/client/ui/RichTextArea.java
trunk/user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImpl.java
Thanks for the review; the JSNI lookup logic had already been extracted
into JsniRefLookup by Lex some number of weeks ago.
Committed at r5640.
http://gwt-code-reviews.appspot.com/46802
--~--~-~--~~~---~--~~
On 2009/06/30 13:45:55, jlabanca wrote:
LGTM
Thanks, commited at r5641.
http://gwt-code-reviews.appspot.com/49803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Hi Bruno -
I've uploaded a new patch that's more along these lines. Hopefully it
will do what you are looking for. Thanks,
Dan
On Tue, Jun 30, 2009 at 4:15 AM, bruno bruno.marches...@gmail.com wrote:
Hi Bod and Dan,
Very happy to see that this issue is on its way to be solved :)
My +1 in general. On Katharina's point, is it practical to just add a note
to the HTML output, rather than looking for a code change, to the effect of
some small methods may have been inlined away, perhaps citing an option
(-XsoycExtra, I see in the patch? Or maybe an option to -soyc, like
Joel,
I'm out of the office today, but I'll be sure to give it a shot first
thing tomorrow and report back.
Thanks.
- Amir
On Jun 30, 5:32 am, Joel Webber j...@google.com wrote:
Amir,
I'd be very interested in any way you can find to reproduce this bug
reliably. The History implementation
Sorry this took so long -- its a lot of code. In general it looks pretty
good - mostly just minor nits and a couple clarifications requested, plus
one potentially significant issue.
I would like to see example payloads in comments (not sure the best place to
put it -- maybe in the CommandSink
Author: j...@google.com
Date: Tue Jun 30 08:39:59 2009
New Revision: 5643
Modified:
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
releases/1.6/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Log:
Merging r5641 from trunk (Fix for Firefox 3.5
Author: j...@google.com
Date: Tue Jun 30 08:40:18 2009
New Revision: 5644
Modified:
branches/snapshot-2009.06.16-r5570/branch-info.txt
Log:
Updating branch-info.
Modified: branches/snapshot-2009.06.16-r5570/branch-info.txt
Author: b...@google.com
Date: Tue Jun 30 07:54:21 2009
New Revision: 5640
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
trunk/user/src/com/google/gwt/core/client/impl/Impl.java
Log:
Add
Author: j...@google.com
Date: Tue Jun 30 08:01:08 2009
New Revision: 5641
Modified:
trunk/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
trunk/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Log:
Fix for Firefox 3.5 relatedTarget bug
Hello!
I want know about the Dynamic panel. I do not know if there is
Dynamic panel in GWT. One Day, I do RPC by opertion OnSuccess(), to
make a Dynamic panel. but the panel is not show first. when Switch
interface the panel is show after. so i don't know why. Like:
public void
Author: j...@google.com
Date: Tue Jun 30 08:39:50 2009
New Revision: 5642
Modified:
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Log:
Merging
Reviewers: jgw,
Description:
This patch fixes a few issues in RichTextArea:
Issue 3133:
Events triggered by RichTextArea are not sent through the normal event
system, so none of the DOM methods that rely on currentEvent work. I
fixed this by calling DOM#dispatchEvent() instead of calling
Author: j...@google.com
Date: Tue Jun 30 13:00:02 2009
New Revision: 5646
Modified:
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/ui/RadioButton.java
Log:
Merging trunk r5627 into this branch.
Modified:
Reviewers: robertvawter_google.com,
Description:
I would like to be able to use @def to define color values in my .css
file but also access them in my Java code. This change allows you to
define an accessor in your CssResource implementation class that returns
a String.
Please review this at
I uploaded a patch for consideration at:
http://gwt-code-reviews.appspot.com/50804
On Tue, Jun 30, 2009 at 9:49 AM, Eric Ayerszun...@google.com wrote:
In this case, I'm trying to share color definitions between CSS and my
source. I have a palette of colors that I want to share.
On Tue,
I think the following scenario should be made to work.
my.css:
@def shadow #abc
.shadow { color: shadow; }
my.java
MyCss implements CssResource {
String shadow();
@ClassName(shadow)
String shadowClass();
}
http://gwt-code-reviews.appspot.com/50804/diff/1/5
File
Ah, that does ring a bell. funny, I can't actually find any way in the tool
that lets you see what svn rev the patch is actually against.
On Tue, Jun 30, 2009 at 10:56 AM, b...@google.com wrote:
Thanks for the review; the JSNI lookup logic had already been extracted
into JsniRefLookup by Lex
I did, it's in there at r5602.
On Tue, Jun 30, 2009 at 9:15 AM, j...@google.com wrote:
On 2009/06/19 17:30:23, jgw wrote:
On 2009/06/19 01:37:23, scottb wrote:
LGTM. Good catches, all.
BTW, Scott -- could you please go ahead and commit this when you have a
moment? I'd like to get
Reviewers: scottb,
Please review this at http://gwt-code-reviews.appspot.com/50805
Affected files:
dev/core/src/com/google/gwt/core/ext/SelectionProperty.java
dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java
Index: dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java
1 issue, but no need to re-review
http://gwt-code-reviews.appspot.com/50805/diff/1/3
File dev/core/src/com/google/gwt/core/ext/SelectionProperty.java
(right):
http://gwt-code-reviews.appspot.com/50805/diff/1/3#newcode44
Line 44: * Gets the fallback value for the property
Period should go here.
Author: j...@google.com
Date: Tue Jun 30 13:00:59 2009
New Revision: 5647
Modified:
branches/snapshot-2009.06.16-r5570/branch-info.txt
Log:
Updating branch-info.
Modified: branches/snapshot-2009.06.16-r5570/branch-info.txt
Author: j...@google.com
Date: Tue Jun 30 17:14:14 2009
New Revision: 5650
Added:
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/AsmTestCase.java
(contents, props changed)
Author: sco...@google.com
Date: Tue Jun 30 18:16:39 2009
New Revision: 5651
Modified:
trunk/user/src/com/google/gwt/junit/JUnitMessageQueue.java
trunk/user/src/com/google/gwt/junit/JUnitShell.java
Log:
More sort format.
Modified:
+1
On Mon, Jun 29, 2009 at 7:24 AM, dflorey daniel.flo...@gmail.com wrote:
Hi,
I've been wondering how GWT should deal with upcoming new features in
HTML5/CSS3.
There are several areas where functionality that has been implemented
in GWT is now also available in the upcoming rendering
+1
On Jun 29, 10:24 am, dflorey daniel.flo...@gmail.com wrote:
Hi,
I've been wondering how GWT should deal with upcoming new features in
HTML5/CSS3.
There are several areas where functionality that has been implemented
in GWT is now also available in the upcoming rendering engines.
GWT is
Surya,
In general you should be able to follow along
http://code.google.com/p/google-web-toolkit-incubator/wiki/GlassPanel and
just include the GlassPanel code in your project as you suggested.
Any chance you are using GWT trunk rather than 1.6.4? If so, check to see
you have the latest source
Surya,
Also see my reply to your other email and make sure that if you're on GWT
trunk that you have the latest module file which includes an ie8 rule as
seen in
http://code.google.com/p/google-web-toolkit-incubator/source/browse/trunk/src/com/google/gwt/widgetideas/GlassPanel.gwt.xml
Fred
On
Transparent support for CSS3/HTML5 on all browsers including IE would be a
killer feature !+1
2009/7/1 tfreitas tfrei...@gmail.com
+1
On Jun 29, 10:24 am, dflorey daniel.flo...@gmail.com wrote:
Hi,
I've been wondering how GWT should deal with upcoming new features in
HTML5/CSS3.
37 matches
Mail list logo
