My 2 c€nts.
Overall, it leads to reworking the patch as an:
if (method is GET (or HEAD)) {
if (url contains .nocache.) {
set no-cache headers
} else if (url contains .cache.) {
set forever-cache headers
}
}
// otherwise (non-GET/HEAD, or non-nocache/cache URL), just do
On 2009/09/22 00:28:46, Ray Ryan wrote:
Joel, can you review this small change that will probably make biggish
ripples
in your world? Since html uses src all over the place, we should too.
Agreed. LGTM.
http://gwt-code-reviews.appspot.com/67809
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/68805
Affected files:
M samples/mail/src/com/google/gwt/sample/mail/Mail.gwt.xml
M samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
A
Committed at r6188
On Tue, Sep 22, 2009 at 7:09 AM, j...@google.com wrote:
On 2009/09/22 00:28:46, Ray Ryan wrote:
Joel, can you review this small change that will probably make biggish
ripples
in your world? Since html uses src all over the place, we should too.
Agreed. LGTM.
I'm still reviewing, but I thought I should get this AttributeParser
issue in front of you early.
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/68805/diff/1/24#newcode68
Reviewers: jat,
Description:
Currently the check for a 32-bit VM never gets run on Linux. This CL
moves it into SwtHostedModeBase where it can run for all platforms.
Please review this at http://gwt-code-reviews.appspot.com/68806
Affected files:
On 2009/09/22 18:59:16, Ray Ryan wrote:
I'm still reviewing, but I thought I should get this AttributeParser
issue in
front of you early.
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File
user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
(right):
Hi John -
You say more generic but your comment seems to be suggesting greater
specificity (use versus how to use). Do you have some language in
mind?
Dan
On Tue, Sep 22, 2009 at 3:18 PM, j...@google.com wrote:
LGTM assuming you have tested it on all platforms, with minor nits.
Assuming we make parsing attributes using AttributeParsers required
(which makes perfect sense to me), I think we'll need to change
writer.getAttributeParser(JParam...) to take (JType...) instead. This
method only ever uses the types of the parameters, and many consumers of
attributes aren't
On Tue, Sep 22, 2009 at 3:27 PM, Daniel Rice (דניאל רייס)
r...@google.comwrote:
You say more generic but your comment seems to be suggesting greater
specificity (use versus how to use). Do you have some language in
mind?
I am suggesting that either we make the language more generic, such as
O.K., I'll stick with the one-line version for non-Mac platforms.
On Tue, Sep 22, 2009 at 3:39 PM, John Tamplin j...@google.com wrote:
On Tue, Sep 22, 2009 at 3:27 PM, Daniel Rice (דניאל רייס) r...@google.com
wrote:
You say more generic but your comment seems to be suggesting greater
On Tue, Sep 22, 2009 at 3:40 PM, Daniel Rice (דניאל רייס)
r...@google.comwrote:
O.K., I'll stick with the one-line version for non-Mac platforms.
Another option might be to point at a Wiki page that we could update with
recipes for different platforms over time.
--
John A. Tamplin
Software
On Tue, Sep 22, 2009 at 12:23 PM, j...@google.com wrote:
On 2009/09/22 18:59:16, Ray Ryan wrote:
I'm still reviewing, but I thought I should get this AttributeParser
issue in
front of you early.
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File
I was going to ask you. Yeah, I think it makes sense. Might as well keep the
JParam method as a convenience?
On Tue, Sep 22, 2009 at 12:38 PM, j...@google.com wrote:
Assuming we make parsing attributes using AttributeParsers required
(which makes perfect sense to me), I think we'll need to
Addressed individual comments. How about we leave off the
consumeAttribute() thing for a moment, as you suggest, and then I fix it
in a subsequent patch?
http://gwt-code-reviews.appspot.com/68805
--~--~-~--~~~---~--~~
Still LGTM
I mean one rethrow nit below HERE
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/68805/diff/1/24#newcode115
Line 115: writer.die(Unexpected: Unable to find %s
Hey guys,
The autoformater will change this to
@UiField
Button closeButton;
which sucks. I want to fix that for annoations with no arguments, but
have no
idea how to. You have any clue to share?
Bugs the crap out of me too. I can't find any annotation-related
settings in the
17 matches
Mail list logo
