LGTM. We used to have code that looked a lot like this, it must have
gotten killed in the merge.
BTW: have you run this on Windows? I'm not sure if chmod works there,
but we need to verify that at least it doesn't fail.
http://gwt-code-reviews.appspot.com/89805
SGTM
On Wed, Oct 28, 2009 at 7:12 PM, Ray Ryan rj...@google.com wrote:
If you don't feel strongly about it, I'd like to leave it where it is.
It's a pretty integral part of binder itself.
--~--~-~--~~~---~--~~
Thank you for pointing me in this direction. Changing from !DOCTYPE
HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/
strict.dtd to !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01
Transitional//EN seems to fix it. However now most of my other
styles look rather poor. I really do not
LGTM
http://gwt-code-reviews.appspot.com/88803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Hi all,
as the subject says, is this doable? Can I somehow build myself that
extension?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Thu, Oct 29, 2009 at 8:59 AM, skrat dusan.malia...@gmail.com wrote:
as the subject says, is this doable? Can I somehow build myself that
extension?
Not yet -- Linux Chrome doesn't yet have CRX support, and there are
unresolved issues about CRX files with binary components for multiple
Revision: 6539
Author: kpro...@google.com
Date: Thu Oct 29 08:04:17 2009
Log: Merginging trunk c6450.
svn merge --ignore-ancestry -c6450
https://google-web-toolkit.googlecode.com/svn/trunk .
Cleans up SOYC options: -compileReport is now preferred way to generate SOYC
reports, -soyc is now
Revision: 6538
Author: kpro...@google.com
Date: Thu Oct 29 07:49:45 2009
Log: Cleans up some compiler spew.
http://code.google.com/p/google-web-toolkit/source/detail?r=6538
Modified:
/releases/2.0/dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
Reviewers: jlabanca,
Message:
Review requested.
Description:
This patch deprecates the ImageBundle interface and updates existing
widgets to accept equivalent ClientBundles.
Please review this at http://gwt-code-reviews.appspot.com/89807
Affected files:
M
Comment by martin.g...@gmail.com:
I've tried the plugin again - it works fine with newly created GWT projects
(from eclipse) - but for our existing application (which is spreaded over
several eclipse projects) it doesn't work at all.
For more information:
Some nits.
Also, should we deprecate AbstractImagePrototype? Is it used for
anything other than ImageBundle?
http://gwt-code-reviews.appspot.com/89807/diff/11/13
File user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java
(right):
http://gwt-code-reviews.appspot.com/89807/diff/11/13
File user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java
(right):
http://gwt-code-reviews.appspot.com/89807/diff/11/13#newcode52
Line 52: public abstract class AbstractImagePrototype {
On 2009/10/29 15:37:56, jlabanca wrote:
Revision: 6541
Author: j...@google.com
Date: Thu Oct 29 08:49:04 2009
Log: Update XPCOM plugin to compute the top window and URL itself rather
than
rely on the values passed in from the JS code.
http://code.google.com/p/google-web-toolkit/source/detail?r=6541
Modified:
New patch uploaded.
http://gwt-code-reviews.appspot.com/89807/diff/11/13
File user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java
(right):
http://gwt-code-reviews.appspot.com/89807/diff/11/13#newcode52
Line 52: public abstract class AbstractImagePrototype {
Something needs to be
Reviewers: jlabanca,
Message:
Review requested.
Description:
Removes ImageBundle from the Mail and Showcase samples.
Please review this at http://gwt-code-reviews.appspot.com/89808
Affected files:
M samples/mail/src/com/google/gwt/sample/mail/client/Mailboxes.java
M
Revision: 6543
Author: mmen...@google.com
Date: Thu Oct 29 12:19:08 2009
Log: Fixes an NPE when a logged exception returns null for the stack trace.
http://code.google.com/p/google-web-toolkit/source/detail?r=6543
Modified:
Revision: 6544
Author: mmen...@google.com
Date: Thu Oct 29 12:27:35 2009
Log: Merged r6543 into this branch.
svn merge --ignore-ancestry -c 6543
http://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6544
Modified:
Revision: 6545
Author: mmen...@google.com
Date: Thu Oct 29 12:29:31 2009
Log: Updated branch-info to reflect the cherrypick of r6543.
http://code.google.com/p/google-web-toolkit/source/detail?r=6545
Modified:
/releases/2.0/branch-info.txt
===
---
Reviewers: kathrin,
Description:
One-liner.
Please review this at http://gwt-code-reviews.appspot.com/90801
Affected files:
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Index: dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
On 2009/10/29 19:52:18, Lex wrote:
LTGM.
Thanks for taking care of this!
http://gwt-code-reviews.appspot.com/90801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Thanks!
http://gwt-code-reviews.appspot.com/90801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6546
Author: sp...@google.com
Date: Thu Oct 29 13:41:31 2009
Log: Fixes an overly long filename in a compile report.
Review by: kprobst
http://code.google.com/p/google-web-toolkit/source/detail?r=6546
Modified:
/trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Revision: 6547
Author: rj...@google.com
Date: Thu Oct 29 14:57:19 2009
Log: Fix various error reporting issues:
Strict root element requirements
CellPanelParser NPE on bad child
http://code.google.com/p/google-web-toolkit/source/detail?r=6547
Modified:
Revision: 6548
Author: rj...@google.com
Date: Thu Oct 29 15:26:24 2009
Log: Merges tr...@6547 into releases/2.0
Fix various error reporting issues
svn merge --ignore-ancestry -c 6547
https://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 6549
Author: j...@google.com
Date: Thu Oct 29 15:48:15 2009
Log: Add tab identity support in Firefox.
http://code.google.com/p/google-web-toolkit/source/detail?r=6549
Modified:
/changes/jat/single-xpi/plugins/xpcom/ExternalWrapper.cpp
===
---
Revision: 6551
Author: j...@google.com
Date: Thu Oct 29 15:54:07 2009
Log: Update MSVC project file to reflect that include file hierarchy is
flattened
over Mozilla distro.
http://code.google.com/p/google-web-toolkit/source/detail?r=6551
Modified:
Revision: 6552
Author: rj...@google.com
Date: Thu Oct 29 16:06:04 2009
Log: Delete the empty user/src/com/google/gwt/uibinder/sample, because
git svn dcommit didn't
TBR bruce
http://code.google.com/p/google-web-toolkit/source/detail?r=6552
Deleted:
Hey, Bruce. I TBR'd you on these:
http://code.google.com/p/google-web-toolkit/source/detail?r=6550
http://code.google.com/p/google-web-toolkit/source/detail?r=6552
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
both lgtmd kthxbye
On Thu, Oct 29, 2009 at 7:28 PM, Ray Ryan rj...@google.com wrote:
Hey, Bruce. I TBR'd you on these:
http://code.google.com/p/google-web-toolkit/source/detail?r=6550
http://code.google.com/p/google-web-toolkit/source/detail?r=6552
This seemed like the thing to do, TBR you:
http://code.google.com/p/google-web-toolkit/source/detail?r=6554
On Thu, Oct 29, 2009 at 8:29 PM, codesite-nore...@google.com wrote:
br...@google.com commented on revision r6550 in project google-web-toolkit.
Details are at
Revision: 6555
Author: rj...@google.com
Date: Thu Oct 29 22:03:43 2009
Log: Fixes warnings in XMLElementTest, and fixes UiBinderJreSuite to
actually run the parser tests.
TBR rice
http://code.google.com/p/google-web-toolkit/source/detail?r=6555
Modified:
Dan, I submitted this TBR you:
http://code.google.com/p/google-web-toolkit/source/detail?r=6555
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6556
Author: rj...@google.com
Date: Thu Oct 29 22:08:49 2009
Log: Delete empty directories left behind from move of uibinder.sample to
uibinder.test
http://code.google.com/p/google-web-toolkit/source/detail?r=6556
Deleted:
/trunk/user/test/com/google/gwt/uibinder/sample
Revision: 6557
Author: rj...@google.com
Date: Thu Oct 29 22:34:03 2009
Log: Merges tr...@6554, 6555, 6556 into releases/2.0
uibinder.sample - uibinder.test, run parser tests, fix
XMLElementTestWarnings
svn merge --ignore-ancestry -r 6552:6556
34 matches
Mail list logo
