Re: [gwt-contrib] Re: Dev-Mode is not starting up, GWT compile works fine

2010-01-04 Thread John Tamplin
On Sun, Jan 3, 2010 at 1:02 PM, dflorey daniel.flo...@gmail.com wrote: I had to remove all gwt dependencies from the run configuration and restore the defaults to get rid of this error. Just in case someone else struggles... What version are you running? That was added as an optimization

[gwt-contrib] Re: Dev-Mode is not starting up, GWT compile works fine

2010-01-04 Thread dflorey
I've been running trunk but reverted back to 2.0 plugin. On Jan 4, 9:47 am, John Tamplin j...@google.com wrote: On Sun, Jan 3, 2010 at 1:02 PM, dflorey daniel.flo...@gmail.com wrote: I had to remove all gwt dependencies from the run configuration and restore the defaults to get rid of this

[gwt-contrib] Re: Comment on ImageResource in google-web-toolkit

2010-01-04 Thread codesite-noreply
Comment by osorioja...@gmail.com: Hey guys! Thx for this great work! Im not beeing able to link my imageresources with my widget (MVP). ImageResource does not have applyTo() Method which i need... http://www.gwtapps.com/doc/html/com.google.gwt.user.client.ui.AbstractImagePrototype.html {{{ /**

Re: [gwt-contrib] Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread BobV
On Sun, Jan 3, 2010 at 6:10 AM, dflorey daniel.flo...@gmail.com wrote: It would be great if the new ClientBundle would be used to style all gwt widgets. I think John probably has some ideas here. (btw: Why is it called ClientBundle and not ResourceBundle as it bundles up different

[gwt-contrib] Re: Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread dflorey
On Jan 4, 4:04 pm, BobV b...@google.com wrote: On Sun, Jan 3, 2010 at 6:10 AM, dflorey daniel.flo...@gmail.com wrote: It would be great if the new ClientBundle would be used to style all gwt widgets. I think John probably has some ideas here. (btw: Why is it called ClientBundle and not

Re: [gwt-contrib] Re: Dev-Mode is not starting up, GWT compile works fine

2010-01-04 Thread John Tamplin
On Mon, Jan 4, 2010 at 4:46 AM, dflorey daniel.flo...@gmail.com wrote: I've been running trunk but reverted back to 2.0 plugin. If you have an updated trunk, you shouldn't have this problem. If you do, please let me know. -- John A. Tamplin Software Engineer (GWT), Google --

Re: [gwt-contrib] Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread John LaBanca
We definitely plan to use ClientBundles to provide default stylings for all widgets, but we haven't really talked about how to go about doing that yet. Ideally, we want to use ClientBundles without breaking apps that are already using the existing CSS style themes. We could add ClientBundles to

Re: [gwt-contrib] Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread Joel Webber
What John said. There are a few difficult design problems in doing this properly -- i.e., with no overhead for those just using plain CSS, nor for those using CssResource/ClientBundle themes. I am confident the problem is soluble, though. On Mon, Jan 4, 2010 at 10:21 AM, John LaBanca

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

2010-01-04 Thread Joel Webber
I assume we're talking about the TabLayoutPanel issue, where the individual tabs are expanding to full width, and stacking up vertically. This appears to be happening in both IE8 and IE7 modes. This doesn't seem to happen normally -- the code in TabLayoutPanel uses float:left to cause the tabs to

Re: [gwt-contrib] StackLayoutPanel has no styles at all??

2010-01-04 Thread Joel Webber
Coming up with a general structure for stack header widgets (a la TabLayoutPanel tabs), such that you could achieve whatever style you like, proved very difficult in practice. I basically punted and just allowed you to add an arbitrary widget, which you can style however you like. I'm quite open

[gwt-contrib] Re: TabLayoutPanel not working on IE8

2010-01-04 Thread dflorey
Very strange. I've added float:left to each tab explicitly and now it is working. I guess it may be useful to provide a working default style. If you are interested I can post my funky rounded-border animated webkit/firefox style ;-) On Jan 4, 4:37 pm, Joel Webber j...@google.com wrote: I assume

[gwt-contrib] Re: StackLayoutPanel has no styles at all??

2010-01-04 Thread dflorey
Correct me if I'm wrong but I found it quite hard to apply a selected style to the selected stack panel header. I came up with a workaround like this: StackLayoutPanel danielStackPanel = new StackLayoutPanel (Style.Unit.PX) { @Override public void showWidget(Widget widget) { //

[gwt-contrib] Re: Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread dflorey
If you are interested I've already done this for my table branch in the incubator. It's a little bit outdated - I need to port the branch to 2.0... :-( The only show stopper I see right is that Messages/Contacts are not yet part of the ClientBundle, so I came up with something like this (copypaste

Re: [gwt-contrib] Re: Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread BobV
On Mon, Jan 4, 2010 at 11:17 AM, dflorey daniel.flo...@gmail.com wrote: The only show stopper I see right is that Messages/Contacts are not yet part of the ClientBundle, so I came up with something like this (copypaste from branch source): You can bridge them with a GwtCreateResource or add a

Re: [gwt-contrib] Re: Please add ClientBundle as optional parameter in each widget cstr

2010-01-04 Thread John Tamplin
On Mon, Jan 4, 2010 at 11:24 AM, BobV b...@google.com wrote: On Mon, Jan 4, 2010 at 11:17 AM, dflorey daniel.flo...@gmail.com wrote: The only show stopper I see right is that Messages/Contacts are not yet part of the ClientBundle, so I came up with something like this (copypaste from

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2010-01-04 Thread codesite-noreply
Comment by rda...@google.com: @yaoancheng: Sorry to hear that you're having troubles using the plugin. Here is some additional information that may help. Regarding #1, you can actually start two development mode sessions at the same time. What you need to do is modify the launch

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

2010-01-04 Thread Joel Webber
Which element did you have to add float:left to? It's set manually in code to the outermost tab element, which is all that *should* be necessary. On Mon, Jan 4, 2010 at 10:57 AM, dflorey daniel.flo...@gmail.com wrote: Very strange. I've added float:left to each tab explicitly and now it is

Re: [gwt-contrib] Re: StackLayoutPanel has no styles at all??

2010-01-04 Thread Joel Webber
You're right, there is no notification to stack-header widgets of their selection state. I'll make a note to add a standard way for them to be notified of this. As for standard CSS, with the current design (i.e., your own widget is the only header element), there's nothing to add a default style

[gwt-contrib] Re: JsDuplicateFunctionRemover

2010-01-04 Thread spoon
The code looks good, but I'd like to try it out before a final approval. Can you repost a patch with the missing little bits fixed up? http://gwt-code-reviews.appspot.com/126818/diff/1/2 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right):

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

2010-01-04 Thread Alejandro D. Garin
On Mon, Jan 4, 2010 at 2:01 PM, Joel Webber j...@google.com wrote: Which element did you have to add float:left to? It's set manually in code to the outermost tab element, which is all that *should* be necessary. Hi, I ran into the same issue with IE7/8 using the css example you suggested

[gwt-contrib] Re: JSNI references with * as the parameter list

2010-01-04 Thread bobv
http://gwt-code-reviews.appspot.com/126817/diff/2006/2007 File dev/core/test/com/google/gwt/dev/jjs/impl/JsniRefLookupTest.java (right): http://gwt-code-reviews.appspot.com/126817/diff/2006/2007#newcode234 Line 234: JMethod res = (JMethod) lookup(test.Bar::foo(*), errors); It seems weird that

[gwt-contrib] Re: RFE: deprecate user.client.Element and user.client.DOM

2010-01-04 Thread Joel Webber
I think I just inadvertently replied to this on another thread, but yes -- this is something we need to get on our roadmap very soon. On Dec 21 2009, 6:10 pm, Thomas Broyer t.bro...@gmail.com wrote: Hi Googlers, How about deprecating c.g.g.user.client.Element and c.g.g.user.client.DOM

[gwt-contrib] [google-web-toolkit] r7352 committed - Fix external issue 4048 - make java.sql.Timestamp emulation...

2010-01-04 Thread codesite-noreply
Revision: 7352 Author: r...@google.com Date: Mon Jan 4 11:06:23 2010 Log: Fix external issue 4048 - make java.sql.Timestamp emulation more lenient about the formatting of the nanoseconds field. Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7352 Modified:

[gwt-contrib] Re: JSNI references with * as the parameter list

2010-01-04 Thread Lex Spoon
On Mon, Jan 4, 2010 at 1:26 PM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/126817/diff/2006/2007 File dev/core/test/com/google/gwt/dev/jjs/impl/JsniRefLookupTest.java (right): http://gwt-code-reviews.appspot.com/126817/diff/2006/2007#newcode234 Line 234: JMethod res =

Re: [gwt-contrib] Possible bug in DOMImplMozilla

2010-01-04 Thread Joel Webber
Looks like you're right about that. @jlabanca: Correct me if I'm wrong, but didn't you refactor this stuff a while back? Mind having a look to make sure I'm not missing something? On Sun, Jan 3, 2010 at 2:37 PM, Thomas Broyer t.bro...@gmail.com wrote: Hi googlers, In DOMImplMozilla's

Re: [gwt-contrib] Removing the deprecated XxxListeners

2010-01-04 Thread Thomas Broyer
On Mon, Jan 4, 2010 at 7:45 PM, Joel Webber j...@google.com wrote: A hearty +1 from me. We've been needing to do this for a while, but have been so heads-down on new features that it's fallen by the wayside. On that note, we also need to deprecate the DOM class and fix all the widgets to not

Re: [gwt-contrib] Possible bug in DOMImplMozilla

2010-01-04 Thread John LaBanca
I'll look into it tomorrow morning. Thanks, John LaBanca jlaba...@google.com On Mon, Jan 4, 2010 at 2:37 PM, Joel Webber j...@google.com wrote: Looks like you're right about that. @jlabanca: Correct me if I'm wrong, but didn't you refactor this stuff a while back? Mind having a look to make

[gwt-contrib] Re: Benchmark for widget creation times

2010-01-04 Thread rjrjr
Picked up last rounds of feedback from Joel (EmptyBinder weirdness), Thomas and James. Also checkstyle fixes. Barring further objections, I'll submit this in the morning. There are more tests that could be implemented (Joel may have written them already), but I'd like to get in what I have.

[gwt-contrib] Re: Benchmark for widget creation times

2010-01-04 Thread Joel Webber
SGTM. I've got more to add once it's in. On Mon, Jan 4, 2010 at 8:29 PM, rj...@google.com wrote: Picked up last rounds of feedback from Joel (EmptyBinder weirdness), Thomas and James. Also checkstyle fixes. Barring further objections, I'll submit this in the morning. There are more tests

[gwt-contrib] [google-web-toolkit] r7353 committed - Fixes a checkstyle error introduced in r7352....

2010-01-04 Thread codesite-noreply
Revision: 7353 Author: kpro...@google.com Date: Mon Jan 4 19:21:08 2010 Log: Fixes a checkstyle error introduced in r7352. Review by: rice (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=7353 Modified: /trunk/user/super/com/google/gwt/emul/java/sql/Timestamp.java

[gwt-contrib] [google-web-toolkit] r7354 committed - URI-escape cookies (addresses external issue 4365)....

2010-01-04 Thread codesite-noreply
Revision: 7354 Author: kpro...@google.com Date: Mon Jan 4 20:00:50 2010 Log: URI-escape cookies (addresses external issue 4365). Review by: rice http://code.google.com/p/google-web-toolkit/source/detail?r=7354 Modified: /trunk/user/src/com/google/gwt/user/client/Cookies.java

[gwt-contrib] Re: URI-escape cookies (addresses external issue 4365)

2010-01-04 Thread kprobst
All done, thanks. Committed at r7354. On 2009/12/27 03:29:04, Dan Rice wrote: LGTM with minor nits. http://gwt-code-reviews.appspot.com/128801/diff/1/3 File user/src/com/google/gwt/user/client/Cookies.java (right): http://gwt-code-reviews.appspot.com/128801/diff/1/3#newcode112 Line 112:

[gwt-contrib] Re: Comment on ImageResource in google-web-toolkit

2010-01-04 Thread codesite-noreply
Comment by c...@chi.ca: It looks like the applyTo() method has been replaced with Image.setResource() http://google-web-toolkit.googlecode.com/svn/javadoc/2.0/com/google/gwt/user/client/ui/Image.html#setResource(com.google.gwt.resources.client.ImageResource) For more information: