On Fri, Mar 5, 2010 at 9:35 PM, Ray Cromwell cromwell...@gmail.com wrote:
I have a prototype benchmark that can load your app N times using
WebDriver, injecting a __gwtStatsEvent function which records
load/parse times, I'll see if I can get a patch of it up.
That'd be awesome, thanks!
I
Reviewers: jgw,
Description:
Updates the IFRame and XS selection script templates to support
inlined selection scripts. There are two changes involved:
1. There is a baseUrl meta property that can be used to override
the choice of base URL.
2. Meta tags can be made to apply to only module
Joel, can you review this?
http://gwt-code-reviews.appspot.com/159810/diff/1/3
File dev/core/src/com/google/gwt/core/linker/XSTemplate.js (left):
http://gwt-code-reviews.appspot.com/159810/diff/1/3#oldcode291
Line 291: processMetas();
This ordering is necessary because the meta props now
Just idle curiosity here, but why did you have to make the same change
twice? I know you're modifying selection scripts, and maybe that
means you need to violate DRY for some reason, but it strikes me as a
potential refactoring.
Ian
On Mon, Mar 8, 2010 at 9:23 AM, sp...@google.com wrote:
Mostly LGTM, except for the concern about JNewInstance.isEmpty(). It
looks like JNewInstance.isEmpty() should be computed within
RemoveEmptySuperCalls to be efficient, or for that matter, to reliably
terminate.
There are also some nits.
http://gwt-code-reviews.appspot.com/159803/diff/1/3
Reviewers: Lex,
Message:
Here's an example of what the new loader output looks like:
package com.google.gwt.lang.asyncloaders;
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.RunAsyncCallback;
import com.google.gwt.core.client.impl.AsyncFragmentLoader;
public class
http://gwt-code-reviews.appspot.com/159803/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java (right):
http://gwt-code-reviews.appspot.com/159803/diff/1/3#newcode64
Line 64: public boolean isEmpty() {
Good call. Adding a method comment.
LGTM
http://gwt-code-reviews.appspot.com/159810/diff/1/2
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
http://gwt-code-reviews.appspot.com/159810/diff/1/2#newcode200
Line 200: }
Clever. I like it.
http://gwt-code-reviews.appspot.com/159810/diff/1/3
File
@Ian: I know, it's nasty. These things have gotten a bit out of hand, and we
have a big, fat TODO to come back and clean this up (as well as to bring
together various other linkers under a more coherent umbrella). But we
probably won't be able to get around to it for at least another quarter,
I added a new patch that caches the lengths but not the actual style
sheet contents. In the worst case, if the lengths are wrong we will
just append in a suboptimal way, but not lose any data. Benchmarking
shows that the performance difference is minor -- still just 2-3 ms per
injection in my
Reviewers: amitmanjhi,
Description:
Changes for crawling:
- CrawlableHyperlink
- client-side changes to Showcase sample
Please review this at http://gwt-code-reviews.appspot.com/161801
Affected files:
M samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java
M
Please don't laugh (at least not out loud).
I've run into a situation where I really need to use a JavaCC
generated parser on the client-side. The generated code is all simple
Java, except for its use of java.io.InputStream and java.io.Reader.
Is it possible to implement additional GWT JRE
On Mon, Mar 8, 2010 at 12:37 PM, Ian Petersen ispet...@gmail.com wrote:
Just idle curiosity here, but why did you have to make the same change
twice? I know you're modifying selection scripts, and maybe that
means you need to violate DRY for some reason, but it strikes me as a
potential
Look at the user/super/com/google/gwt/emul source for the GWT JRE
emulation, e.g.
http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/super/com/google/gwt/emul/Emulation.gwt.xml
super-source/ is what you want. It allows Web mode and Hosted Mode
to see different source code.
-Ray
http://gwt-code-reviews.appspot.com/159803/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java (right):
http://gwt-code-reviews.appspot.com/159803/diff/1/3#newcode80
Line 80: if (expr instanceof JMethodCall) {
I see. It looks good now.
Reviewers: cromwellian,
Description:
Give a better error message when RunAsyncCode.runAsyncCode is passed
something
other than a class literal.
Please review this at http://gwt-code-reviews.appspot.com/162801
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
Revision: 7686
Author: sp...@google.com
Date: Mon Mar 8 12:02:36 2010
Log: Updates the IFRame and XS selection script templates to support
inlined selection scripts. There are two changes involved:
1. There is a baseUrl meta property that can be used to override
the choice of base URL.
2.
I left out a file. Creating a new issue.
http://gwt-code-reviews.appspot.com/162801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Description:
Give a better error message when RunAsyncCode.runAsyncCode is passed
something
other than a class literal.
Please review this at http://gwt-code-reviews.appspot.com/161802
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
Can you review this, Ray?
In trunk, the compiler generates an internal compiler exception if
runAsyncCode is called with something other than a class literal as an
argument. This fixes that problem, and while at it, updates all the
other error messages in ReplaceRunAsyncs to be more
http://gwt-code-reviews.appspot.com/161801/diff/1/3
File samples/showcase/war/Showcase.html (right):
http://gwt-code-reviews.appspot.com/161801/diff/1/3#newcode4
Line 4: script language='javascript'
Any disadvantage to leaving the title here (even though you are setting
it later)? At least,
One more question - how to know which person to invite for a code
review?
On Mar 7, 11:11 am, Marko Vuksanovic markovuksano...@gmail.com
wrote:
I have created a patch that enables user to create Grid and its child
elements using UiBinder (issue 4705
http://gwt-code-reviews.appspot.com/159803/diff/1/25
File dev/core/src/com/google/gwt/dev/jjs/impl/RemoveEmptySuperCalls.java
(right):
http://gwt-code-reviews.appspot.com/159803/diff/1/25#newcode50
Line 50: ctx.replaceMe(multi.makeStatement());
Oh, I see your point. :( Yeah, that'd be a
You don't, really. I'm the right person in this case, and you're right near
the top of my todo list. Sorry I haven't gotten to it yet.
On Mon, Mar 8, 2010 at 3:46 PM, Marko Vuksanovic
markovuksano...@gmail.comwrote:
One more question - how to know which person to invite for a code
review?
On
Revision: 7687
Author: gwt.mirror...@gmail.com
Date: Mon Mar 8 13:39:42 2010
Log: Initial code that uses org.json lib on the server side, passes actual
request
parameters, plus integration with server side domain objects.
Review at http://gwt-code-reviews.appspot.com/160809
Review by:
Ray and I pair-programmed and commited this patch
http://code.google.com/p/google-web-toolkit/source/detail?r=7687
Ray: please close this issue.
http://gwt-code-reviews.appspot.com/160809/diff/1/9
File bikeshed/src/com/google/gwt/valuestore/shared/Property.java
(right):
Reviewers: jat,
Description:
Fix the escaping of a String used in one of test methods of
JsonpRequestTest
Please review this at http://gwt-code-reviews.appspot.com/163801
Affected files:
user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java
Index:
27 matches
Mail list logo
