I don't quite understand what this change in RemoteServiceServlet has to
do with UrlBuilder...
http://gwt-code-reviews.appspot.com/754803/diff/21001/22002
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
(right):
Okay, so here's my main issue with the general idea. As far as I can
tell, the lifetime of the 'storage' is the same as the lifetime of
generator instances.
I sort of see how it's expedient to have it accessible via
GeneratorContext... however, the downside is you give up static typing
and red
http://gwt-code-reviews.appspot.com/829801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/831802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8697
Author: amitman...@google.com
Date: Thu Sep 2 04:06:39 2010
Log: Remove the unnecessary dependency of the expenses sample on AspectJ.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
http://code.google.com/p/google-web-toolkit/source/detail?r=8697
Modified:
On 2010/09/02 13:44:49, scottb wrote:
Okay, so here's my main issue with the general idea. As far as I can
tell, the
lifetime of the 'storage' is the same as the lifetime of generator
instances.
I thought we agreed after discussing the previous patch for this that
the GeneratorContext was
http://gwt-code-reviews.appspot.com/829801/diff/7001/8002
File user/src/com/google/gwt/user/User.gwt.xml (right):
http://gwt-code-reviews.appspot.com/829801/diff/7001/8002#newcode51
user/src/com/google/gwt/user/User.gwt.xml:51: inherits
name=com.google.gwt.safehtml.SafeHtml /
Maybe alphabetize?
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode88
dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:88: * com /
google / gwt / core /
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004
File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right):
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257
dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java:257: }
Are we going to need to loop
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004
File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right):
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257
dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java:257: }
The short answer is no: the
LGTM2
On Thu, Sep 2, 2010 at 11:30 AM, sco...@google.com wrote:
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004
File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right):
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257
Revision: 8698
Author: sco...@google.com
Date: Thu Sep 2 05:59:40 2010
Log: Fixes a strange compiler bug where types generated into new packages
may not be found.
The bug happened to me when generating types into a package which didn't
exist on disk, in this
http://gwt-code-reviews.appspot.com/829801/diff/7001/8003
File user/src/com/google/gwt/user/client/ui/ButtonBase.java (right):
http://gwt-code-reviews.appspot.com/829801/diff/7001/8003#newcode50
user/src/com/google/gwt/user/client/ui/ButtonBase.java:50:
extra spaces
Revision: 8699
Author: rj...@google.com
Date: Thu Sep 2 06:12:48 2010
Log: Revert r8691 due to api break
[Was: Add debugging information to CssResource.]
http://code.google.com/p/google-web-toolkit/source/detail?r=8699
Deleted:
Revision: 8700
Author: fabb...@google.com
Date: Thu Sep 2 09:18:59 2010
Log: This should have been in r8671
http://code.google.com/p/google-web-toolkit/source/detail?r=8700
Modified:
/trunk/eclipse/settings/code-style/gwt-checkstyle.xml
===
---
http://gwt-code-reviews.appspot.com/828801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Patch Set 2 updates DOMRtlTest, which was never really in RTL mode until
DockLayoutPanelRtlTest came along. The body isn't put into RTL mode
until RootPanel.get() is called, but DOMRtlTest never called it.
I also renamed DockLayoutPanelTestRtl to DockLayoutPanelRtlTest.
Revision: 8701
Author: to...@google.com
Date: Thu Sep 2 07:29:17 2010
Log: Support adding code-gen/runtime related classes directly to the
secondary JDT compilation for the GWT AST.
Review at http://gwt-code-reviews.appspot.com/830801
Reviewers: rice,
Description:
Fixes a bug in LayoutImplIE8 where we convert the unit conversition to
an integer before multiplying by the height/width, resulting in too much
rounding. For example, 12pt becomes 12px instead of 15px because the
conversion factor (1.33) is converted to 1. We now
LGTM
http://gwt-code-reviews.appspot.com/834801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'll review the rest separately, but I wanted to get this to you first.
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode74
The i18n stuff looks good except where commented.
http://gwt-code-reviews.appspot.com/826802/diff/3001/4004
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4004#newcode402
Reviewers: rjrjr,
Message:
Review requested.
The SimpleBeanEditorDriver will be used to test general Editor framework
behavior without requiring the use of RequestFactory.
Description:
Factor a bean-like-object editor framework out of the RequestFactory
editor work.
Add editor.client.adapters
Revision: 8704
Author: r...@google.com
Date: Thu Sep 2 09:08:23 2010
Log: Missing file from SafeHtml work + whitespace fix
http://code.google.com/p/google-web-toolkit/source/detail?r=8704
Modified:
http://gwt-code-reviews.appspot.com/829801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8705
Author: jlaba...@google.com
Date: Thu Sep 2 09:39:09 2010
Log: Fixes a bug in LayoutImplIE8 where we convert the unit conversition to
an integer before multiplying by the height/width, resulting in too much
rounding. For example, 12pt becomes 12px instead of 15px because the
Reviewers: rice,
Description:
Adding RTL support to the images used in CellTree. Removing automatic
keyboard focus from the constructor because it can result in an
IndexOutOfBoundsEception if the tree nodes are loaded asynchronously.
Please review this at
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/836801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/835801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8707
Author: amitman...@google.com
Date: Thu Sep 2 10:56:13 2010
Log: Added tests for constraint violations.
Patch by: amitmanjhi
Review by: robertvawter,fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=8707
Modified:
/trunk/user/build.xml
Reviewers: rice,
Description:
Refactoring the Showcase sample to use standards mode, and make use of
LayoutPanels. The new Showcase looks different, but the features are the
same. The main menu is now a CellTree backed by a TreeViewModel. The
Application class, which used to perform active
In brief: URIs (RFC 3986) is a mess, and back to URL.encode for the path
in UrlBuilder? (with a second pass though)
http://gwt-code-reviews.appspot.com/754803/diff/21001/22002
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
(right):
Reviewers: rjrjr,
Description:
Renamed *Record* to *Proxy*. Also renamed variables in a few classes.
Renamed DataTransferObject - ProxyFor.
patch by: amitmanjhi
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/825802/show
Affected files:
M
LGTM for i18n parts.
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/825802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/09/02 23:35:48, amitmanjhi wrote:
http://gwt-code-reviews.appspot.com/825802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8708
Author: son...@google.com
Date: Thu Sep 2 13:27:55 2010
Log: Add @UiChild annotation to specify how UiBinder should add a child
element.
Patch by: sonnyf
Reviw by: bobv, rjrjr
Review at http://gwt-code-reviews.appspot.com/794801
Wow, nice to see it's such a small change. And using tag rather than
span is a good choice.
Rather than having that funky protected field, how about adding an
overload of nextPlaceholder that doesn't take an example, and defaults
to tag
On 2010/09/02 23:40:14, mbx wrote:
Revision: 8709
Author: j...@google.com
Date: Thu Sep 2 14:24:35 2010
Log: Rolling back the following due to test failures:
Added tests for constraint violations.
Patch by: amitmanjhi
Review by: robertvawter,fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=8709
Modified:
What is the plan to bring incubator into compatability with gwt 2.1 ?
Cheers
Cameron
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Message:
Review requested.
Description:
Clarify EditorDriver behavior with combinations of Editor mix-in
interfaces through brute-force testing.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/840801/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/840801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8710
Author: b...@google.com
Date: Thu Sep 2 16:22:41 2010
Log: Clarify EditorDriver behavior with combinations of Editor mix-in
interfaces through brute-force testing.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/840801
Reviewers: scottb, robertvawter, cromwellian,
Description:
RR: Add statistics to optimizers
Updates the compiler optimizers to returns statistics about each pass
instead of a simple boolean. This could be used to analyze
the effectiveness of an individual optimizer, tune the compiler
for code
On 2010/09/03 03:38:46, zundel wrote:
Just a general comment, if you want to get even more granularity, look
at this old path of mine, which instrumented MethodInliner to give
really good information on exactly how many times something was inlined
vs not, and a count of the failure types, which
I'm looking for feedback on this proposed change, mainly, is the statistical
information worth the added complexity? Currently, this only dumps out a
diagnostic when you specify
-Dgwt.jjs.traceMethods=com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.optimize
on the Compiler command line.
47 matches
Mail list logo
