Reviewers: bobv, rjrjr,
Description:
Copied from the issue tracker:
The real issue seems to be in how
com.google.gwt.requestfactory.client.impl.RequestFactoryEditorDelegate
determines whether it shouldFlush() or not: it only deals with am I in
'read-only' mode or not (if request==null, edited
Hi G-men,
You seem to be working actively on preparing a 2.2 release very soon, and
I'm hoping that some issues (some of which I've provided a patch for) will
be resolved in this release. One issue that's a blocker for us is related to
ListEditor when used with
Reviewers: rjrjr,
Description:
Tone down the experimental api warning.
Please review this at http://gwt-code-reviews.appspot.com/1285801/show
Affected files:
M user/src/com/google/gwt/canvas/client/Canvas.java
M user/src/com/google/gwt/canvas/dom/client/CanvasGradient.java
M
Revision: 9529
Author: ncha...@google.com
Date: Thu Jan 13 08:23:15 2011
Log: Spelling
http://code.google.com/p/google-web-toolkit/source/detail?r=9529
Modified:
/wiki/BeanValidation.wiki
===
--- /wiki/BeanValidation.wiki Mon Jan 3 14:43:03 2011
+++
LGTM
http://gwt-code-reviews.appspot.com/1285801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9530
Author: gwt.mirror...@gmail.com
Date: Thu Jan 13 09:45:23 2011
Log: Cherry picking r9527 into releases/2.2 branch for
http://code.google.com/p/google-web-toolkit/issues/detail?id=5869
http://code.google.com/p/google-web-toolkit/source/detail?r=9530
Modified:
Revision: 9531
Author: rchan...@google.com
Date: Thu Jan 13 04:56:44 2011
Log: Removing client-side validation from GWT 2.2 as it is not yet in a
working state.
http://code.google.com/p/google-web-toolkit/source/detail?r=9531
Deleted:
/releases/2.2/samples/validation
Revision: 9533
Author: ncha...@google.com
Date: Thu Jan 13 05:39:51 2011
Log: Add TCK jars to user .classpath
Review by: knor...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9533
Modified:
/trunk/eclipse/user/.classpath
===
---
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010
File user/src/com/google/gwt/user/server/Util.java (right):
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010#newcode76
user/src/com/google/gwt/user/server/Util.java:76: * @throws
IllegalStateException if duplicate cookies
Attached to http://code.google.com/p/google-web-toolkit/issues/detail?id=5873
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9534
Author: p...@google.com
Date: Thu Jan 13 07:07:25 2011
Log: Cherry picking r9528 into the release branch
http://code.google.com/p/google-web-toolkit/source/detail?r=9534
Modified:
/releases/2.2/user/src/com/google/gwt/canvas/client/Canvas.java
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010
File user/src/com/google/gwt/user/server/Util.java (right):
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010#newcode76
user/src/com/google/gwt/user/server/Util.java:76: * @throws
IllegalStateException if duplicate cookies
On Thu, Jan 13, 2011 at 10:53, j...@google.com wrote:
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010
File user/src/com/google/gwt/user/server/Util.java (right):
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010#newcode76
Reviewers: scottb, robertvawter,
Description:
Add optimizations for redundant and trivial 'switch' statements
Please review this at http://gwt-code-reviews.appspot.com/1286801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
A
Revision: 9535
Author: gwt.mirror...@gmail.com
Date: Thu Jan 13 12:31:52 2011
Log: Change the gecko 2.0 dynamic linux libs to be stripped so that
codesite doesn't barf on them and to save space)
http://code.google.com/p/google-web-toolkit/source/detail?r=9535
Added:
Revision: 9536
Author: rj...@google.com
Date: Thu Jan 13 12:25:22 2011
Log: Public (t.bro...@gmail.com):
Uses the java.beans.Introspector#decapitalize instead of manual
decapitalization of setter-method names to attribute names. This
means setHTML() can be set using an all-caps HTML= attribute,
Revision: 9537
Author: rj...@google.com
Date: Thu Jan 13 09:40:51 2011
Log: Cherry picking r9536 releases/[rel_#] for issue 4781
http://code.google.com/p/google-web-toolkit/source/detail?r=9537
Modified:
/releases/2.2/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
Revision: 9538
Author: sco...@google.com
Date: Thu Jan 13 09:40:26 2011
Log: Cache ModuleDefs by context ClassLoader.
GWT Designer need separated class loader for every open project.
http://gwt-code-reviews.appspot.com/1274801/show
Patch by: amitin
Review by: me,zundel
Reviewers: bobv, scottb,
Description:
Fixes a bug in JavaScriptObject support in DevMode that prevents
dispatching
through an interface to a method defined in a super-interface. The
change
also includes a new test to serve as a regression test.
Please review this at
LGTM
http://gwt-code-reviews.appspot.com/1287801/diff/1/2
File
dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.java
(right):
http://gwt-code-reviews.appspot.com/1287801/diff/1/2#newcode272
http://gwt-code-reviews.appspot.com/1287801/diff/1/3
File
user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
(right):
http://gwt-code-reviews.appspot.com/1287801/diff/1/3#newcode205
user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java:205:
Element element =
Revision: 9539
Author: rj...@google.com
Date: Thu Jan 13 10:46:47 2011
Log: Cherry picking r9538 into releases/2.2
http://code.google.com/p/google-web-toolkit/source/detail?r=9539
Modified:
/releases/2.2/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
http://gwt-code-reviews.appspot.com/1287801/diff/1/3
File
user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
(right):
http://gwt-code-reviews.appspot.com/1287801/diff/1/3#newcode205
user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java:205:
Element element =
On Thu, Jan 13, 2011 at 2:24 PM, knor...@google.com wrote:
To be honest, I don't know what our JSO tests currently cover. My intent
was to put my case in as a regression and try to follow up with some
more robust testing strategies. Do you anticipate a problem that is not
covered with our
No, it's a good point. I'm realizing we probably need some more tests
covering a lot fo the patterns that are possible after Joel's change to
loosen some of the interface restrictions.
On 2011/01/13 22:32:43, cromwellian wrote:
On Thu, Jan 13, 2011 at 2:24 PM, mailto:knor...@google.com wrote:
http://gwt-code-reviews.appspot.com/1287801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1278801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Mostly LG.
http://gwt-code-reviews.appspot.com/1286801/diff/1/3
File dev/core/src/com/google/gwt/dev/js/JsDuplicateCaseFolder.java
(right):
http://gwt-code-reviews.appspot.com/1286801/diff/1/3#newcode130
dev/core/src/com/google/gwt/dev/js/JsDuplicateCaseFolder.java:130:
String body =
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010
File user/src/com/google/gwt/user/server/Util.java (right):
http://gwt-code-reviews.appspot.com/1251801/diff/44001/45010#newcode76
user/src/com/google/gwt/user/server/Util.java:76: * @throws
IllegalStateException if duplicate cookies
http://gwt-code-reviews.appspot.com/1251801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Move the TCK report task to user/build.xml and
delete samples/validationtck
Please review this at http://gwt-code-reviews.appspot.com/1288801/show
Affected files:
D samples/validationtck/README.txt
D samples/validationtck/build.xml
D
Revision: 9540
Author: gwt.mirror...@gmail.com
Date: Thu Jan 13 13:31:09 2011
Log: Adds a hook to invalidate a rebind within dev mode (from Alexander
Mitin)
Review at http://gwt-code-reviews.appspot.com/1275801
Review by: rj...@google.com
http://gwt-code-reviews.appspot.com/1287801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Fix a generics compile error on OSX java 1.6
Please review this at http://gwt-code-reviews.appspot.com/1289801/show
Affected files:
M
user/test/com/google/gwt/requestfactory/client/RequestFactoryTestBase.java
Index:
Thanks Ray,
I didn't actually change the logic in writeTrampoline in the last patch,
but I realized that an identical change there actually fixes this
problem for the Java objects as well. Can you give it another quick
look?
http://gwt-code-reviews.appspot.com/1287801/show
--
LGTM
http://gwt-code-reviews.appspot.com/1287801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9541
Author: gwt.mirror...@gmail.com
Date: Thu Jan 13 13:57:26 2011
Log: Cherry picking r9540 into releases/2.2, Adds a hook to invalidate a
rebind within dev mode
http://code.google.com/p/google-web-toolkit/source/detail?r=9541
Modified:
LGTM
On 2011/01/14 01:17:55, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1289801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9542
Author: knor...@google.com
Date: Thu Jan 13 15:08:15 2011
Log: Fixes a bug in JavaScriptObject support in DevMode that prevents
dispatching
through an interface to a method defined in a super-interface. The change
also includes a new test to serve as a regression test.
Review
Hey everyone,
Just a quick question, I was looking through the MVP docs:
http://code.google.com/webtoolkit/doc/latest/DevGuideMvpActivitiesAndPlaces.html#Places
and in the Place section there is a paragraph that eludes to a
BasicPlace class. It says:
Many Places in your app might not save any
40 matches
Mail list logo
