Reviewers: zundel,
Description:
Fix inconsistent use of finishTest() in RequestFactoryTest.
Patch by: bobv
Review by: zundel
Please review this at http://gwt-code-reviews.appspot.com/1421808/
Affected files:
M
Revision: 10095
Author: gwt.mirror...@gmail.com
Date: Thu Apr 28 03:49:08 2011
Log: Making ui:style builders always called in the Widgets ctor. Also
add a
final clause in field builders.
Review at http://gwt-code-reviews.appspot.com/1422814
http://gwt-code-reviews.appspot.com/1424801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I have removed the out-of-date comment and ran a smoke test with a fresh
pull of GWT. Everything is checking out.
http://gwt-code-reviews.appspot.com/1424801/diff/1/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
File user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
Reviewers: rjrjr, rdcastro,
Description:
Moving back missing clauses from previous changes.
Please review this at http://gwt-code-reviews.appspot.com/1425812/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
M
Revision: 10096
Author: mrruss...@google.com
Date: Thu Apr 28 08:32:25 2011
Log: changed the mime-type
http://code.google.com/p/google-web-toolkit/source/detail?r=10096
Modified:
/javadoc/2.3/allclasses-frame.html
/javadoc/2.3/allclasses-noframe.html
http://gwt-code-reviews.appspot.com/1423810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1425812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
Rafa, your patches keep missing
Google-Web-Toolkit-Contributors@googlegroups.com on the cc line.
http://gwt-code-reviews.appspot.com/1420813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks guys!
On Wed, Apr 27, 2011 at 9:36 PM, Daniel Bell daniel.r.b...@gmail.comwrote:
We just upgraded 3 apps too, with one gotcha: it turns out that you need to
do a find/replace on com.google.gwt.requestfactory.client. -
com.google.web.bindery.requestfactory.gwt.client. before you
do
http://gwt-code-reviews.appspot.com/1421805/diff/1/user/src/com/google/gwt/codegen/server/AbortablePrintWriter.java
File user/src/com/google/gwt/codegen/server/AbortablePrintWriter.java
(right):
On Wed, Apr 27, 2011 at 10:56 PM, Patrick Julien pjul...@gmail.com wrote:
How does this actually work?
class MyEditor implements HasRequestConextFoo {
// HasRequestContext extends the Editor interface
}
If I implement HasRequestContextT anywhere, the containing request
factory editor driver
Sorry, I think it's my fault for adding --cc orkut-latency-eng (Rietveld
probably replaces the default instead of appending). I'll pay attention to
that enxt next time.
cheers,
rafa
On Thu, Apr 28, 2011 at 1:28 PM, rj...@google.com wrote:
lgtm
Rafa, your patches keep missing
http://gwt-code-reviews.appspot.com/1425811/diff/5001/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
File
user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
(right):
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the review.
http://gwt-code-reviews.appspot.com/1425810/diff/6/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
Revision: 10098
Author: zun...@google.com
Date: Thu Apr 28 06:57:23 2011
Log: Handle ClassFormatException in JDTCompiler when creating
NameEnvironmentAnswer objects.
Review at http://gwt-code-reviews.appspot.com/1425810
LGTM++
On Thu, Apr 28, 2011 at 10:27 AM, unn...@google.com wrote:
http://gwt-code-reviews.appspot.com/1425811/diff/5001/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
File
user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
(right):
Revision: 10099
Author: gwt.mirror...@gmail.com
Date: Thu Apr 28 07:35:39 2011
Log: Fix inconsistent use of finishTest() in RequestFactoryTest.
Review at http://gwt-code-reviews.appspot.com/1421808
Patch by: bobv
Review by: zundel
The log is this:
Compiling module net.odgn.plasma.Plasma
Scanning for additional dependencies:
file:/C:/Users/pjulien/Documents/odgn/bin/plasma/src/net/odgn/plasma/client/presenter/admin/game/ui/EditGameView.java
Adding '17' new generated units
Validating newly compiled units
Revision: 10100
Author: unn...@google.com
Date: Thu Apr 28 07:48:08 2011
Log: Add ability to include SafeHtml objects in dom based UI's if the
laay widget option is being used (this is the only way that the setters
will work correctly)
Review at
I believe you're experiencing this
issue: http://code.google.com/p/google-web-toolkit/issues/detail?id=6016
You're probably running into it because you implement both IsEditor and
Editor (through HasRequestContext), so the link between the parent editor
and an instance of
Revision: 10101
Author: sco...@google.com
Date: Thu Apr 28 08:18:20 2011
Log: EnumOrdinalizer cleanup, and fix ICE on empty enums.
- Change to MethodInliner removes spurious casts and the need for
special-case
code in EnumOrdinalizer.
- Fix a case in EnumOrdinalizer were we'd try
Reviewers: rjrjr,
Description:
Check for IsWidget rather than Widget when determining if a class is a
Widget in UiBinder
Please review this at http://gwt-code-reviews.appspot.com/1421809/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index:
I will patch this and test it in raptical
On Thu, Apr 28, 2011 at 11:59 AM, unn...@google.com wrote:
Reviewers: rjrjr,
Description:
Check for IsWidget rather than Widget when determining if a class is a
Widget in UiBinder
Please review this at http://gwt-code-reviews.appspot.com/1421809/
It looks like that would fix
http://code.google.com/p/google-web-toolkit/issues/detail?id=5662 and
http://code.google.com/p/google-web-toolkit/issues/detail?id=5744 (and
possibly http://code.google.com/p/google-web-toolkit/issues/detail?id=5509 but
I'm not so sure)
--
Revision: 10102
Author: rdcas...@google.com
Date: Thu Apr 28 08:49:13 2011
Log: Fixing TODOs; rename UiBinderWriter methods for generating tokens
for SafeHtml instances and safe constants.
Review at http://gwt-code-reviews.appspot.com/1420813
Review by: rj...@google.com
Revision: 10103
Author: gwt.mirror...@gmail.com
Date: Thu Apr 28 09:13:20 2011
Log: Rolling back due to test failures
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10103
Deleted:
It looks like that would fix
Huh. Yeah, that is interesting. Is the widgets must extend Widget
restriction being loosened?
Per WhyWidgetIsAClass, I thought that was pretty set in stone.
- Stephen
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Just to clarify - this patch was a proposed fix to some issues which
resulted from http://gwt-code-reviews.appspot.com/1425811. For now, we
actually just rolled back that patch to figure out exactly how we want to
fix it.
- Unnur
On Thu, Apr 28, 2011 at 12:33 PM, Stephen Haberman
Reviewers: scottb,
Description:
Changes the policy for how to behave when the persistent unit cache
can't
be created. Prior to this change, the program would thrown an
UnableToComplete
exception and you'd have to start over. Now, a warning is printed and
the
process continues, reverting back
Thanks Thomas, I'm starting to think you know all 6000~ tickets in the
issue tracker from memory. However, I was only pointing it out here,
this is a nice feature to have since this was a 2.2 code base where I
was propagating the RequestContext myself
On Thu, Apr 28, 2011 at 2:44 PM, Thomas
Revision: 10104
Author: zun...@google.com
Date: Thu Apr 28 09:54:26 2011
Log: Changes the policy for how to behave when the persistent unit
cache can't
be created. Prior to this change, the program would thrown an
UnableToComplete
exception and you'd have to start over. Now, a
It is already the case that you can use IsWidget interfaces as elements in a
ui.xml file.
On Thu, Apr 28, 2011 at 12:33 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
It looks like that would fix
Huh. Yeah, that is interesting. Is the widgets must extend Widget
restriction being
It is already the case that you can use IsWidget interfaces as
elements in a ui.xml file.
Wow, I'm surprised. I'll have to retract a few comments in those bugs
then.
- Stephen
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10105
Author: gwt.mirror...@gmail.com
Date: Thu Apr 28 10:23:18 2011
Log: Moving back missing clauses from previous changes.
Review at http://gwt-code-reviews.appspot.com/1425812
http://code.google.com/p/google-web-toolkit/source/detail?r=10105
Modified:
Reviewers: unnurg,
Description:
Add ability to include SafeHtml objects in dom based UI's if the lazy
widget option is being used (this is the only way that the setters
will work correctly).
Adds missing integration test for @UiChild, covering bug exposed by
the first shot at this change.
Addressed style nites, see delta between patchset 3 4.
http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java
File dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java (left):
LGTM
http://gwt-code-reviews.appspot.com/1420814/diff/1/user/test/com/google/gwt/uibinder/test/client/UiChildTest.java
File user/test/com/google/gwt/uibinder/test/client/UiChildTest.java
(right):
http://gwt-code-reviews.appspot.com/1420814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Okay, done, now with passing JRE tests.
On Thu, Apr 28, 2011 at 2:35 PM, rj...@google.com wrote:
http://gwt-code-reviews.appspot.com/1420814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM once you upload the most recent changes I saw
http://gwt-code-reviews.appspot.com/1421805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: fabbott, scottb,
Description:
Allows CompileOnePerm and ComponePerms to accept all of Precompile's
Options
Please review this at http://gwt-code-reviews.appspot.com/1421810/
Affected files:
M dev/core/src/com/google/gwt/dev/CompileOnePerm.java
M
Revision: 10107
Author: rj...@google.com
Date: Thu Apr 28 15:24:12 2011
Log: Add ability to include SafeHtml objects in dom based UI's if the
lazy
widget option is being used (this is the only way that the setters
will work correctly).
Adds missing integration test for @UiChild,
r10107
http://gwt-code-reviews.appspot.com/1420814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1422810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10108
Author: zun...@google.com
Date: Thu Apr 28 12:40:31 2011
Log: Allows CompileOnePerm and ComponePerms to accept all of
Precompile's Options
Review at http://gwt-code-reviews.appspot.com/1421810
http://code.google.com/p/google-web-toolkit/source/detail?r=10108
http://gwt-code-reviews.appspot.com/1421805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1421810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM ++
On 2011/04/28 23:35:48, jat wrote:
http://gwt-code-reviews.appspot.com/1421805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10110
Author: rj...@google.com
Date: Thu Apr 28 13:42:59 2011
Log: Rollback of r10107 due to broken ui binder templates
Was
Add ability to include SafeHtml objects in dom based UI's if the lazy
widget option is being used (this is the only way that the setters
will work
Reviewers: jbrosenberg, cromwellian,
Message:
If you use -XdisableCastChecking, CastNormalizer REMOVES cast operations
from the AST entirely; this causes loss of type information just before
final prune, which is really bad. We should never lose information that
way.
Ordinarily, CastNormalizer
LGTM
http://gwt-code-reviews.appspot.com/1425813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/28 15:57:22, jlabanca wrote:
http://gwt-code-reviews.appspot.com/1423810/diff/1/user/src/com/google/gwt/dom/client/SourceElement.java
File user/src/com/google/gwt/dom/client/SourceElement.java (right):
LGTM
with a couple questions
http://gwt-code-reviews.appspot.com/1425813/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
(right):
Gracias.
http://gwt-code-reviews.appspot.com/1425813/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
(right):
Revision: 10111
Author: sco...@google.com
Date: Thu Apr 28 15:00:16 2011
Log: Do not remove type information before final prune.
If you use -XdisableCastChecking, CastNormalizer REMOVES cast operations
from the AST entirely; this causes loss of type information just before
final
Hi,
It was mentioned that private methods could be nominated for potential
loosening to protected based on need/usage. One method I'd like to see
made protected is CompositeCell.onBrowserEventImpl.
I have a CompositeCell subclass with different DOM walking logic in its
overridden onBrowserEvent
Reviewers: unnurg,
Description:
Adds ability to include SafeHtml objects in dom based UI's if the lazy
widget option is being used (this is the only way that the setters
will work correctly).
Adds missing integration test for @UiChild, covering bugs exposed by
the first couple of shots at this
Third time's the charm, right?
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
61 matches
Mail list logo
